Merge pull request #12900 from owncloud/more-accessibility

More accessibility fixes for Files

apps/files/js/breadcrumb.js

@@ -106,6 +106,7 @@
 				if (part.img) {
 					$image = $('<img class="svg"></img>');
 					$image.attr('src', part.img);
+					$image.attr('alt', part.alt);
 					$link.append($image);
 				}
 				this.breadcrumbs.push($crumb);
@@ -151,6 +152,7 @@
 			crumbs.push({
 				dir: '/',
 				name: '',
+				alt: t('files', 'Home'),
 				img: OC.imagePath('core', 'places/home.svg')
 			});
 			for (var i = 0; i < parts.length; i++) {

apps/files/js/fileactions.js

@@ -289,7 +289,9 @@
 			}
 			var $actionLink = $('<a href="#" original-title="' +
 				escapeHTML(deleteTitle) +
-				'" class="action delete icon-delete" />'
+				'" class="action delete icon-delete">' +
+				'<span class="hidden-visually">' + escapeHTML(deleteTitle) + '</span>' +
+				'</a>'
 			);
 			var $container = context.$file.find('td:last');
 			$container.find('.delete').remove();

apps/files/js/filelist.js

@@ -710,6 +710,7 @@
 					'<input id="select-' + this.id + '-' + fileData.id +
 					'" type="checkbox" class="selectCheckBox"/><label for="select-' + this.id + '-' + fileData.id + '">' +
 					'<div class="thumbnail" style="background-image:url(' + icon + '); background-size: 32px;"></div>' +
+					'<span class="hidden-visually">' + t('files', 'Select') + '</span>' +
 					'</label>'
 				);
 			} else {

apps/files/templates/appnavigation.php

@@ -6,7 +6,9 @@
 	</ul>
 	<div id="app-settings">
 		<div id="app-settings-header">
-			<button class="settings-button" data-apps-slide-toggle="#app-settings-content"></button>
+			<button class="settings-button" data-apps-slide-toggle="#app-settings-content">
+				<span class="hidden-visually"><?php p($l->t('Settings'));?></span>
+			</button>
 		</div>
 		<div id="app-settings-content">
 				<h2><?php p($l->t('WebDAV'));?></h2>

apps/files/templates/list.php

@@ -39,7 +39,8 @@
 			<div id="uploadprogresswrapper">
 				<div id="uploadprogressbar"></div>
 				<input type="button" class="stop icon-close"
-					style="display:none" value="" />
+					style="display:none" value=""
+					alt="<?php p($l->t('Cancel upload'))?>" />
 			</div>
 		</div>
 		<div id="file_action_panel"></div>
@@ -61,7 +62,9 @@
 			<th id='headerName' class="hidden column-name">
 				<div id="headerName-container">
 					<input type="checkbox" id="select_all_files" class="select-all"/>
-					<label for="select_all_files"></label>
+					<label for="select_all_files">
+						<span class="hidden-visually"><?php p($l->t('Select all'))?></span>
+					</label>
 					<a class="name sort columntitle" data-sort="name"><span><?php p($l->t( 'Name' )); ?></span><span class="sort-indicator"></span></a>
 					<span id="selectedActionsList" class="selectedActions">
 						<a href="" class="download">

core/css/styles.css

@@ -725,7 +725,18 @@ label.infield {
 
 
 /* VARIOUS REUSABLE SELECTORS */
-.hidden { display:none; }
+.hidden {
+	display: none;
+}
+.hidden-visually {
+	position: absolute;
+	left:-10000px;
+	top: auto;
+	width: 1px;
+	height: 1px;
+	overflow: hidden;
+}
+
 .bold { font-weight:bold; }
 .center { text-align:center; }
 .inlineblock { display: inline-block; }

core/templates/layout.user.php

@@ -61,7 +61,8 @@
 					<?php if ($_['enableAvatars']): ?>
 					<div class="avatardiv<?php if ($_['userAvatarSet']) { print_unescaped(' avatardiv-shown"'); } else { print_unescaped('" style="display: none"'); } ?>>
 						<?php if ($_['userAvatarSet']): ?>
-							<img src="<?php p(link_to('', 'index.php').'/avatar/'.$_['user_uid'].'/32?requesttoken='.$_['requesttoken']); ?>">
+							<img src="<?php p(link_to('', 'index.php').'/avatar/'.$_['user_uid'].'/32?requesttoken='.$_['requesttoken']); ?>"
+								alt="" />
 						<?php endif; ?>
 					</div>
 					<?php endif; ?>
@@ -90,6 +91,9 @@
 			</div>
 
 			<form class="searchbox" action="#" method="post">
+				<label for="query" class="visually-hidden">
+					<?php p($l->t('Search'));?>
+				</label>
 				<input id="searchbox" class="svg" type="search" name="query"
 					value="<?php if(isset($_POST['query'])) {p($_POST['query']);};?>"
 					autocomplete="off" tabindex="2" />