From 8ba2cd4a077ac44963f58b76dc691ed92154a343 Mon Sep 17 00:00:00 2001
From: Maxence Lange <maxence@artificial-owl.com>
Date: Wed, 31 Jan 2024 22:03:27 -0100
Subject: [PATCH] returns non lazy value while searching for lazy

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
---
 lib/private/AppConfig.php | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/lib/private/AppConfig.php b/lib/private/AppConfig.php
index 07eebf1d047..60b0e77f7af 100644
--- a/lib/private/AppConfig.php
+++ b/lib/private/AppConfig.php
@@ -462,11 +462,14 @@ class AppConfig implements IAppConfig {
 			throw new AppConfigTypeConflictException('conflict with value type from database');
 		}
 
-		if ($lazy) {
-			return $this->lazyCache[$app][$key] ?? $default;
-		}
-
-		return $this->fastCache[$app][$key] ?? $default;
+		/**
+		 * - the pair $app/$key cannot exist in both array,
+		 * - we should still returns an existing non-lazy value even if current method
+		 *   is called with $lazy is true
+		 *
+		 * This way, lazyCache will be empty until the load for lazy config value is requested.
+		 */
+		return $this->lazyCache[$app][$key] ?? $this->fastCache[$app][$key] ?? $default;
 	}
 
 	/**