fix: Remove multiple require_once calls for template functions

Only require them when include the template file instead

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
pull/51385/head
Côme Chilliet 10 months ago committed by Côme Chilliet
parent a78d86e91d
commit a83cae1a0e
  1. 1
      lib/private/Template/Base.php
  2. 2
      lib/private/Template/Template.php
  3. 2
      lib/private/legacy/OC_Template.php
  4. 2
      tests/lib/TestCase.php

@ -136,6 +136,7 @@ class Base {
// Include
ob_start();
try {
require_once __DIR__ . '/../legacy/template/functions.php';
include $file;
$data = ob_get_contents();
} catch (\Exception $e) {

@ -21,8 +21,6 @@ use OCP\Template\ITemplate;
use OCP\Template\TemplateNotFoundException;
use OCP\Util;
require_once __DIR__ . '/../legacy/template/functions.php';
class Template extends Base implements ITemplate {
private string $path;
private array $headers = [];

@ -8,8 +8,6 @@
use OCP\Server;
use OCP\Template\ITemplateManager;
require_once __DIR__ . '/template/functions.php';
/**
* This class provides the templates for ownCloud.
* @deprecated 32.0.0 Use \OCP\Template\ITemplateManager instead

@ -549,8 +549,6 @@ abstract class TestCase extends \PHPUnit\Framework\TestCase {
* @param array $vars
*/
protected function assertTemplate($expectedHtml, $template, $vars = []) {
require_once __DIR__ . '/../../lib/private/legacy/template/functions.php';
$requestToken = 12345;
/** @var Defaults|\PHPUnit\Framework\MockObject\MockObject $l10n */
$theme = $this->getMockBuilder('\OCP\Defaults')

Loading…
Cancel
Save