Small cleanups in SetupCheck classes

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
pull/32550/head
Côme Chilliet 3 years ago
parent 1202171b32
commit b41b9cf4c0
No known key found for this signature in database
GPG Key ID: A3E2F658B28C760A
  1. 7
      apps/settings/lib/SetupChecks/CheckUserCertificates.php
  2. 13
      apps/settings/lib/SetupChecks/LegacySSEKeyFormat.php
  3. 13
      apps/user_ldap/lib/SetupChecks/LdapInvalidUuids.php

@ -32,11 +32,12 @@ use OCP\SetupCheck\ISetupCheck;
use OCP\SetupCheck\SetupResult;
class CheckUserCertificates implements ISetupCheck {
private IL10N $l10n;
private string $configValue;
public function __construct(IL10N $l10n, IConfig $config) {
$this->l10n = $l10n;
public function __construct(
private IL10N $l10n,
IConfig $config,
) {
$configValue = $config->getAppValue('files_external', 'user_certificate_scan', '');
$this->configValue = $configValue;
}

@ -32,14 +32,11 @@ use OCP\SetupCheck\ISetupCheck;
use OCP\SetupCheck\SetupResult;
class LegacySSEKeyFormat implements ISetupCheck {
private IL10N $l10n;
private IConfig $config;
private IURLGenerator $urlGenerator;
public function __construct(IL10N $l10n, IConfig $config, IURLGenerator $urlGenerator) {
$this->l10n = $l10n;
$this->config = $config;
$this->urlGenerator = $urlGenerator;
public function __construct(
private IL10N $l10n,
private IConfig $config,
private IURLGenerator $urlGenerator,
) {
}
public function getCategory(): string {

@ -34,14 +34,11 @@ use OCP\SetupCheck\ISetupCheck;
use OCP\SetupCheck\SetupResult;
class LdapInvalidUuids implements ISetupCheck {
private IL10N $l10n;
private UserMapping $userMapping;
private GroupMapping $groupMapping;
public function __construct(IL10N $l10n, UserMapping $userMapping, GroupMapping $groupMapping) {
$this->l10n = $l10n;
$this->userMapping = $userMapping;
$this->groupMapping = $groupMapping;
public function __construct(
private IL10N $l10n,
private UserMapping $userMapping,
private GroupMapping $groupMapping,
) {
}
public function getCategory(): string {

Loading…
Cancel
Save