From b44f35a42a801c1663154afe2a86a2378ed82a5f Mon Sep 17 00:00:00 2001 From: Thomas Citharel Date: Wed, 22 Oct 2025 15:30:48 +0200 Subject: [PATCH] refactor(trashbin): get expiration class directly from Server::get instead of going through Application container Signed-off-by: Thomas Citharel --- apps/files_trashbin/lib/Trashbin.php | 10 ++-------- build/psalm-baseline.xml | 2 -- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/apps/files_trashbin/lib/Trashbin.php b/apps/files_trashbin/lib/Trashbin.php index f67c0e3d108..15d5cd73a12 100644 --- a/apps/files_trashbin/lib/Trashbin.php +++ b/apps/files_trashbin/lib/Trashbin.php @@ -16,7 +16,6 @@ use OC\Files\Node\NonExistingFolder; use OC\Files\View; use OC\User\NoUserException; use OC_User; -use OCA\Files_Trashbin\AppInfo\Application; use OCA\Files_Trashbin\Command\Expire; use OCA\Files_Trashbin\Events\BeforeNodeRestoredEvent; use OCA\Files_Trashbin\Events\NodeRestoredEvent; @@ -857,9 +856,7 @@ class Trashbin implements IEventListener { */ private static function scheduleExpire($user) { // let the admin disable auto expire - /** @var Application $application */ - $application = Server::get(Application::class); - $expiration = $application->getContainer()->query('Expiration'); + $expiration = Server::get(Expiration::class); if ($expiration->isEnabled()) { Server::get(IBus::class)->push(new Expire($user)); } @@ -875,9 +872,7 @@ class Trashbin implements IEventListener { * @return int|float size of deleted files */ protected static function deleteFiles(array $files, string $user, int|float $availableSpace): int|float { - /** @var Application $application */ - $application = Server::get(Application::class); - $expiration = $application->getContainer()->query('Expiration'); + $expiration = Server::get(Expiration::class); $size = 0; if ($availableSpace <= 0) { @@ -909,7 +904,6 @@ class Trashbin implements IEventListener { * @return array{int|float, int} size of deleted files and number of deleted files */ public static function deleteExpiredFiles($files, $user) { - /** @var Expiration $expiration */ $expiration = Server::get(Expiration::class); $size = 0; $count = 0; diff --git a/build/psalm-baseline.xml b/build/psalm-baseline.xml index b198266da15..7e3f9ab604c 100644 --- a/build/psalm-baseline.xml +++ b/build/psalm-baseline.xml @@ -1907,8 +1907,6 @@ - -