Remove Redundantcasts

For #25839

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
pull/25929/head
Roeland Jago Douma 5 years ago
parent 3bbacb2f54
commit c3f1eb4f7f
  1. 4
      lib/private/DB/QueryBuilder/QueryBuilder.php
  2. 2
      lib/private/Files/Cache/Storage.php
  3. 2
      lib/public/DB/QueryBuilder/IQueryBuilder.php

@ -1234,11 +1234,11 @@ class QueryBuilder implements IQueryBuilder {
* @return int
* @throws \BadMethodCallException When being called before an insert query has been run.
*/
public function getLastInsertId() {
public function getLastInsertId(): int {
if ($this->getType() === \Doctrine\DBAL\Query\QueryBuilder::INSERT && $this->lastInsertedTable) {
// lastInsertId() needs the prefix but no quotes
$table = $this->prefixTableName($this->lastInsertedTable);
return (int) $this->connection->lastInsertId($table);
return $this->connection->lastInsertId($table);
}
throw new \BadMethodCallException('Invalid call to getLastInsertId without using insert() before.');

@ -77,7 +77,7 @@ class Storage {
$connection = \OC::$server->getDatabaseConnection();
$available = $isAvailable ? 1 : 0;
if ($connection->insertIfNotExist('*PREFIX*storages', ['id' => $this->storageId, 'available' => $available])) {
$this->numericId = (int)$connection->lastInsertId('*PREFIX*storages');
$this->numericId = $connection->lastInsertId('*PREFIX*storages');
} else {
if ($row = self::getStorageById($this->storageId)) {
$this->numericId = (int)$row['numeric_id'];

@ -967,7 +967,7 @@ interface IQueryBuilder {
* @throws \BadMethodCallException When being called before an insert query has been run.
* @since 9.0.0
*/
public function getLastInsertId();
public function getLastInsertId(): int;
/**
* Returns the table name quoted and with database prefix as needed by the implementation

Loading…
Cancel
Save