Merge pull request #15718 from owncloud/issue/15694-display-name-of-encryption-modules

Issue/15694 display name of encryption modules

apps/encryption_dummy/appinfo/app.php

@@ -2,5 +2,5 @@
 
 $manager = \OC::$server->getEncryptionManager();
 $module = new \OCA\Encryption_Dummy\DummyModule();
-$manager->registerEncryptionModule($module);
+$manager->registerEncryptionModule('OC_DUMMY_MODULE', 'Dummy Encryption Module', $module);
 

lib/private/encryption/manager.php

@@ -106,11 +106,11 @@ class Manager implements IManager {
 			$this->setDefaultEncryptionModule($id);
 		}
 
-		$this->encryptionModules[$id] = array(
+		$this->encryptionModules[$id] = [
 			'id' => $id,
-			'displayName' => 'displayName',
-			'callback' => $callback
-		);
+			'displayName' => $displayName,
+			'callback' => $callback,
+		];
 	}
 
 	/**

settings/admin.php

@@ -92,13 +92,13 @@ try {
 	$defaultEncryptionModule = \OC::$server->getEncryptionManager()->getDefaultEncryptionModule();
 	$defaultEncryptionModuleId = $defaultEncryptionModule->getId();
 } catch (Exception $e) {
-	$defaultEncryptionModule = null;
+	$defaultEncryptionModuleId = null;
 }
 $encModulues = array();
 foreach ($encryptionModules as $module) {
 	$encModulues[$module['id']]['displayName'] = $module['displayName'];
 	$encModulues[$module['id']]['default'] = false;
-	if ($defaultEncryptionModule && $module['id'] === $defaultEncryptionModuleId) {
+	if ($module['id'] === $defaultEncryptionModuleId) {
 		$encModulues[$module['id']]['default'] = true;
 	}
 }