handle error situation of rename proper

12 years ago · e55f25b64d
parent 5d671a84b2
commit e55f25b64d
1 changed files with 6 additions and 1 deletions
--- a/lib/connector/sabre/directory.php
+++ b/lib/connector/sabre/directory.php
@ -88,7 +88,12 @@ class OC_Connector_Sabre_Directory extends OC_Connector_Sabre_Node implements Sa
 			}

 			// rename to correct path
-			\OC\Files\Filesystem::rename($partpath, $newPath);
+			$renameOkay = \OC\Files\Filesystem::rename($partpath, $newPath);
+			if (!$renameOkay) {
+				\OC_Log::write('webdav', '\OC\Files\Filesystem::rename() failed', \OC_Log::ERROR);
+				\OC\Files\Filesystem::unlink($partpath);
+				throw new Sabre_DAV_Exception();
+			}

 			// allow sync clients to send the mtime along in a header
 			$mtime = OC_Request::hasModificationTime();