forward query exception when fallback construction fails

Signed-off-by: Robin Appelman <robin@icewind.nl>
pull/25535/head
Robin Appelman 5 years ago
parent 3401be216d
commit ec875227ec
No known key found for this signature in database
GPG Key ID: 42B69D8A64526EFB
  1. 2
      lib/private/AppFramework/Utility/SimpleContainer.php
  2. 6
      lib/private/Console/Application.php

@ -97,7 +97,7 @@ class SimpleContainer implements ArrayAccess, ContainerInterface, IContainer {
return $this->query($resolveName);
} catch (QueryException $e2) {
// don't lose the error we got while trying to query by type
throw new QueryException($e2->getMessage(), $e2->getCode(), $e);
throw new QueryException($e2->getMessage(), (int) $e2->getCode(), $e);
}
}

@ -221,7 +221,11 @@ class Application {
$c = \OC::$server->query($command);
} catch (QueryException $e) {
if (class_exists($command)) {
$c = new $command();
try {
$c = new $command();
} catch (\ArgumentCountError $e2) {
throw new \Exception("Failed to construct console command '$command': " . $e->getMessage(), 0, $e);
}
} else {
throw new \Exception("Console command '$command' is unknown and could not be loaded");
}

Loading…
Cancel
Save