Comment out LIMIT 0 case because of the mixed results

remotes/origin/handlebars-approach
Joas Schilling 10 years ago
parent c9564503c2
commit f9071ed5b7
  1. 4
      lib/private/db/querybuilder/querybuilder.php
  2. 3
      tests/lib/db/querybuilder/querybuildertest.php

@ -237,6 +237,10 @@ class QueryBuilder implements IQueryBuilder {
/**
* Sets the maximum number of results to retrieve (the "limit").
*
* NOTE: Setting max results to "0" will cause mixed behaviour. While most
* of the databases will just return an empty result set, Oracle will return
* all entries.
*
* @param integer $maxResults The maximum number of results to retrieve.
*
* @return \OCP\DB\QueryBuilder\IQueryBuilder This QueryBuilder instance.

@ -124,7 +124,8 @@ class QueryBuilderTest extends \Test\TestCase {
public function dataMaxResults() {
return [
[null, [99, 98, 97, 96, 95, 94, 93, 92, 91]],
[0, []],
// Limit 0 gives mixed results: either all entries or none is returned
//[0, []],
[1, [99]],
[5, [99, 98, 97, 96, 95]],
];

Loading…
Cancel
Save