From fa57f02a0ca1e7aa57aa33f603d2b3c01c993d38 Mon Sep 17 00:00:00 2001
From: Andy Scherzinger <info@andy-scherzinger.de>
Date: Tue, 7 Jul 2026 14:51:23 +0200
Subject: [PATCH] test(share): use mocks instead of an anonymous class for
 source stubs

Assisted-by: ClaudeCode:claude-fable-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
---
 .../RegisterShareReviewSourceEventTest.php    | 27 ++-----------------
 1 file changed, 2 insertions(+), 25 deletions(-)

diff --git a/tests/lib/Share20/ShareReview/RegisterShareReviewSourceEventTest.php b/tests/lib/Share20/ShareReview/RegisterShareReviewSourceEventTest.php
index a50f63cef28..80acbca3792 100644
--- a/tests/lib/Share20/ShareReview/RegisterShareReviewSourceEventTest.php
+++ b/tests/lib/Share20/ShareReview/RegisterShareReviewSourceEventTest.php
@@ -15,29 +15,6 @@ use PHPUnit\Framework\TestCase;
 
 final class RegisterShareReviewSourceEventTest extends TestCase {
 
-	/** @return class-string<IShareReviewSource> */
-	private function makeSourceClass(string $name): string {
-		$source = new class($name) implements IShareReviewSource {
-			public function __construct(
-				private readonly string $name = '',
-			) {
-			}
-
-			public function getName(): string {
-				return $this->name;
-			}
-
-			public function getShares(): array {
-				return [];
-			}
-
-			public function deleteShare(string $shareId): bool {
-				return false;
-			}
-		};
-		return $source::class;
-	}
-
 	public function testNoSourcesRegistered(): void {
 		$event = new RegisterShareReviewSourceEvent();
 
@@ -45,7 +22,7 @@ final class RegisterShareReviewSourceEventTest extends TestCase {
 	}
 
 	public function testRegisterSource(): void {
-		$sourceClass = $this->makeSourceClass('MyApp');
+		$sourceClass = $this->createMock(IShareReviewSource::class)::class;
 
 		$event = new RegisterShareReviewSourceEvent();
 		$event->registerSource($sourceClass);
@@ -54,7 +31,7 @@ final class RegisterShareReviewSourceEventTest extends TestCase {
 	}
 
 	public function testRegisterSourceKeepsDuplicates(): void {
-		$sourceClass = $this->makeSourceClass('MyApp');
+		$sourceClass = $this->createMock(IShareReviewSource::class)::class;
 
 		$event = new RegisterShareReviewSourceEvent();
 		$event->registerSource($sourceClass);