225 Commits (master)

Author	SHA1	Message	Date
Joas Schilling	39e94ef927	fix(oracle): Add a warning for Oracle 11 ... Signed-off-by: Joas Schilling <coding@schilljs.com>	1 month ago
Carl Schwan	4d47fdaa85	chore: Run rector with new rules for fetch ... Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	1 month ago
rakekniven	748a91ccab	chore(i18n): Improved grammar ... Reported at Transifex Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>	2 months ago
Benjamin Gaussorgues	1f74ed9239	feat(config): add serverid configuration and use it for Snowflakes ... Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 months ago
provokateurin	a529cdf080	feat: Update supportes PostgreSQL versions ... Signed-off-by: provokateurin <kate@provokateurin.de>	2 months ago
Benjamin Gaussorgues	c9b055a0d0	feat(database): introduce Snowflake IDs generator ... Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 months ago
Git'Fellow	3f976c2548	fix(setupCheck): Fix checking database type ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	3 months ago
Marcel Klehr	76eba41d77	fix: Fix logic error to make tests pass ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	3 months ago
Marcel Klehr	e7ac6ff71b	fix: Apply suggestion from @kyteinski ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	3 months ago
Marcel Klehr	5c5c9384b1	fix: Apply suggestion from @julien-nc ... Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>	3 months ago
Marcel Klehr	f7a89fee24	fix: Apply suggestion from @julien-nc ... Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>	3 months ago
Marcel Klehr	858118274d	fix: Apply suggestion from @julien-nc ... Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>	3 months ago
Marcel Klehr	2286b9f57d	fix: Apply suggestion from @julien-nc ... Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>	3 months ago
Marcel Klehr	1ba5f7d53a	fix(settings): Remove copypasta ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	3 months ago
Marcel Klehr	33922faf4a	fix: Change messages to use days instead of hours ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	3 months ago
Marcel Klehr	f296f9055c	fix: Run cs:fix ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	3 months ago
Marcel Klehr	6c9af3f8ee	fix(settings): Introduce TaskProcessingSuccessRate setup check ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	3 months ago
Marcel Klehr	5a48887a2b	fix(settings): Improve TaskProcessingPickupSpeed setup check ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	3 months ago
Carl Schwan	9095a36b94	refactor(dbal): Port away from getDatabasePlatform() instanceof pattern ... Use getDatabaseProvider instead. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Joas Schilling	122cd68d56	fix(PHP): Drop PHP 8.1 for Nextcloud 33 ... Signed-off-by: Joas Schilling <coding@schilljs.com>	3 months ago
Côme Chilliet	1c4276eea2	fix(setupchecks): Remove startpage from connectivity check and avoid redirection ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Côme Chilliet	cc3851f73c	fix(setupchecks): Use a lighter request to test connectivity ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Josh	34f1d52cf6	chore: Remove 'json' module from PHP modules check ... Removed 'json' module from the list of required PHP modules. It's built-in and not possible to disable at compile time since PHP 8.0.0. Refs: - https://www.php.net/manual/en/json.installation.php - https://wiki.php.net/rfc/always_enable_json - https://www.php.net/ChangeLog-8.php#8.0.0 Signed-off-by: Josh <josh.t.richards@gmail.com>	4 months ago
Enjeck C	eb0ddffaaa	fix: Make some strings in CodeIntegrity.php translatable ... Signed-off-by: Enjeck C <patrathewhiz@gmail.com>	4 months ago
Josh	6b65031a08	feat(settings): add support for MariaDB 11.8 in setup checks ... Signed-off-by: Josh <josh.t.richards@gmail.com>	6 months ago
Ferdinand Thiessen	5981b7eb51	chore: apply new CSFixer rules ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php	6 months ago
Ferdinand Thiessen	b1282f75fa	fix(settings): use correct scope for translations ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	6 months ago
MichaIng	0d10c4fb33	feat(settings): simplify OPcache checks ... For the overall OPcache size check, we currently compare used memory with free memory. However, `opcache.memory_consumption` is split into `used_memory`, `free_memory` and `wasted_memory`. When cached files change on disk, old entries are not replaced or removed, but remain as wasted memory, until the cache is actually full, and if their percentage is above `opcache.max_wasted_percentage`, which is 5% by default. When this happens, the engine is restarted, resetting the cache completely, like a `opcache_reset()` call. As long as we do not consider wasted cache, recommendations based on free memory can be false. To solve this, we could count wasted memory as free memory, if it is above `opcache.max_wasted_percentage`, as the engine will be restarted as soon as needed, freeing up this wasted space. On the other hand, wasted memory below the threshold permanently blocks the OPcache, which supports counting it as used memory. Depending on the situation, instead of raising OPcache size, it could be also advised to reduce `opcache.max_wasted_percentage`. But too frequent cache resets break its purpose as well. In my opinion, the matter is too complex to consider wasted cache correctly, and do precise recommendations, but we should focus on reducing false positives instead. What we know for sure is: if the cache is full (`$status['cache_full'] === true`), and the limit for cached keys has not been reached, the OPcache was too small to maintain free space, with wasted memory below the configured threshold, where it consumes memory permanently. Recommending to raise the OPcache size in this case, is hence as accurate as it gets. Even if 5% wasted cache could be freed, 95% used memory is still above the previous threshold for the setup check warning. And if `opcache.max_wasted_percentage` is above 5%, then the admin must have decided to change the default, deciding that system memory consumption has lower priority than preventing OPcache engine restarts. `cache_full` can be true as well if the limit for cached keys has been reached, hence we need to merge both checks. In this case `num_cached_keys` equals `max_cached_keys` exactly, hence it is easy to differentiale whether `opcache.max_accelerated_files` or `opcache.memory_consumption` needs to be raised to address the `cache_full` state. In practice, this change relaxes the checks: the respective limit needs to be reached 100% instead of 90%, to trigger a warning, eliminating also false alarms if a large share of the cache is consumed by wasted memory, which would be automatically freed once cache is 100% full. Additionally, the recommendation for raising `opcache.max_accelerated_files` now says "a value higher than `max_cached_keys`", instead of "higher than `opcache.max_accelerated_files`". The actual limit, reflected by `max_cached_keys` from `opcache_get_status()`, [is a next higher value from a set of prime numbers](https://www.php.net/manual/en/opcache.configuration.php#ini.opcache.max-accelerated-files). E.g. if `opcache.max_accelerated_files` is set to 10,000 (PHP default), the effective limit is 16,229 OPcache keys. Recommending "higher than 10000" could hence lead to a settings change without effect. For an effective change, the new value needs to be "higher than 16229" instead, which is what the setup check will show in this situation, with this change applied. Signed-off-by: MichaIng <micha@dietpi.com>	6 months ago
invario	2b58f74cc8	Fix: Remove X-XSS-Protection use, check and recommendation ... Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com> Signed-off-by: invario <67800603+invario@users.noreply.github.com>	7 months ago
rakekniven	4261c9d4fa	chore(18n): More natural english - fix plural typo ... Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>	7 months ago
Joas Schilling	e064af3149	fix(l10n): Fix one more plural ... Signed-off-by: Joas Schilling <coding@schilljs.com>	7 months ago
Marcel Klehr	1afc1805c4	fix: Correct translation method use ... Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>	7 months ago
rakekniven	8be6518e0c	fix(SetupChecks): Update TaskProcessingPickupSpeed ... Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>	7 months ago
rakekniven	cca0a757fe	chore(18n): More natural english ... Reported at Transifex. Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>	7 months ago
Marcel Klehr	f8f26952d1	feat(SetupChecks): Add check for TaskProcessing pickup speed ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	7 months ago
Ferdinand Thiessen	a243e9cfbb	fix(webauthn): do not require bcmath or gmp - not needed anymore ... The extensions are not required anymore but only recommended for performance. See also: https://github.com/web-auth/webauthn-framework/issues/213 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	10 months ago
Johan Bernhardsson	c39741fd65	fix: Change SQL query so that it is ansi safe ... Signed-off-by: Johan Bernhardsson <johan.bernhardsson@redpill-linpro.com>	10 months ago
Joas Schilling	095ab4419e	fix(l10n): Improve english source strings ... - No leading/trailing whitespace - Use asci single quote Signed-off-by: Joas Schilling <coding@schilljs.com>	10 months ago
Ferdinand Thiessen	f91db181af	feat(setupcheck): check logging level for validity ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	10 months ago
Joas Schilling	0a6eeb497b	fix(setupcheck): Update setup check for PHP version to be more accurate ... Signed-off-by: Joas Schilling <coding@schilljs.com>	11 months ago
Josh	8a7b1617d0	fix(settings): Add some context to the PHP memory limit error ... Signed-off-by: Josh <josh.t.richards@gmail.com>	11 months ago
Josh	b452dc0697	fix(SetupChecks): Pass webfinger if a handler is there ... Signed-off-by: Josh <josh.t.richards@gmail.com>	11 months ago
Côme Chilliet	b8de5e0d09	fix(settings): Fix setup check when mail_smptmode is set to "null" ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	11 months ago
Git'Fellow	cd147cd1a3	fix(setupchecks): Binary data can have problems with serialize ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	12 months ago
Josh	35cb5d84ca	perf(settings): Speed up InternetConnectivity setup check ... Specify default protocol (https://) rather than let default handling test both http:// and https:// Signed-off-by: Josh <josh.t.richards@gmail.com>	12 months ago
Joas Schilling	1bcc381e28	fix(setupcheck): Make the Memcache setupcheck use the cache ... Signed-off-by: Joas Schilling <coding@schilljs.com>	1 year ago
skjnldsv	52020b5ea6	fix(settings): psalm PhpMaxFileSize setup check warning ... Signed-off-by: skjnldsv <skjnldsv@protonmail.com>	1 year ago
skjnldsv	4a88848109	feat(settings): add big file upload setup checks ... Signed-off-by: skjnldsv <skjnldsv@protonmail.com>	1 year ago
Ferdinand Thiessen	a3e80e4195	feat: Update supported PostgreSQL versions ... 12 is now EOL but 17 was released and should be supported and tested. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
rakekniven	25d1628e30	chore(i18n): Fix grammar ... Reported at Transifex Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>	1 year ago