nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Ferdinand Thiessen	9b54b06de5	fix(SecurityMiddleware): return header to distinguish error type Currently we return a 403 (Forbidden) when the password confirmation failed - which itself seems to be inappropriate as its basically a login failing so a 401 (not authorized) is more appropriate. This is especially a problem because APIs might return 403 internally for good reason (e.g. user missing permission) but 401 would not be a problem. But as this is a breaking change so my solution to be able to distinguish API error from password confirmation error is: Add a header inside the response that marks failed password confirmation `X-NC-Auth-NotConfirmed`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 month ago
Côme Chilliet	447ee17759	fix: Remove code duplication by using the new method Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 month ago
provokateurin	f12cecb684	feat(rector): Enable SafeDeclareStrictTypesRector Signed-off-by: provokateurin <kate@provokateurin.de>	2 months ago
Carl Schwan	65e769a861	refactor: Apply comments Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	7b6078875b	refactor: Run rector on lib/private Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	f81475445d	refactor: Move hasAnnotationOrAttribute to MiddlewareUtils Signed-off-by: Carl Schwan <carlschwan@kde.org>	3 months ago
Carl Schwan	6408ed0b51	feat(AppFramework): Add missing NoSameSiteCookieRequired attribute Allow to replace the old annotation. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Christoph Wurst	8a581c230b	refactor: improve reflection attribute typing This allows tools to see the correct usage of PasswordConfirmationRequired::getStrict Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 months ago
Joas Schilling	2b9083ab29	feat(rate-limit): Allow overwriting the rate limit Signed-off-by: Joas Schilling <coding@schilljs.com>	5 months ago
Côme Chilliet	bbe766b07a	fix: Make sure Request class can be dependency injected to fix SameSiteCookieMiddleware injection Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	10 months ago
Ferdinand Thiessen	5981b7eb51	chore: apply new CSFixer rules Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php	10 months ago
Robin Appelman	8b0a3a774d	fix: throw a better error if we don't get an authorization header for secutity confirmation Signed-off-by: Robin Appelman <robin@icewind.nl>	10 months ago
Louis Chemineau	3bff9ee3e1	fix: Use login name to check the password Signed-off-by: Louis Chemineau <louis@chmn.me>	1 year ago
Joas Schilling	095ab4419e	fix(l10n): Improve english source strings - No leading/trailing whitespace - Use asci single quote Signed-off-by: Joas Schilling <coding@schilljs.com>	1 year ago
Joas Schilling	c1655bcde7	fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist Signed-off-by: Joas Schilling <coding@schilljs.com>	1 year ago
Louis Chemineau	a2f2f7ce93	feat: Use inline password confirmation in external storage settings Signed-off-by: Louis Chemineau <louis@chmn.me>	1 year ago
Arthur Schiwon	fdd24090ff	fix(Middleware): log deprecation when annotation was actually used Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	1 year ago
provokateurin	9836e9b164	chore(deps): Update nextcloud/coding-standard to v1.3.1 Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Ferdinand Thiessen	deeccd12a3	chore: fix typo in `SameSiteCookieMiddleware` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 years ago
Ferdinand Thiessen	92f3f7e2d2	chore: Remove unused `CsrfTokenManager` from `CSPMiddleware` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 years ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
Robin Appelman	8b60df1600	perf: delay getting (sub)admin status for user in the security middleware untill we need it Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Holger Hees	73397cd759	fix: Use `CSP_NONCE` env variable in ContentSecurity Header We should use 'cspNonceManager' for requesting the NONCE value, because it is doing the same as before, except that it honors a CPS_NONCE environment variable if available. Signed-off-by: Holger Hees <holger.hees@gmail.com>	2 years ago
Joas Schilling	047479ccf9	feat(security): Add public API to allow validating IP Ranges and checking for "in range" Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Benjamin Gaussorgues	202e5b1e95	feat(security): restrict admin actions to IP ranges Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Andrey Borysenko	40f820470a	chore: use "app_api" session key, "app_api_system" is deprecated Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>	2 years ago
Alexander Piskun	b7af6ec200	feat: allow for ExApps to call Admin endpoints marked with specific attr Signed-off-by: Alexander Piskun <bigcat88@icloud.com>	2 years ago
provokateurin	e5dcdfb9e0	feat(Security): Warn about using annotations instead of attributes Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
provokateurin	5aefdc399e	feat(AppFramework): Add ExAppRequired attribute Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Arthur Schiwon	f6d6efef3a	refactor(Token): introduce scope constants Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2 years ago
Arthur Schiwon	340939e688	fix(Session): avoid password confirmation on SSO SSO backends like SAML and OIDC tried a trick to suppress password confirmations as they are not possible by design. At least for SAML it was not reliable when existing user backends where used as user repositories. Now we are setting a special scope with the token, and also make sure that the scope is taken over when tokens are regenerated. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2 years ago
Andy Scherzinger	dae7c159f7	chore: Add SPDX header Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
Florian Klinger	f3a4abd98c	fix: add check for app_api_system session flag to bypass rate limit Signed-off-by: Florian Klinger <florian.klinger@nextcloud.com> Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>	2 years ago
Vincent Petry	839ddaa354	feat: rename users to account or person Replace translated text in most locations Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2 years ago
Joas Schilling	aa5f037af7	chore: apply changes from Nextcloud coding standards 1.1.1 Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Alexander Piskun	0b8a3b578d	fixed Drone test Signed-off-by: Alexander Piskun <bigcat88@icloud.com>	3 years ago
Alexander Piskun	f16c9f42c6	added CORS skip if session was created by AppAPI Signed-off-by: Alexander Piskun <bigcat88@icloud.com>	3 years ago
Christoph Wurst	e477bb7eaf	feat(appframework): Expose programmatic rate limiter Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	3 years ago
Joas Schilling	25309bcb45	techdebt(DI): Use public IThrottler interface which exists since Nextcloud 25 Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
Joas Schilling	381c35080d	fix(middleware): Fix header injection for bruteforce middleware Calling setHeaders(getHeaders()) breaks the CSP nonce for unknown reasons So shifting back to old standard practise for now Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
Joas Schilling	2f06f2355d	feat: Add a header which signals that the request was throttled Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
jld3103	12f8543815	Rewrite OCS CSRF check to be readable Signed-off-by: jld3103 <jld3103yt@gmail.com>	3 years ago
Joas Schilling	3a6bc7aba2	fix(middleware): Also abort the request when reaching max delay in afterController Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
Faraz Samapoor	e7cc7653b8	Refactors "strpos" calls in lib/private to improve code readability. Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>	3 years ago
Joas Schilling	ecb8b55c5c	feat(security): Add PHP \Attribute for remaining security annotations Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
Joas Schilling	89c3c31402	feat(ratelimit): Add Attributes support to rate limit middleware Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
Christoph Wurst	a06898a2d0	fix(security)!: Use consistent HTTP status for strict cookie checks Before: 503/412 Now: 412 + json body explaining the error Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	3 years ago
Joas Schilling	2b49861679	Add a debug message when throttling without defining Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
Joas Schilling	e839eb9b5c	feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
Ferdinand Thiessen	f655f83c84	fix(CORS): CORS should only be bypassed on `PublicPage` if not logged in to prevent CSRF attack vectors Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>	3 years ago

1 2 3

132 Commits (master)