108 Commits (master)

Author	SHA1	Message	Date
Git'Fellow	60d956f39f	refactor(storage): Code adjustements and simplifications ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	1 year ago
Git'Fellow	8755bf1815	fix(storage): Try to delete existing target ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Add same logic to common storage	1 year ago
provokateurin	0de4843b73	refactor(Storage): Align all Storage constructors ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
Daniel Calviño Sánchez	3017951d1d	fix: Fix copying or moving from shared groupfolders ... When copying or moving between two local storages the source path (on disk) to copy or move from is got from the unjailed path of the source storage. However, if the source storage has more than one jail getting the unjailed path resolves the most external jail, but the source path needs to be got from the most internal jail instead (the one closer to the local storage). This can happen, for example, with a shared groupfolder: in that case there is an external jail for the shared storage, and one internal jail for the groupfolder storage wrapped by the shared storage. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	1 year ago
provokateurin	f28e74b7a8	refactor(Storage): Make all parameter types strong types ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
provokateurin	7cdccd058f	fix(Storage): Fix IStorage return types ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
provokateurin	d2d1e3284d	fix(Storage): Fix method docs inheritance ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
John Molakvoæ	9acaf0788f	chore: improve hash_file php usage in Local Storage ... Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>	1 year ago
Louis Chemineau	6674f790a9	fix(files): Ensure that the hash method does not return null ... To match beececf660/lib/private/Files/View.php (L1050) - Fix https://github.com/nextcloud/server/issues/44110 Signed-off-by: Louis Chemineau <louis@chmn.me>	1 year ago
provokateurin	5bbe535c27	fix(Storage\Local): Do not call getSourcePath() on SplFileInfo ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
provokateurin	70fa51f042	fix(files): Never return a null ETag in DAV ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
Dennis Verspuij	181aecad4c	fix: Release directory iterator and thereby its potential directory lock prior to deleting a directory, to avoid e.g. "Text file busy" error with VirtualBox shared folder storage ... Signed-off-by: Dennis Verspuij <6680484+dennisverspuij@users.noreply.github.com>	1 year ago
Andy Scherzinger	dae7c159f7	chore: Add SPDX header ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
Côme Chilliet	672923f0a6	fix: Fix newly spotted psalm issues, add exhaustive typed magic properties for LDAP classes ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Joas Schilling	64d32abb48	fix(CI): Suppress psalm UndefinedClass ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2 years ago
Joas Schilling	050408c9de	fix(files): Also skip cross storage move with access control ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2 years ago
Côme Chilliet	ec5133b739	fix: Apply new coding standard to all files ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Benjamin Gaussorgues	5158bbf09b	fix: avoid scanning a non existing directory ... Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Robin Appelman	8418fcfedf	add some support for rename on case insensitive local filesystems ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Vincent Petry	8d1a3daa3f	Allow ext storage Local to go unavailable ... Whenever an external storage of type Local points at a non-existing directory, process this as a StorageNotAvailable instead of returning 404. This makes desktop clients ignore the folder instead of deleting it when it becomes unavailable. The code change was limited to external storages to avoid issues during setup and with the default home storage. Signed-off-by: Vincent Petry <pvince81@yahoo.fr>	2 years ago
Daniel Kesselberg	f1d4f7c7e4	fix: copy-and-delete fallback should use unlink ... because rmdir does not work for files. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
Daniel Kesselberg	b4ff557b8c	fix(storage): fallback to copy and unlink when rename fails ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
Hamid Dehnavi	d0b20534b9	Refactor "substr" calls to improve code readability ... Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>	3 years ago
Lorenzo Tanganelli	6b55e92e33	invert elseif on rmdir for local storage ... Signed-off-by: Lorenzo Tanganelli <lorenzo.tanganelli@hotmail.it>	3 years ago
Côme Chilliet	a90581b405	Get rid of more int casts in file size manipulations ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	426c0341ff	Use typed version of IConfig::getSystemValue as much as possible ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	4393b96542	Remove unused method getLocalFolder ... It’s not used and not in any OCP interface/class. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	8104d9f5d8	Remove useless coalescing operator on non-null return value ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	3f84d41226	Silence a warning from psalm with explanation ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Git'Fellow	28231ae515	Add function_exists() check ... Co-authored-by: Simon L. <szaimen@e.mail.de> Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	3 years ago
Git'Fellow	9ac065fb92	Fix free space problems ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	3 years ago
Côme Chilliet	308fcf4526	Respect OCP interface in private classes ... Because the parameter type was moved to phpdoc it needs to be removed from implementations Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	ff776a90b1	Strong type filesize related methods to ease 32bits problem findings ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	e156f8339c	Revert "remove 32-bit workarounds" ... This reverts commit dd8774389e. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Robin Appelman	33b90d28f8	fix moving files of encrypted local storage to unencrypted local storage ... for example when moving encrypted files to a groupfolder Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
szaimen	3f7c620f26	fix psalm ... Signed-off-by: szaimen <szaimen@e.mail.de>	3 years ago
szaimen	dd8774389e	remove 32-bit workarounds ... Signed-off-by: szaimen <szaimen@e.mail.de>	3 years ago
Carl Schwan	a5ea677370	Rename file1 and file2 to source and target in Storage abstraction ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Robin Appelman	cb51564356	trigger a rescan when trying to fopen a file that exists in cache but not on disk ... Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Tigran Mkrtchyan	f41209a061	config: add a switch to control truncate before update ... To avoid extra truncate on non WORM file systems, add a new config option `localstorage.unlink_on_truncate`, which defaults to false. The OC\Files\Storage\Local is update to respect that option. Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>	3 years ago
Tigran Mkrtchyan	8fc4cf67f1	files: remove destination file before copying new content (WORM) ... Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>	3 years ago
Tigran Mkrtchyan	b6065a236f	files: make OC\Files\Storage\Local WORM friendly ... Some filesystems run as a Write-Once-Read-Many storages. This makes them impossible to use with NexeCloud, as the file system layers uses `truncate` syscall (through file_put_contents function). As Nextcloud is never updates existing files, removing the old entry and creatint a new one on update will allow NextCoud to update on such file systems. Update Local#fopen and Local#file_put_contents to remote existing file before truncating. Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>	3 years ago
Martin Brugnara	7409569994	Expose umask override value as config parameter: localstorage.umask ... Commit 451c06d introduced override for umask value. This is needed to avoid broken env configuration or dirty workers to mess with the permissions when creating new files. Most Nextcloud, that does not integrate with external software would work fine with an hard-coded value (451c06d set it at 022). Advanced install may require more flexibility, as such this commit exposes the "umask override value" as configuration parameter: `localstorage.umask` It defaults to 0022 both in code and in config/config.sample.php . Signed-off-by: Martin Brugnara <martin@0x6d62.eu>	4 years ago
Côme Chilliet	23f7a37c03	Remove ILogger usages in lib/private/Files/Storage ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Robin Appelman	468d6a9cf1	ignore forbidden files while scanning local storage ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	84f464550a	some file scanner performance improvements ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
acsfer	152e2bfdaa	Check for `disk_free_space` ... Check for `disk_free_space` before calling it. Fix https://github.com/nextcloud/server/issues/29748	4 years ago
Carl Schwan	9408f8ae69	Fix security issues when copying groupfolder with advanced ACL ... Using advanced ACL, it is possible that an user has access to a directory but not to a subdirectory, so the copying use Common::copyFromStorage instead of Local::copyFromStorage. Fix https://github.com/nextcloud/groupfolders/issues/1692 Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
acsfer	98eac0fc05	Simplify :)	4 years ago
acsfer	8a8df49bc0	Replace `file_exists()` method by `is_file()`	4 years ago