97 Commits (master)

Author	SHA1	Message	Date
Carl Schwan	336cc3fa35	feat(Db): Use SnowflakeId for previews ... Allow to get an id for the storing the preview on disk before inserting the preview on the DB. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	2 months ago
Carl Schwan	cb82a9ef04	refactor(preview): Cleanup a bit the public interface ... * Remove old IProvider interface, it's been deprecated since 17.0.0 (8 years) * Add type hinting to the IPreview interface and mark it as consumeable only * Remove unused arguments from GeneratorHelper Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	bef3996c3e	fix(preview): Make version column a string ... And move it to a different table so that we don't have to pay the storage cost when not using it (most of the times). Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	66f50bd585	refactor(preview): Use same mimetype ids as filecache ... Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	58023782b6	feat(preview): Store original file mimetype in preview table ... Allow to quickly query all the files from a specific mimetype like in the ResetRenderedTexts command. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	324b54b863	refactor(preview): Cleanup the implementation of the new preview backend ... Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	6f56dcf73e	fix(preview): Fix some tests ... Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	b0357663b9	perf(preview): Optimize migration and simplify DB layout ... * Simplify migration by not moving the actual files and just updating the DB * Don't store the storageid in the preview table as it is not needed * Start adding tests Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	bba9667882	perf(preview): Adapt BackgroundCleanupJob to new previews table ... Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	6008852232	feat(preview): Support multibucket storage ... Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	13c35c0f17	perf(preview): Migrate previews to the new optimized table ... Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	656e33e8da	perf(preview): Add support for multibucket storage ... Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>	3 months ago
Carl Schwan	18fbacdd8d	perf(preview): Split preview data to new table ... The new oc_previews table is optimized for storing previews and should decrease significantly the space taken by previews in the filecache table. This attend to reuse the IObjectStore abstraction over S3/Swift/Azure but currently only support one single bucket configuration. Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>	3 months ago
AndyXheli	ecd1d5dde2	fix(previews): lower log level when cached preview isn't found ... Since this PR #52221 was implemented, the log file has been flooded with warnings stating, "Cached preview not found for file; generating a new preview." This appears to be more of an informational message rather than a warning. This PR will change it from warning to debug Original PR #52221 Signed-off-by: AndyXheli <andyxheli@gmail.com>	8 months ago
Louis Chemineau	867be352f3	fix(blurhash): Use preview API to generate the previews ... This allows to benefit from all the checks done by the preview API. This also use the newly introduced `cacheResult` argument to limit disk usage. Signed-off-by: Louis Chemineau <louis@chmn.me>	8 months ago
Louis Chemineau	2238548278	feat(previews): Support in memory preview request ... This allows callers to use the API without increasing the disk usage. Example: blurhash generation, where we request a preview for all uploaded pictures, but don't want to necessarily store that preview. Signed-off-by: Louis Chemineau <louis@chmn.me>	8 months ago
nfebe	d980e69f74	refactor: Thumbnail Generator logging and tests ... Signed-off-by: nfebe <fenn25.fn@gmail.com>	8 months ago
nfebe	6b89838cc2	feat: add logging to preview generation ... Signed-off-by: nfebe <fenn25.fn@gmail.com>	8 months ago
provokateurin	9836e9b164	chore(deps): Update nextcloud/coding-standard to v1.3.1 ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
Thomas Citharel	c2150bd079	feat: Add mimetype into BeforePreviewFetchedEvent event ... Signed-off-by: Thomas Citharel <tcit@tcit.fr>	1 year ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	1 year ago
Andy Scherzinger	dae7c159f7	chore: Add SPDX header ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
Côme Chilliet	ec5133b739	fix: Apply new coding standard to all files ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Git'Fellow	ef5f7d0a90	Us strpos() only ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	2 years ago
Git'Fellow	53b84732a3	Check for open_basedir before reading /proc ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	2 years ago
Simon L	b681cf735a	address review ... Signed-off-by: Simon L <szaimen@e.mail.de>	2 years ago
Simon L	531f5d1e4f	fix semaphore guarding ... Signed-off-by: Simon L <szaimen@e.mail.de>	2 years ago
Daniel Hansson	da2aad598e	also remove function ... Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>	2 years ago
Daniel Hansson	b2d105e7ec	Generate all preview sizes for Imaginary ... A follow up on https://github.com/nextcloud/server/pull/40670 Based on discussions here: https://github.com/nextcloud/server/issues/38911#issuecomment-1741819188 This fixes the case were not all previews are generated, for example in the activity view: https://github.com/nextcloud/server/issues/38911#issuecomment-1738886106 Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>	2 years ago
JanisPlayer	80abec668b	feat: Imaginary WebP support ... Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	2 years ago
Joas Schilling	4f7de8ed60	fix!: Remove legacy event dispatching Symfony's GenericEvent ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2 years ago
Daniel Kesselberg	440f882322	feat: add width, height, crop and mode to BeforePreviewFetchedEvent ... user_usage_report keeps a counter for files read. The app uses - OC_Filesystem::read hook - Event listener (the legacy one) for IPreview::EVENT Request for previews do not trigger the hook, hence the additional event listener. The thumbnails for a list or grid view should not count, so we need the width and height. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	3 years ago
Faraz Samapoor	e7cc7653b8	Refactors "strpos" calls in lib/private to improve code readability. ... Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>	3 years ago
Simon L	d55a7c619d	Fix typos in lib/public subdirectory ... Found via `codespell -q 3 -S l10n -L jus ./lib/public` Signed-off-by: luz paz <luzpaz@github.com> Update lib/public/Accounts/IAccount.php Signed-off-by: luz paz <luzpaz@github.com> Signed-off-by: Simon L <szaimen@e.mail.de> Co-Authored-By: Côme Chilliet <91878298+come-nc@users.noreply.github.com>	3 years ago
Glandos	e542e60dbc	try to make linters happy ... Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Glandos	3440387f0f	gather code from small and max preview ... use directory listing in both functions to gain 25% speed on run where every preview already exist. Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Glandos	24c121347a	Revert 0e49b40 ... Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Glandos	06a7e90383	improve parameter doc ... Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Glandos	4954bead1d	Ensure max preview image is not null ... Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Glandos	b6c65fee2a	php-cs-fix ... Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Glandos	9b4d5146d5	List preview directory only once ... getCachedPreview used to call `getFile`, and this calls `getDirectoryListing` (or underlying function that list directory) to find the file. This was done for every preview spec. Now, this is done only once at the beginning of the loop, and the array is just iterated when needed to find the correct entry. Signed-off-by: Glandos <bugs-github@antipoul.fr>	3 years ago
Thomas Citharel	e60888d988	fix(preview-generator): Throw exception before dividing by zero when generating previews ... If the maximum preview generated gives some kind of invalid IImage, it's dimentions and filename can be set to zero. And then later we do a division by zero to keep the aspect ratio of the previews. Signed-off-by: Thomas Citharel <tcit@tcit.fr>	3 years ago
Côme Chilliet	f5c361cf44	composer run cs:fix ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
szaimen	f9e9cd270d	Limit-number-of-concurrent-preview-generations ... Signed-off-by: Bowen Ding <dbw9580@live.com> Signed-off-by: szaimen <szaimen@e.mail.de>	3 years ago
Julius Härtl	07e94eca6f	Emit typed event when preview is requested ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	3 years ago
Christopher Ng	57c66bf7cb	Use Image class from public API ... Signed-off-by: Christopher Ng <chrng8@gmail.com>	4 years ago
Carl Schwan	a5a4e0df1c	Fix crop condition ... Make sure that when fetching the image from the cache we don't accidentally fetch the cropped image just because it also start with 256-256 Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Julius Härtl	3742b7392d	Add explicit return if getSmallImagePreview fails ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	4 years ago
Carl Schwan	05bf8b4445	Fix cropped image generated when not asked ... The $crop parameter was not propagated to the imaginary pipeline and instead it used the smartcrop algorithm always Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Richard Steinmetz	982c846b11	Fix preview generator trying to recreate an existing folder ... Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>	4 years ago