94 Commits (master)

Author	SHA1	Message	Date
Carl Schwan	4d47fdaa85	chore: Run rector with new rules for fetch ... Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	1 month ago
Ferdinand Thiessen	d6d6747a73	refactor: apply rector rules for PHPUnit 10 ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 months ago
Carl Schwan	9b2fff5931	refactor(querybuilder): Port away from qb::execute() in tests/ ... Replace by either executeStatement or executeQuery Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>	4 months ago
Carl Schwan	c4e6fbdae7	fix(query-builder): Don't catch UniqueConstraintViolationException ... UniqueConstraintViolationException is no longer throw directly but instead is now wrapped inside a \OCP\DB\Exception. So check the exception reason. Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>	4 months ago
Julien Veyssier	4a35837741	feat(auth): adjust PublicKeyTokenProviderTest ... Signed-off-by: Julien Veyssier <julien-nc@posteo.net>	4 months ago
Robin Appelman	aa15f9d16d	chore: run rector ... Signed-off-by: Robin Appelman <robin@icewind.nl>	6 months ago
Ferdinand Thiessen	5981b7eb51	chore: apply new CSFixer rules ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php	6 months ago
Robin Appelman	29e39c0a2e	chore: run rector on tests ... Signed-off-by: Robin Appelman <robin@icewind.nl>	7 months ago
Joas Schilling	5f9117b939	test: Fix coding standards ... Signed-off-by: Joas Schilling <coding@schilljs.com>	8 months ago
Joas Schilling	53b116b8a5	test: Remove more withConsecutive ... Signed-off-by: Joas Schilling <coding@schilljs.com>	8 months ago
provokateurin	9836e9b164	chore(deps): Update nextcloud/coding-standard to v1.3.1 ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
Christoph Wurst	49dd79eabb	refactor: Add void return type to PHPUnit test methods ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	1 year ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	1 year ago
Christoph Wurst	5100e3152d	feat(auth): Clean-up unused auth tokens and wipe tokens ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	1 year ago
Arthur Schiwon	f6d6efef3a	refactor(Token): introduce scope constants ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2 years ago
Andy Scherzinger	1f7e2ba599	chore: Add SPDX header ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
Andrew Summers	f9ce6bfdff	Refactor `OC\Server::getHasher` ... Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>	2 years ago
Benjamin Gaussorgues	d1189f923c	feat(perf): add cache for authtoken lookup ... Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Lucas Azevedo	771a7b92cc	Add tests for occ user:auth-tokens:delete ... Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>	2 years ago
Côme Chilliet	f57c12b14e	Fix various deprecation warnings in tests on PHP 8.3 ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Côme Chilliet	8d5165e8dc	Adapt tests to config value typing ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Artur Neumann	37cfccabc1	unit tests for Manager::invalidateTokensOfUser ... Signed-off-by: Artur Neumann <artur@jankaritech.com>	3 years ago
Joas Schilling	a81d8ecef5	Fix unit tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
Côme Chilliet	f5c361cf44	composer run cs:fix ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Marcel Klehr	adfe367106	PublickKeyTokenProvider: Fix password update routine with password hash ... Signed-off-by: Marcel Klehr <mklehr@gmx.net>	3 years ago
Christoph Wurst	9d0e79f10d	Fix PublicKeyTokenProviderTest import and mock ... * IDBConnection import missing * Atomic doesn't need a mock Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	3 years ago
Julius Härtl	2a684f6741	Fix some phpunit test warnings ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	3 years ago
Christoph Wurst	c5922e67d3	Run session token renewals in a database transaction ... The session token renewal does 1) Read the old token 2) Write a new token 3) Delete the old token If two processes succeed to read the old token there can be two new tokens because the queries were not run in a transaction. This is particularly problematic on clustered DBs where 1) would go to a read node and 2) and 3) go to a write node. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	3 years ago
Carl Schwan	702445ba3b	Handle one time password better ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Carl Schwan	1c23c029af	Handler large passwords ... For passwords bigger than 250 characters, use a bigger key since the performance impact is minor (around one second to encrypt the password). For passwords bigger than 470 characters, give up earlier and throw exeception recommanding admin to either enable the previously enabled configuration or use smaller passwords. Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	cdf3b60555	Handle one time passwords ... This adds an option to disable storing passwords in the database. This might be desirable when using single use token as passwords or very large passwords. Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Joas Schilling	7b3e2217de	Fix user agent trimming on installation ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Joas Schilling	d683e0d3d1	Automatically cut the token name on the first level ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Joas Schilling	343476f54f	Fix unit tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Carl Schwan	01e2a26749	Fix unit tests ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Joas Schilling	3e20cffc86	More test fixing ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Joas Schilling	c6ae53096c	More test fixing ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Joas Schilling	9f00179037	More unit test adjustments ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Christoph Wurst	7dd7256cfe	Prevent duplicate auth token activity updates ... The auth token activity logic works as follows * Read auth token * Compare last activity time stamp to current time * Update auth token activity if it's older than x seconds This works fine in isolation but with concurrency that means that occasionally the same token is read simultaneously by two processes and both of these processes will trigger an update of the same row. Affectively the second update doesn't add much value. It might set the time stamp to the exact same time stamp or one a few seconds later. But the last activity is no precise science, we don't need this accuracy. This patch changes the UPDATE query to include the expected value in a comparison with the current data. This results in an affected row when the data in the DB still has an old time stamp, but won't affect a row if the time stamp is (nearly) up to date. This is a micro optimization and will possibly not show any significant performance improvement. Yet in setups with a DB cluster it means that the write node has to send fewer changes to the read nodes due to the lower number of actual changes. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	4 years ago
Roeland Jago Douma	cd457cc68b	Always renew apppasswords on login ... Else you can end up that you renewed your password (LDAP for example). But they still don't work because you did not use them before you logged in. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Joas Schilling	49ff48fcd3	Use PSR logger in authentication ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Christoph Wurst	d9015a8c94	Format code to a single space around binary operators ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Roeland Jago Douma	76a7600e2e	Allow configuring the activity update interval of token ... On some systems with a lot of users this creates a lot of extra DB writes. Being able to increase this interval helps there. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Morris Jobke	234b510652	Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function ... To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	afbd9c4e6e	Unify function spacing to PSR2 recommendation ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2a529e453a	Use a blank line after the opening tag ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2ee65f177e	Use the shorter phpunit syntax for mocked return values ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	74936c49ea	Remove unused imports ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Joas Schilling	9935c71ec3	Check the user on remote wipe ... Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago