nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Carl Schwan	c8989d853c	refactor(IShare): Add typing for node This might also improve a bit the performance. Signed-off-by: Carl Schwan <carlschwan@kde.org>	1 month ago
Carl Schwan	11cf69d8ba	fix(psalm): Fix static analysis issues in apps/*/tests There are still 1200 more to fix before we can enable static analysis for the tests. Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Carl Schwan	3bdb344224	perf(external-sharing): Port to Entity and SnowflakeId This removes all the read after write and we don't need to queries all the time the same share in the same request anymore. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	cc7655136c	refactor(share): Remove code related to science mesh integration The app was not updated for the past 2 years. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	3 months ago
Carl Schwan	503a65ddd0	refactor: Run rector Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	4 months ago
Ferdinand Thiessen	d6d6747a73	refactor: apply rector rules for PHPUnit 10 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 months ago
nfebe	64016898d5	fix(sharing): Allow reasonable control 4 'Hide download' on fed shares When creating public links from federated shares, users should be able to set the 'Hide download' option independently as long as they are more restrictive than the original share permissions. Previously, the `checkInheritedAttributes` method was ignoring user preferences and always overriding the hideDownload setting based solely on inherited permissions, preventing users from disabling downloads even when the parent share allowed them. This fix implements some sort of inheritance logic: - Users can only be MORE restrictive than parent shares, never LESS restrictive - If parent hides downloads -> child MUST hide downloads (enforced) - If parent allows downloads -> child can CHOOSE to hide or allow downloads - If parent forbids downloads entirely -> child cannot enable downloads Signed-off-by: nfebe <fenn25.fn@gmail.com>	5 months ago
Carl Schwan	cb82a9ef04	refactor(preview): Cleanup a bit the public interface * Remove old IProvider interface, it's been deprecated since 17.0.0 (8 years) * Add type hinting to the IPreview interface and mark it as consumeable only * Remove unused arguments from GeneratorHelper Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	5 months ago
Daniel Kesselberg	83a691709c	refactor: use IEmailValidator.isValid instead of IMailer.validateEmailAddress Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	5 months ago
Côme Chilliet	f4993de065	fix(tests): Turn data providers into static methods in files_sharing tests Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	5 months ago
Louis Chemineau	6d672c4cba	fix(encryption): Correctly set encrypted to 0 when copying If encryption got disabled, copying should set encrypted to 0 for the new unencrypted copy. For instance when using encryption:decrypt-all Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: Louis Chemineau <louis@chmn.me>	6 months ago
Carl Schwan	5835599fa1	chore(rector): Apply current rector config Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>	7 months ago
nfebe	2bb8c72c47	feat(files_sharing): Toggle display for trusted server shares Signed-off-by: nfebe <fenn25.fn@gmail.com>	7 months ago
Ferdinand Thiessen	a18e61a1e5	feat(files_sharing): add config option for extending link-share permissions This allows the admin to control the behavior whether link shares with READ permissions should be extended to also gain SHARE permissions, allowing users (public share receivers) to add the share to their cloud. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	8 months ago
Robin Appelman	aa15f9d16d	chore: run rector Signed-off-by: Robin Appelman <robin@icewind.nl>	8 months ago
Ferdinand Thiessen	5981b7eb51	chore: apply new CSFixer rules Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php	8 months ago
skjnldsv	9806a9830c	feat(files_sharing): allow viewing files with download disabled Signed-off-by: skjnldsv <skjnldsv@protonmail.com>	9 months ago
skjnldsv	bf3ce79abd	feat(files_sharing): show Account menu on public pages Signed-off-by: skjnldsv <skjnldsv@protonmail.com>	9 months ago
Ferdinand Thiessen	495c364268	chore: use consistent casing for header names (required by openAPI) Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	9 months ago
Ferdinand Thiessen	9d8c2cd096	test(files_sharing): split `testCanAccessShare` into separate tests and fix for PHPUnit 10 - split the test into individual test cases - fix invalid call to `onConsecutiveCalls` (it was called more than defined values and is deprecated in v10 anyways). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	9 months ago
Ferdinand Thiessen	3a99b88917	test(files_sharing): adjust mocks of `Talk` classes Classes need to exist to be mocked (reflection), thus unknown classes only can be mocked as `stdClass`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	9 months ago
Ferdinand Thiessen	7115658327	test(files_sharing): adjust tests for PHPUnit v10 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	9 months ago
Ferdinand Thiessen	60ccc85e76	fix(files_sharing): show note, label and list of uploaded files on file drop This was missing from the Vue migration of the public share view: - Show the note as the description of the file drop - Show the label as the heading of the file drop if available - Show list of uploaded files for verification Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	10 months ago
Louis Chemineau	ec1db0c32a	fix: Replace the deprecated direct download link with the public DAV endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>	10 months ago
Ferdinand Thiessen	4a9dc6c64d	refactor: move tag handling from files handler to files_sharing Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	10 months ago
John Molakvoæ (skjnldsv)	cd6a53ea4d	fix(files_sharing): add mime fallback to public preview too Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	10 months ago
skjnldsv	bcc8de0c9d	fix(files_sharing): bring back owner and ownerDisplayName initial state Signed-off-by: skjnldsv <skjnldsv@protonmail.com>	10 months ago
Ferdinand Thiessen	00d08a4f69	fix(lookup-server): disable lookup server for non-global scale setups Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
Ferdinand Thiessen	34251c4375	fix(lookup-server): do not query data by default Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
Ferdinand Thiessen	c19ce403f3	fix(files_sharing): block downloading if needed Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
Côme Chilliet	64863c9d46	chore: Apply new rector configuration to apps folder Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
Côme Chilliet	ed5b7ae161	chore: re-apply current rector configuration to apps folder Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
Ferdinand Thiessen	73dc0f0f19	fix(sharing): Ensure download restrictions are not dropped When a user receives a share with share-permissions but also with download restrictions (hide download or the modern download permission attribute), then re-shares of that share must always also include those restrictions. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
Ferdinand Thiessen	253f4345f1	fix(files_sharing): Respect permissions passed when creating link shares Given: User creates a link or email share with permissions=4 (create only = file drop). Problem: Currently the permissions are automatically extended to permissions = 5 (READ + CREATE). Work around was to create the share and directly update it. Solution: Respect what the user is requesting, create a file drop share. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
Benjamin Gaussorgues	5581f0c7bf	chore: remove legacy action to test remote endpoint Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	1 year ago
provokateurin	beea8854ca	feat(files_sharing): Allow users with share permission to manage shares on IShareOwnerlessMount Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
skjnldsv	4d9d617c84	feat(files_sharing): use share node or label as page title Signed-off-by: skjnldsv <skjnldsv@protonmail.com>	1 year ago
Ferdinand Thiessen	c84c256261	fix: Adjust preview for view-only shares Previously there was a different behavior for public shares (link-shares) and internal shares, if the user disabled the view permission. The legacy UI for public shares simply "disabled" the context menu and hided all download actions. With Nextcloud 31 all share types use the consistent permissions attributes, which simplifies code, but caused a regression: Images can no longer been viewed. Because on 30 and before the attribute was not set, previews for view-only files were still allowed. Now with 31 we need a new way to allow "viewing" shares. So this is allowing previews for those files, but only for internal usage. This is done by settin a special header, which only works with custom requests, and not by opening the URL directly. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
provokateurin	aacb3ddc1e	fix(files_sharing): Cleanup error messages Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
provokateurin	381077028a	refactor(apps): Use constructor property promotion when possible Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
dependabot[bot]	bb598c8451	chore(deps): Bump nextcloud/coding-standard in /vendor-bin/cs-fixer Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/nextcloud/coding-standard/compare/v1.3.1...v1.3.2) --- updated-dependencies: - dependency-name: nextcloud/coding-standard dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
Côme Chilliet	1580c8612b	chore(apps): Apply new rector configuration to autouse classes Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
Côme Chilliet	1a4978c4ea	chore: Apply rector configuration to apps folder Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
provokateurin	9836e9b164	chore(deps): Update nextcloud/coding-standard to v1.3.1 Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
Robin Appelman	1ad58d68f3	test: fix ShareControllerTest.php Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Robin Appelman	7661a7e90a	test: fix ShareAPIControllerTest.php Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Côme Chilliet	801733e523	fix: Remove OCP\Files\Storage interface deprecated since version 9 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
Christoph Wurst	49dd79eabb	refactor: Add void return type to PHPUnit test methods Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2 years ago
skjnldsv	bb37954abb	fix(files_sharing): adjust permissions from custom edit and delete check methods Signed-off-by: skjnldsv <skjnldsv@protonmail.com>	2 years ago
Ferdinand Thiessen	96c8275586	feat(files_sharing): Migrate public share to use Vue files list Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 years ago

1 2 3 4 5

240 Commits (refactUserIdHandling)