221 Commits (stable21)

Author	SHA1	Message	Date
Joas Schilling	7b274fa48c	fix(comments): Check comment object ... Signed-off-by: Joas Schilling <coding@schilljs.com>	3 months ago
Joas Schilling	a741a58973	fix(apps): Fix loading info.xml file ... Ref: https://bugs.php.net/bug.php?id=62577 Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
Joas Schilling	96c8e0dad3	Apply changes from master's update to 3.1.3 ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
Joas Schilling	d6d4cbbf9f	Allow NULL as well for limit, not integer only ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
John Molakvoæ	5b89d34397	Revert "[21] tell mysql to ignore the sort index for search queries"	4 years ago
Robin Appelman	c3d9471fe0	disable path prefix index on postgresql for now ... having the index work properly for the queries we need it for requires some additional options which dbal does not support at the momement. to prevent making it harder to add the correct index later on we don't create the index for now on postgresql Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	7f272dd98f	allow specifying index hints for mysql search queries ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Joas Schilling	e3927afe19	Only mark migrations as installed after execution ... The problem is that if a developer creates a structural error in their migration file, they will already be marked as executed and an not be rerun. Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Roeland Jago Douma	e12e2ae8a3	Make psalm happy ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Daniel Kesselberg	549cefed15	Filter tables with other table prefix ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	5 years ago
Daniel Kesselberg	fe378200fa	Check for generic errors at last. ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	5 years ago
Christoph Wurst	2c9cdc1cdb	Add our own DB exception abstraction ... Right now our API exports the Doctrine/dbal exception. As we've seen with the dbal 3 upgrade, the leakage of 3rdparty types is problematic as a dependency update means lots of work in apps, due to the direct dependency of what Nextcloud ships. This breaks this dependency so that apps only need to depend on our public API. That API can then be vendor (db lib) agnostic and we can work around future deprecations/removals in dbal more easily. Right now the type of exception thrown is transported as "reason". For the more popular types of errors we can extend the new exception class and allow apps to catch specific errors only. Right now they have to catch-check-rethrow. This is not ideal, but better than the dependnecy on dbal. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Arthur Schiwon	f9484d15cb	DB: warn on parameter number constraints ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	5 years ago
Joas Schilling	3cdfe7b0f4	Don't try a transaction for the migrator on MySQL ... As per https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html CREATE TABLE statements automatically commit always. The only reason this worked in the past was that PHPs PDO connection didn't check the actual state on commit, but only checked their internal state. But in PHP8 this was fixed: https://github.com/php/php-src/blob/PHP-8.0/UPGRADING#L446-L450 So now commit() fails because the internal PDO connection implicitly commited already. Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Morris Jobke	dc00c8ac31	Remove "primary" option from schema builder argument $options as it is not used anymore and triggers an exception ... See 138eb85234 (diff-300f55366adb50a32a40882ebdc95c163b141f64cba5f45f20bda04a907b3eb3L82) Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Christoph Wurst	8b64e92b92	Bump doctrine/dbal from 2.12.0 to 3.0.0 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	9ce3ea3368	Update license headers ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	d89a75be0b	Update all license headers for Nextcloud 21 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Joas Schilling	5828f3c4f9	Prevent * and other things in the same query for Oracle ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Julius Härtl	36ffad5ba7	Make sure the migrations table schema is always checked ... Signed-off-by: Julius Härtl <jus@bitgrid.net> Revert "Make sure the migrations table schema is always checked" This reverts commit 258955ef738a52d9da2ac2fe59466e6093d7e9bc. Set current vendor during upgrade and perform migrations table change if needed Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Joas Schilling	c1f28f8d35	Make debugging migration exceptions easier ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Vincent Petry	a50bcdabcc	Prevent log_query to mess up regular execution flow ... When the "log_query" debug config parameter is set, SQL queries are logged. However, if an error occurs when converting the values to string, it will abort the request. This fix catches the error and continues instead. Also added handler for DateTime value which is already known to cause aborts here. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	5 years ago
Joas Schilling	a8cb8e21c1	Add types to function builder ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	9a3ce2f71f	Don't drop the table anymore when we create it again ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Robin Appelman	a61a757b85	allow selecting multiple columns with SELECT DISTINCT ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Joas Schilling	d7b5d4cb58	Revert "Revert "Installation goes brrrr""	5 years ago
Christoph Wurst	d36155620c	Revert "Installation goes brrrr"	5 years ago
Joas Schilling	77713ab454	Don't create a schema to check if the migrations table exists ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	dde0e73c6b	Reduce the number of schemas we generate when we just run all migrations anyway ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	d5df033ede	Create primary keys on all tables and add a command to create the afterwards ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	fbda2d1d25	Don't try to update on NotNullConstraintViolationException, only on unique or foreign key ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	1aa9c9164d	Fix comparing the empty string for global credentials ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	d9e471771a	Update parameters ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	cb8bef1f37	Fix iLike() falsely turning escaped % and _ into wildcards ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	3aaf2fabb1	Make sure Oracle always casts everything in the best way ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Joas Schilling	cfc35fa49a	Fix casting to integer on Oracle ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Julius Härtl	f49630f48c	Replace prefix in executeUpdate ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Roeland Jago Douma	fe46149560	Psalm fixes ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Roeland Jago Douma	28be188fbc	Update internal connection class ... executeUpdate is deprecated in favor of executeStatement. We overwrote the old one hence the prefix was no longer replaced. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Morris Jobke	f12e7e0e95	Fetch the logger and system config once for all query builder instances ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Christoph Wurst	d9015a8c94	Format code to a single space around binary operators ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Daniel Kesselberg	0e3ddf1b27	Add explicit typecast for $value. ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	6 years ago
Daniel Kesselberg	64b10f61df	Update signature for set ... also ILiteral and IQueryFunction are valid. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	6 years ago
Daniel Kesselberg	8fdb74bdd5	Update signature for in/notIn ... $y is always passed to quoteColumnName hence ILiteral|IParameter|IQueryFunction are supported. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	6 years ago
Daniel Kesselberg	d14c971ad6	Update signature for like/notLike/in/notIn ... $x is always passed to quoteColumnName hence ILiteral|IParameter|IQueryFunction are supported. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	6 years ago
Joas Schilling	3212c074b9	Log the number of queries built and executed ... Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
J0WI	68ce17e59b	Unify links to php.net ... Update all links to https://www.php.net/ Signed-off-by: J0WI <J0WI@users.noreply.github.com>	6 years ago
Morris Jobke	99c9423766	Remove @suppress SqlInjectionChecker ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Joas Schilling	50230847ce	Warn about adding NotNull columns with nullable default ... Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
Christoph Wurst	2a054e6c04	Update the license headers for Nextcloud 20 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago