nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Joas Schilling	2986019408	fix(files): Also skip cross storage move with access control Signed-off-by: Joas Schilling <coding@schilljs.com>	2 years ago
Côme Chilliet	88e1d6bbb7	Make sure that path is normalized and then checked, and not the other way around Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Robin Appelman	ce5f0cacd1	handle stream wrappers in SeekableHttpStream Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Carl Schwan	396157af18	Fix psalm issues Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	73e402f715	Add helper method in Wrapper Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
John Molakvoæ	6b94630f44	Implement multibucket shift for ObjectStore Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	4 years ago
Vincent Petry	79d26e4d7f	Fix fail when keys/files folder already exists Fixes an issue with transfer ownership in move mode where the folder "files_encryption/keys/files" already exists. Instead of failing, its existence is checked before calling mkdir. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Robin Appelman	f6024a895c	also use case sensitive like when searching in a folder this case was missed from https://github.com/nextcloud/server/pull/29080 Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Vincent Petry	65d4d30251	Check resource before closing in encryption wrapper In case of error there is no guarantee that $source or $target is set or is a resource when handling an error. Without this fix, there's a risk that fclose will fail and the actual exception will not be thrown, making it impossible to find out about the root cause. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Robin Appelman	bd677f6741	background scan the source storage when a background scan on a storage jail is triggered Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Carl Schwan	8f9d1b31df	Fix search results filtering Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Joas Schilling	f700abc889	Check for invalid characters before trimming Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
MichaIng	9db07032d5	Use pre-v22 query commands Signed-off-by: MichaIng <micha@dietpi.com>	4 years ago
Robin Appelman	a3dc399e2f	better cleanup of filecache when deleting an external storage this way it can delete the cache entries even with per-user credentials Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Vincent Petry	ca37664887	Normalize directory entries in Encoding wrapper Directory entry file names are now normalized in getMetaData(), getDirectoryContents() and opendir(). This makes the scanner work properly as it assumes pre-normalized names. In case the names were not normalized, the scanner will now skip the entries and display a warning when applicable. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	88b5860e70	Move storage encoding compatibility warning logic The encoding check for file names is now happening the Scanner, and an event will be emitted only if the storage doesn't contain the encoding compatibility wrapper. The event is listened to by the occ scan command to be able to display a warning in case of file name mismatches when they have NFD encoding. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	2e79444828	Normalize file name before existence check in scanner The scanner would not find a NFD-encoded file name in an existing file list that is normalized. This normalizes the file name before scanning. Fixes issues where scanning repeatedly would make NFD files flicker in and out of existence in the file cache. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
John Molakvoæ	5b89d34397	Revert "[21] tell mysql to ignore the sort index for search queries"	4 years ago
Sijmen Schoon	43e829a93e	Move query outside the loop and reduce chunk size to 1000 This involved changing CacheQueryBuilder\whereParentIn to take a parameter name, renaming the function accordingly. Signed-off-by: Sijmen Schoon <me@sijmenschoon.nl>	4 years ago
Sijmen Schoon	bb198c635f	Limit parameter count per query in Cache.removeChildren Signed-off-by: Sijmen Schoon <me@sijmenschoon.nl>	4 years ago
Carl Schwan	00a9b0c1db	Fix permissions when copying from ObjectStorage Make sure that when a user copy a file from a directory they don't have all permissions to a directory where they have more permissions, the permissions are correctly set to the one from the parent taget folder. This was caused by the ObjectStoreStorage::copyFromStorage using the jailed storage and cache entry instead of the unjailed one like other storages (the local one). Steps to reproduce + Use object storage + Create a groupfolder with one group having full permission and another one who can just read files. + With an user who is in the second group, copy a file from the groupfolder to the home folder of this user. + The file in the home folder of the user will be read only and can't be deleted even though it is in their home folder and they are the owner. In oc_filecache, the permissions stored for this file are 1 (READ) Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Robin Appelman	99ba96524e	more reliable return value for Watcher::checkUpdate Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	f18a76fec9	s3 external storage listing rework Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
acsfer	eea1c23719	Handle files with is_file instead of file_exists Should fix things like `fread(): read of 8192 bytes failed with errno=21 Is a directory`	4 years ago
Carl Schwan	ec8b2a90e6	Fix security issues when copying groupfolder with advanced ACL Using advanced ACL, it is possible that an user has access to a directory but not to a subdirectory, so the copying use Common::copyFromStorage instead of Local::copyFromStorage. Fix https://github.com/nextcloud/groupfolders/issues/1692 Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Robin Appelman	5002bf9cc1	tell mysql to ignore the sort index for search queries mysql really likes to pick an index for sorting if it can't fully satisfy the where filter with an index, since search queries pretty much never are fully filtered by index mysql often picks an index for sorting instead of the much more useful index for filtering. To bypass this, we tell mysql explicitly not to use the mtime (the default order field) index, so it will instead pick an index that is actually useful. Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	7f272dd98f	allow specifying index hints for mysql search queries Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
acsfer	f57bbaf146	Simplify :)	4 years ago
acsfer	aeb0ad8cea	Replace `file_exists()` method by `is_file()`	4 years ago
acsfer	0c1ccde7d2	Get `filesize()` if `file_exists()` Should make sense.	4 years ago
Robin Appelman	916a838873	[21] generate a better optimized query for path prefix search filters Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Julius Härtl	df3ed040e4	Make sure that a empty directory can still be deleted when copied from another storage Signed-off-by: Julius Härtl <jus@bitgrid.net>	4 years ago
Daniel Kesselberg	b77b1d6bbd	explicitly close source stream on encryption storage Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	4 years ago
Daniel Kesselberg	98d3836650	explicitly close source stream on local storage Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	4 years ago
Vincent Petry	9722bb5c54	Fix psalm issue in Encryption stream Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Robin Appelman	4180ca7a0b	handle case where storage can't be created in getStorageRootId Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Pauli Järvinen	61acaf1fbd	Support seeking also from the end of file on S3 storage The PR https://github.com/nextcloud/server/pull/20033 added support for `fseek` for the S3 storage backend. However, the seek mode SEEK_END was left out that time. This PR fills this gap. Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>	5 years ago
Daniel Kesselberg	dd9a08fa82	explicitly close source stream on object store upload even if countwrapper isn't needed Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	5 years ago
Jasper Knockaert	bb092dd7cc	fix even more brackets Signed-off-by: Jasper Knockaert jasper@knockaert.nl	5 years ago
Jasper Knockaert	c1dcd06fe1	fix brakcets	5 years ago
Jasper Knockaert	5f9663d2c8	consolidation of boolean expression	5 years ago
Jasper Knockaert	82482adb48	avoid fread on directories and unencrypted files Reworking the logic in order to first check the filecache and only then reading the fileheader. This in order to solve #21578.	5 years ago
Vincent Petry	2032ca7457	Unregister enc stream wrapper for any exception This prevents side effects in tests by properly cleaning up even with expected exceptions. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	5 years ago
Robin Appelman	ca3a6251d2	better cleanup of user files on user deletion Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	4c954e7dd1	fix Folder->getById() when a single storage is mounted multiple times Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	a9fbd0b41b	dont apply jail search filter is on the root Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
John Molakvoæ	218a96ebf9	Revert "[stable21] better cleanup of filecache when deleting an external storage"	5 years ago
Robin Appelman	feb640cd64	better cleanup of filecache when deleting an external storage this way it can delete the cache entries even with per-user credentials Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Julius Härtl	c16d5b1077	Reset checksum when writing files to object store Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Richard de Boer	9f3824b884	Check whether output buffering is active before turning it off Before we just turned it off and @suppressed the error if ob was not active. In PHP 8 this error is no longer suppressed, so try to not cause it at all. Signed-off-by: Richard de Boer <git@tubul.net>	5 years ago

1 2 3 4 5 ...

897 Commits (stable21)