nextcloud-server

Commit Graph

Author	SHA1	Message	Date
David Dreschner	acf233c33a	fix(Database): Use real idle-timer to prevent `lastInsertId` being reset on MariaDB/MySQL The previous implementation of the idle timer runs on a strict 30 second interval and sends a dummy `SELECT` statement to keep the connection open. This generates issues with the `lastInsertId` on long-running tasks (like our CI pipeline), as the MariaDB documentation clearly states: > If the last query wasn't an INSERT or UPDATE statement or if the modified table does not have a column with the AUTO_INCREMENT attribute and LAST_INSERT_ID was not used, this function will return zero. Source: https://mariadb.com/docs/connectors/mariadb-connector-c/api-functions/mysql_insert_id To mitigate that, this commit now uses a real idle-timer per connection instead. Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>	3 weeks ago
Kostiantyn Miakshyn	ae3434579b	feat: Add support for `NOT ILIKE` in query builder expressions Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>	2 months ago
Côme Chilliet	a51886569e	chore: Pass correct type for alias in QueryBuilderTest Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 months ago
provokateurin	405d250aef	test: Add missing calls to the parent setUp method Signed-off-by: provokateurin <kate@provokateurin.de>	2 months ago
Côme Chilliet	1ab09ec753	chore: Apply new coding standard to all files The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines To see only the changes not related to blank lines. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Anna Larch	18c5c0711e	test: remove no-op checkbox assertions Replace assertTrue(true), addToAssertionCount(1) and delete-without-assert patterns with meaningful assertions or proper test removal. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	3 months ago
Anna Larch	a9f177e743	test(db): call parent::tearDown() in DB test classes that skipped it Eight test classes overrode tearDown() for custom DB cleanup but never called parent::tearDown(). TestCase::tearDown() does three things these tests were silently skipping after every test method: - ILockingProvider::releaseAll() — unreleased locks bleed into subsequent tests and can cause deadlocks or unexpected NotFoundException - Storage::getGlobalCache()->clearCache() — stale filecache entries from share/storage tests cause unrelated ObjectStore tests to receive false from fopen() (fseek() then fails with "Argument must be of type resource") - UserMountCache::flush() — stale mount cache causes share lookups in later tests to fail with ShareNotFound AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>	3 months ago
Ferdinand Thiessen	e5b1799079	chore: add missing `Override` attribute to test files Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 months ago
Ferdinand Thiessen	691aedd13e	fix(db): set session timezone to UTC Some (well all except sqlite) database platforms support timezone configuration. The problem is that we expect everything in UTC, but some servers might have set some different default (e.g. in database configuration or even just because of `TZ` environment variable). This causes incorrect values when expecting `NOW()` to return the current time in UTC. For PHP we already enforce UTC as timezone, this PR adds a middleware that enforces UTC also as the database connection / session timezone. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	5 months ago
nextcloud-command	663018455e	refactor: Apply rector changes Signed-off-by: GitHub <noreply@github.com>	6 months ago
Carl Schwan	fa75c1b659	fix(ExpressionBuilderTest): Fix test and improve typing Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	7 months ago
Carl Schwan	7b6078875b	refactor: Run rector on lib/private Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	7 months ago
Carl Schwan	5d0d0c17e5	chore(rector): Run rector on apps, core and tests directory Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	7 months ago
Ferdinand Thiessen	67eef32b07	fix(DB): support up to 63 character long table and index names We do not support Oracle 11 anymore but at least Oracle 12c (12.2). So the limitation is gone (Oracle now supports up to 128 character long names). Instead we are now limited by MySQL (64 characters) and PostgreSQL (63 characters). Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	7 months ago
provokateurin	341fd348e6	fix(UserMountCache): Add back unique index for oc_mounts and use normal insert Signed-off-by: provokateurin <kate@provokateurin.de>	8 months ago
Joas Schilling	7a4167fe28	fix(oracle): Don't run tests against unsupported Oracle version anymore Signed-off-by: Joas Schilling <coding@schilljs.com>	9 months ago
Carl Schwan	2b61abd9ad	refactor(db-adapter): Add tests about fetch methods Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	9 months ago
Carl Schwan	4d47fdaa85	chore: Run rector with new rules for fetch Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	9 months ago
Joas Schilling	75a8b9aff5	fix(db): Skip test on Oracle 11g Signed-off-by: Joas Schilling <coding@schilljs.com>	9 months ago
Joas Schilling	4676b12a32	fix(db): Fix comparing JSON data in MySQL and MariaDB Signed-off-by: Joas Schilling <coding@schilljs.com>	9 months ago
Joas Schilling	fb8caecbb0	fix(db): Fix JSON handling in WHERE statements for postgres Signed-off-by: Joas Schilling <coding@schilljs.com>	9 months ago
Ferdinand Thiessen	1eeed0a170	refactor(tests): teardown is now always called - also when skipped * ref: https://github.com/sebastianbergmann/phpunit/issues/6394 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	10 months ago
Ferdinand Thiessen	d6d6747a73	refactor: apply rector rules for PHPUnit 10 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	10 months ago
Carl Schwan	9095a36b94	refactor(dbal): Port away from getDatabasePlatform() instanceof pattern Use getDatabaseProvider instead. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	10 months ago
provokateurin	6a12fbc4f3	refactor: Run rector Signed-off-by: provokateurin <kate@provokateurin.de>	11 months ago
Côme Chilliet	3e4531dd05	fix: Fix methods returning null for arrays in schema Mock Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	11 months ago
Côme Chilliet	ac61839d1e	fix(tests): Fix PHPUnit deprecation warnings in tests Turn data providers into static methods, mostly. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	11 months ago
Benjamin Gaussorgues	5883914422	feat(db): add SSL/TLS support for PostgreSQL Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	11 months ago
Carl Schwan	837fe3586d	feat(db): Restaure support for non-nullable boolean column We disabled them because they are not supported on Oracle DB and it is still the case for OCI < 23. But instead of disabling the support completely for every database types, mark non-nullable boolean column as actually nullable when using Oracle. This allow to use some slighly lighter schema on normal databases who support natively booleans wheen we don't need to store 3 states true\|false\|null. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	9b2fff5931	refactor(querybuilder): Port away from qb::execute() in tests/ Replace by either executeStatement or executeQuery Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>	12 months ago
Côme Chilliet	b7c15949ce	chore: Get rid of AppLocator helper Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
Robin Appelman	222cbd0af6	fix: fix oci string length with empty strings Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Robin Appelman	aa15f9d16d	chore: run rector Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Ferdinand Thiessen	5981b7eb51	chore: apply new CSFixer rules Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php	1 year ago
Maxence Lange	e39ab65239	feat(lexicon): migrate config key/value Signed-off-by: Maxence Lange <maxence@artificial-owl.com>	1 year ago
Robin Appelman	29e39c0a2e	chore: run rector on tests Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Joas Schilling	437f380fd9	test: Fix most tests/lib/DB/QueryBuilder Signed-off-by: Joas Schilling <coding@schilljs.com>	1 year ago
Joas Schilling	3e7db013c1	test: Fix non-static data providers Signed-off-by: Joas Schilling <coding@schilljs.com>	1 year ago
Joas Schilling	b77011a918	test: Prepare more tests for PHPUnit 10 Signed-off-by: Joas Schilling <coding@schilljs.com>	1 year ago
Robin Appelman	0a77ba99a2	feat: support migrating an instance to sharding Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Ferdinand Thiessen	db94e10af0	fix: Prevent breaking change in IQueryBuilder Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 years ago
Ferdinand Thiessen	ee02e3246d	feat(AppFramework): Add full support for date / time / datetime columns This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added. But especially those types are the important ones, as our Entity class works by detecting changes through setters. Meaning if it is mutable, changes like `$entity->date->modfiy()` can not be detected, so the immutable types make more sense here. Similar the parameter types needed to be added. `Enity` and `QBMapper` needed to be adjusted so they support (auto map) those types, required when insert or update an entity. Also added more tests, especially to make sure the mapper really serializes the values correctly. Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 years ago
Christoph Wurst	49dd79eabb	refactor: Add void return type to PHPUnit test methods Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2 years ago
Robin Appelman	da59fd4389	fix: misc code fixes around db sharding Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Arthur Schiwon	b71c539b5c	test(phpunit): skip sharding tests on 32bit Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2 years ago
Louis Chemineau	2574cbfa61	chore: Apply php:cs recommendations Signed-off-by: Louis Chemineau <louis@chmn.me>	2 years ago
Robin Appelman	62f8b6517f	feat: implement distributing partitioned queries over multiple shards Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	f5b3486744	feat: add option to automatically partition queries by specific tables Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
Maxence Lange	ad490c963b	feat(migration-attributes): tests Signed-off-by: Maxence Lange <maxence@artificial-owl.com>	2 years ago

1 2 3 4

184 Commits (04aa4e851efec1cf3452dfa122cee040f881aa7d)