nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Stephen Cuppett	d5f25609aa	test(encryption): strengthen testCalculateFolderSizeWithEncryptedZeroByte Add a second encrypted child with unencrypted_size=100 so the write-back gate in calculateFolderSizeInner ($unencryptedMax > 0) actually opens. The original single zero-byte child left the gate closed, meaning the test passed against the DB default rather than the computed value. With two children the assertion distinguishes the fixed code (result: 100) from the old buggy code (result: 8292, falling back to on-disk size for the zero-byte child). Assisted-by: ClaudeCode:claude-opus-4-6 Signed-off-by: Stephen Cuppett <scuppett@redhat.com>	4 weeks ago
Stephen Cuppett	b6fddabf6c	fix(encryption): Address review feedback and fix zero-byte size consistency Apply come-nc's reviewer suggestions on Scanner.php: - Simplify cached unencrypted_size skip condition to explicit == 0 check - Remove redundant !isset guard on new-file path Fix remaining > 0 / !== 0 guards that treated zero as "no unencrypted_size": - FileInfo constructor: use encrypted flag for rawSize (getSize(false) path) - FileInfo::addSubEntry: use encrypted flag for sub-mount accumulation - Cache::calculateFolderSizeInner: use encrypted column instead of > 0 Add tests covering zero-byte encrypted file scenarios: - FileInfoTest: getSize(true/false) for zero-byte encrypted files - CacheTest: getUnencryptedSize and calculateFolderSize with encrypted=1,size=0 - EncryptionTest: verifyUnencryptedSize data provider cases for header-only files Assisted-by: ClaudeCode:claude-opus-4-6 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <scuppett@redhat.com>	4 weeks ago
Josh	db628034bd	chore(view): update ViewTest for php-cs/rector Signed-off-by: Josh <josh.t.richards@gmail.com>	1 month ago
Josh	508995511c	test(files): make watcher propagation regression test deterministic - The existing watcher regression test could pass if the cached mtime and request timestamp land in the same second. - The test now uses a fixed root mtime and etag before accessing the folder. - Checking the etag as well is valid, because an unwanted propagation can invalidate ancestor etags. Assisted-by: GitHubCopilot:GPT-5 Signed-off-by: Josh <josh.t.richards@gmail.com>	1 month ago
Kent Delante	4019df6891	test: add tests for encryptedVersion cache entry preservation Signed-off-by: Kent Delante <kent@delante.me> Assisted-by: ClaudeCode:claude-sonnet-5	1 month ago
Maksim Sukharev	715378f38f	fix(View#getCacheEntry): skip propagation when storage metadata is unchanged Storage backends like AmazonS3 whose hasUpdated() always returns true (S3 has no cheap global change-detection mechanism) caused propagateChange() to be called on every watcher->update() after a folder was browsed, even when the underlying storage_mtime and etag were identical to the cached values. Before the fix, getCacheEntry() would call watcher->update() and then unconditionally call propagateChange() whenever the watcher reported a change. For S3 directories this meant every read bumped the parent mtime chain. After the fix, getCacheEntry() snapshots the cache entry before watcher->update() and compares it with the entry after. propagateChange() is only invoked when at least one metadata field (mtime, storage_mtime, size, or etag) actually changed. Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>	1 month ago
Git'Fellow	586e8a0c41	fix(files): do not let a failing move hook break the move or hide files Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	1 month ago
Joas Schilling	8659690509	test: Don't fail due to deprecations from guzzlehttp 7.12 Signed-off-by: Joas Schilling <coding@schilljs.com>	2 months ago
Carl Schwan	da0928827a	refactor: Expose a public exception when no user is found And use this new exception everywhere outside of where the old one was throw. Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Carl Schwan	b6a23f0268	refactor: Call IStorageFactory::addStorageFactory directly Remove call to deprecated Filesystem api and allow to reuse instead of the mounts points between addStorageFactory. Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Carl Schwan	e6b5f763a4	perf: Avoid sorting an already sorted array Improve performance a bit as this is in the hotpath and take ~2s in prod. Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Enrique Pérez Arnaud	3616212ba2	feat(files_sharing): store and refresh OCM access tokens for external shares Co-authored-by: Micke Nordin <kano@sunet.se> Signed-off-by: Micke Nordin <kano@sunet.se> Signed-off-by: Enrique Pérez Arnaud <enrique@cazalla.net>	2 months ago
Josh	384e21b824	test(s3): drop unnecessarily added fclose Signed-off-by: Josh <josh.t.richards@gmail.com>	2 months ago
Josh	ba4924b331	test(s3): make testFileSizes EOF assertion more robust Signed-off-by: Josh <josh.t.richards@gmail.com>	2 months ago
provokateurin	3ee06f338c	ci(PHP): Only test against highest and lowest supported PHP versions Signed-off-by: provokateurin <kate@provokateurin.de>	2 months ago
Benjamin Gaussorgues	73506e8486	chore(deprecated): remove Reflection*::setAccessible as it's noop since PHP 8.1 Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1 Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 months ago
provokateurin	405d250aef	test: Add missing calls to the parent setUp method Signed-off-by: provokateurin <kate@provokateurin.de>	2 months ago
Louis Chmn	6bb9ad60f2	test(View): Setup users and groups once Signed-off-by: Louis Chmn <louis@chmn.me>	2 months ago
Josh	c7fabc4654	test(cache): avoid ordering assumptions in testExtended Signed-off-by: Josh <josh.t.richards@gmail.com>	3 months ago
Côme Chilliet	1ab09ec753	chore: Apply new coding standard to all files The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines To see only the changes not related to blank lines. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Anna Larch	18c5c0711e	test: remove no-op checkbox assertions Replace assertTrue(true), addToAssertionCount(1) and delete-without-assert patterns with meaningful assertions or proper test removal. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	3 months ago
Anna Larch	a9f177e743	test(db): call parent::tearDown() in DB test classes that skipped it Eight test classes overrode tearDown() for custom DB cleanup but never called parent::tearDown(). TestCase::tearDown() does three things these tests were silently skipping after every test method: - ILockingProvider::releaseAll() — unreleased locks bleed into subsequent tests and can cause deadlocks or unexpected NotFoundException - Storage::getGlobalCache()->clearCache() — stale filecache entries from share/storage tests cause unrelated ObjectStore tests to receive false from fopen() (fseek() then fails with "Argument must be of type resource") - UserMountCache::flush() — stale mount cache causes share lookups in later tests to fail with ShareNotFound AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>	3 months ago
nextcloud-command	fd14234a6a	refactor: Apply rector changes Signed-off-by: GitHub <noreply@github.com>	3 months ago
Robin Appelman	c91f8b0e2c	test: adjust tests to unsorted folder listing Signed-off-by: Robin Appelman <robin@icewind.nl>	3 months ago
John Molakvoæ (skjnldsv)	c26b1e4b07	fix(s3): add Content-MD5 header for DeleteObjects to fix AWS SDK v3.339.0+ compatibility AWS SDK PHP v3.339.0+ introduced a breaking change requiring the Content-MD5 header for DeleteObjects operations. This causes 'MissingContentMD5' errors when using S3-compatible services like MinIO. Add middleware to automatically calculate and inject the Content-MD5 header on all DeleteObjects requests. This is applied universally at the S3ConnectionTrait level, fixing both external storage (AmazonS3) and core ObjectStore (S3) classes. Fixes: https://github.com/aws/aws-sdk-php/issues/3068 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	3 months ago
Robin Appelman	9f5535d01b	fix: apply quota with writeStream Signed-off-by: Robin Appelman <robin@icewind.nl>	4 months ago
Robin Appelman	f3a5bc8c17	fix: block writing empty files with 0 quota Signed-off-by: Robin Appelman <robin@icewind.nl>	4 months ago
Ferdinand Thiessen	e5b1799079	chore: add missing `Override` attribute to test files Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 months ago
Carl Schwan	bb4c55c125	refactor: Move copy skeleton step to a file listener Instead of having all user providers call OC_Util::copySkeleton Signed-off-by: Carl Schwan <carlschwan@kde.org>	4 months ago
Robin Appelman	cf06ebf999	test: more tests for UserMountCache Signed-off-by: Robin Appelman <robin@icewind.nl>	4 months ago
Carl Schwan	fbf84e6473	chore: Replace MoveableMount usage with IMovableMount The former is private API while the IMovableMount is public. Signed-off-by: Carl Schwan <carlschwan@kde.org>	4 months ago
Kostiantyn Miakshyn	fcb10219d1	fix: Allow `num_buckets` to be equal as `min_bucket` Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>	4 months ago
Stephen Cuppett	cdaeed02b6	feat(objectstore): Add AWS SSE-KMS encryption support for S3 storage Add support for Server-Side Encryption with AWS Key Management Service (SSE-KMS) for S3 object storage. This allows Nextcloud to encrypt data at rest in S3 using AWS-managed keys. Key features: - New config options: sse_kms_enabled and sse_kms_key_id - Backward compatible with existing SSE-C (customer-provided keys) - SSE-C takes precedence when both SSE-C and SSE-KMS are configured Implementation details: - Added getServerSideEncryptionParameters() method to centralize encryption parameter logic for both SSE-C and SSE-KMS - Updated multipart uploads to use unified encryption parameters - Added comprehensive PHPUnit tests for SSE-KMS scenarios - Tested with AWS bucket and KMS keys in us-east-1 region Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <steve@cuppett.com>	4 months ago
Louis Chmn	72812b2b07	chore(Scanner): Use modern syntax and APIs Signed-off-by: Louis Chmn <louis@chmn.me>	4 months ago
Josh	8895970019	test(ViewTest): disable Nextcloud not PHP - drop testTouchFloat() Our interface contract (and implementations) in IStorage are: `public function touch(string $path, ?int $mtime = null): bool {` This wasn't always the case but it is today, so testTouchFloat() no longer makes sense; it's not testing our code, just PHP. Signed-off-by: Josh <josh.t.richards@gmail.com>	5 months ago
Robin Appelman	cf124e7c75	fix: make objectstore copy consistent with changed local storage behavior Signed-off-by: Robin Appelman <robin@icewind.nl>	5 months ago
Côme Chilliet	397454ff4a	fix: Adapt ViewTest to ['path'] being absolute Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	5 months ago
Carl Schwan	7fa44717e0	refactor(share): Remove some deprecated method usages Signed-off-by: Carl Schwan <carlschwan@kde.org>	5 months ago
Carl Schwan	af94028bdb	refactor: Remove old Share backend This has been implicitely deprecated for a while with Share20 containing the new implementation. The only use was to determine whether remote sharing was enabled or not, which we can do much more easily. Signed-off-by: Carl Schwan <carlschwan@kde.org>	5 months ago
Robin Appelman	d14c4082e1	test: add test for updating cached mounts with multiple entries for root id Signed-off-by: Robin Appelman <robin@icewind.nl>	6 months ago
Josh	2d39c5a179	test(Storage): avoid falsy directory/filename checks (for now) Signed-off-by: Josh <josh.t.richards@gmail.com>	6 months ago
Josh	ace9eb21e6	test(Storage): expand file / directory name tests Signed-off-by: Josh <josh.t.richards@gmail.com>	6 months ago
nextcloud-command	663018455e	refactor: Apply rector changes Signed-off-by: GitHub <noreply@github.com>	6 months ago
Robin Appelman	bd8f251ad8	test: add test for calling filesize on non-existing files Signed-off-by: Robin Appelman <robin@icewind.nl>	6 months ago
provokateurin	4eada2d804	refactor(Files): Modernize Wrapper Signed-off-by: provokateurin <kate@provokateurin.de>	6 months ago
provokateurin	5f4a5d8c67	refactor(Files): Remove deprecated streamCopy method Signed-off-by: provokateurin <kate@provokateurin.de>	6 months ago
Carl Schwan	f3778bc9c7	fix(propagator): Improve lock behavior of propagator Fix possible dead locks when running the propagator caused by two requests updating the same amount rows in transactions. - Lock rows always in the same deterministic order by sorting the path_hash first - On all database outside of sqlite, also do first a SELECT FOR UPDATE to lock all the rows used in batch UPDATE calls, afterward to decrease the risk of two requests trying to lock the same rows Signed-off-by: Carl Schwan <carlschwan@kde.org>	6 months ago
provokateurin	f12cecb684	feat(rector): Enable SafeDeclareStrictTypesRector Signed-off-by: provokateurin <kate@provokateurin.de>	6 months ago
Ferdinand Thiessen	762ae4520a	fix(InMemoryFile): allow to stream read the contents Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	6 months ago
Carl Schwan	9a26169323	fix(WatcherTest): Properly mock getCache and getScanner in IStorage Otherwise we end up with trying to assign null to a property which has strict types. Signed-off-by: Carl Schwan <carlschwan@kde.org>	7 months ago

1 2 3 4 5 ...

590 Commits (04aa4e851efec1cf3452dfa122cee040f881aa7d)