118 Commits (112ccd00a3ecb6e7c34857bef78f22eb40b0068d)

Author	SHA1	Message	Date
Lukas Reschke	88c7face07	Inject OCSClient ... Fixes https://github.com/owncloud/core/issues/21451	10 years ago
Morris Jobke	ed98cdf532	Use OCP\Util::getVersion instead of the internal private implementation	10 years ago
Scrutinizer Auto-Fixer	453e1bf66e	Scrutinizer Auto-Fixes ... This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com	10 years ago
Roeland Jago Douma	a619629ac0	Only try to load avatars in the user list if there is any	10 years ago
Thomas Müller	eebe2b9c23	User IUser::getEMailAddress() all over the place	10 years ago
Morris Jobke	0a6db3ada6	Remove OC_Config from app management template ... * add unit test for this case	10 years ago
Lukas Reschke	4971015544	Add code integrity check ... This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository. Furthermore, there is a basic implementation to display problems with the code integrity on the update screen. Code signing basically happens the following way: - There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release 😉). This certificate is not intended to be used for signing directly and only is used to sign new certificates. - Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID. - The command generates a signature.json file of the following format: ```json { "hashes": { "/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d", "/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9" }, "certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----", "signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl" } ``` `hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`. Steps to do in other PRs, this is already a quite huge one: - Add nag screen in case the code check fails to ensure that administrators are aware of this. - Add code verification also to OCC upgrade and unify display code more. - Add enforced code verification to apps shipped from the appstore with a level of "official" - Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release - Add some developer documentation on how devs can request their own certificate - Check when installing ownCloud - Add support for CRLs to allow revoking certificates **Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature: ``` ➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt Successfully signed "core" ``` Then increase the version and you should see something like the following:  As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen. For packaging stable releases this requires the following additional steps as a last action before zipping: 1. Run `./occ integrity:sign-core` once 2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.	10 years ago
Roeland Jago Douma	0265bcfdae	Moved changedisplayname to usercontroller ... Killed the old static route to change a users display name and moved it to a properly testable controller.	10 years ago
Morris Jobke	18f0bafd88	fix subadmin user count for empty groups	10 years ago
Vincent Petry	781bca2437	Fix everyone count for subadmins ... Also moved the logic to the UsersController	10 years ago
Lukas Reschke	c6f6a8758b	Drop OC_SubAdmin and replace usages	10 years ago
Joas Schilling	e19c49295a	Use speaking ids	10 years ago
Joas Schilling	a9a6d4c182	Stay on the same category when refreshing the page on the apps list	10 years ago
Lukas Reschke	8f09d5b67c	Update license headers	10 years ago
Roeland Jago Douma	02af4269f2	Fix unit test ... Now that OC_SubAdmin is just a wrapper around OC\SubAdmin some unit tests had to be fixed because they expected different behaviour. Eventually they should move to properly mocked instances of OC\SubAdmin of course	10 years ago
Robin McCorkell	03dd1386da	Fix memcached/memcache module check	10 years ago
Vincent Petry	14591d9df7	Use injected request	10 years ago
Morris Jobke	bf579a153f	fix IE8 user agent detection	10 years ago
Vincent Petry	c7aef6c368	Fix uploading avatar and root certs in IE8	10 years ago
Lukas Reschke	12181aa6de	Don't perform checks for outdated TLS libs when no internet connection ... This change makes the check return a positive result when: - The instance has been configured to not use the internet AND/OR - S2S AND the appstore is disabled	10 years ago
Lukas Reschke	9b220d0576	Fix comment syntax	10 years ago
Lukas Reschke	384c6fd3ac	Fix importing of certificates ... Fixes https://github.com/owncloud/core/issues/19601	10 years ago
Morris Jobke	8366ce2767	deduplicate @xenopathic	10 years ago
Morris Jobke	b519965408	[admin] check for correct PHP memcached module	10 years ago
Morris Jobke	b945d71384	update licence headers via script	10 years ago
Robin McCorkell	27bc781cba	Update isCertificateImportAllowed() check to new API	10 years ago
Morris Jobke	c86cac6a2b	use config.php value instead of version string	10 years ago
Robin McCorkell	2579999373	Add setup check for reverse proxy header configuration	11 years ago
Bjoern Schiessle	dc5e89e624	also block certificate management in the back-end if external storages are disabled for the user	11 years ago
Roeland Jago Douma	72ba67815e	Display warning in security & setup warnings if php version is EOL	11 years ago
Lukas Reschke	7f6c5e456b	Add unit tests	11 years ago
Bjoern Schiessle	2c8fa54881	set logger in constructor	11 years ago
Lukas Reschke	0d515de13e	Detect old NSS and OpenSSL versions ... This will detect old NSS and OpenSSL versions and show appropriate errors in the admin interface. Fixes https://github.com/owncloud/core/issues/17901	11 years ago
Bjoern Schiessle	3000f0125f	don't move keys if the key where already moved in a previous migration run	11 years ago
Morris Jobke	533a23611a	Handle returned null value in app level code ... * getApplication on OCSClient can also return null this is now handled properly * fixes #17587	11 years ago
Bjoern Schiessle	85c3b9d5cf	only cleanUp the remaining keys if the migration really finished succesfully	11 years ago
Lukas Reschke	1db047a336	Add missing version field	11 years ago
Joas Schilling	ae3d402dbc	Send OC version to appstore so it can reply with the right links	11 years ago
Lukas Reschke	30145c0b52	Also load enabled apps	11 years ago
Morris Jobke	f63915d0c8	update license headers and authors	11 years ago
Lukas Reschke	00a65e30ce	Request approved state for disabled apps with ocsid ... In case an application gets disabled the level is set to "experimental" if it does not contain a `shipped` tag. This can for example be reproduced by installing the documents app from the appstore and then disabling it. Or cloning an app from git. With this change the controller will now load the level of the application from the appstore if a valid OCSID has been provided. Fixes https://github.com/owncloud/core/issues/17003	11 years ago
Joas Schilling	171f86ca2e	Only sort by group name when LDAP is involved	11 years ago
Joas Schilling	5ca6ec7ead	Make "include update info" part of the cache key	11 years ago
Joas Schilling	580155abe7	Load the update information asyncroniously to fix the page load speed	11 years ago
Bjoern Schiessle	0de59acb49	only request encryption module for files which are not excluded	11 years ago
Lukas Reschke	bc6d17ed74	Add check for availability of /dev/urandom ... Without /dev/urandom being available to read the medium RNG will rely only on the following components on a Linux system: 1. MicroTime: microtime() . memory_get_usage() as seed and then a garbage collected microtime for loop 2. MTRand: chr((mt_rand() ^ mt_rand()) % 256) 3. Rand: chr((rand() ^ rand()) % 256) 4. UniqId: Plain uniqid() An adversary with the possibility to predict the seed used by the PHP process may thus be able to predict future tokens which is an unwanted behaviour. One should note that this behaviour is documented in our documentation to ensure that users get aware of this even without reading our documentation this will add a post setup check to the administrative interface. Thanks to David Black from d1b.org for bringing this again to our attention.	11 years ago
Joas Schilling	d683752b37	Sort user groups by group name and hide the user count	11 years ago
Lukas Reschke	a7a2579c89	Subadmin permissions are also not required	11 years ago
Lukas Reschke	cdeb2052bb	Add NoAdminRequired annotation ... Stupid mistake in master, fixes https://github.com/owncloud/core/issues/16288	11 years ago
Morris Jobke	5fd849f545	Allow user to set an empty email address ... * fixes #16057	11 years ago