11 Commits (173c31e42af766298c9f43837a9a3e4021cdc131)

Author	SHA1	Message	Date
Jenkins for ownCloud	b585d87d9d	Update license headers	10 years ago
Lukas Reschke	e2453d78c0	Properly catch whether a share is `null` ... Despite it's PHPDoc the function might return `null` which was not properly catched and thus in some situations the share was resolved to the sharing users root directory. To test this perform the following steps: * Share file in owncloud 7 (7.0.4.2) * Delete the parent folder of the shared file * The share stays is in the DB and the share via the sharelink is inaccessible. (which is good) * Upgrade to owncloud 8 (8.0.2) (This step is crucial. The bug is not reproduceable without upgrading from 7 to 8. It seems like the old tokens are handled different than the newer ones) * Optional Step: Logout, Reset Browser Session, etc. * Access the share via the old share url: almost empty page, but there is a dowload button which adds a "/download" to the URL. * Upon clicking, a download.zip is downloaded which contains EVERYTHING from the owncloud directory (of the user who shared the file) * No exception is thrown and no error is logged. This will add a check whether the share is a valid one and also adds unit tests to prevent further regressions in the future. Needs to be backported to ownCloud 8. Adding a proper clean-up of the orphaned shares is out-of-scope and would probably require some kind of FK or so. Fixes https://github.com/owncloud/core/issues/15097	10 years ago
Joas Schilling	3052b9571e	Fix controller test	10 years ago
Lukas Reschke	48243a2949	Allow iframes from same domain in share view ... This is required because the PDF Viewer itself is embedded using an iframe from the same domain. The default policy is blocking this. Going on further, we have to come up with a solution in the future how to handle previews by applications, one example might be that they call their own endpoint and not the generic share page to allow applications to have full control over how to display previews. Anyways, to test this behaviour use a decent newer browser (such as Chrome 41) and share a PDF file, obviously the PDF viewer needs to be enabled as well. Without this patch publicly shared PDF files should not get previewed and an error is thrown. (if it isn't then your browser is probably not obeying our Content-Security-Policy and you might consider switching to another one ;))	10 years ago
Morris Jobke	06aef4e8b1	Revert "Updating license headers" ... This reverts commit 6a1a4880f0.	10 years ago
Joas Schilling	993d89b3cc	Extend the class so the Filesystem is cleaned up	10 years ago
Jenkins for ownCloud	6a1a4880f0	Updating license headers	10 years ago
Georg Ehrke	374ddbff55	show animated gifs on public sharing page	10 years ago
Lukas Reschke	f3ab4f3faf	Don't disclose relative directory path for single shared files of user ... The "dir" key is used within the public sharing template to indicate in which directory the user currently is when sharing a directory with subdirectories. This is needed by the JS scripts. However, when not accessing a directory then "dir" was set to the relative path of the file (from the user's home directory), meaning that for every public shared file the sharee can see the path. (For example if you share the file "foo.txt" from "finances/topsecret/" the sharee would still see the path "finances/topsecret/" from the shared HTML template) This is not the excpected behaviour and can be considered a privacy problem, this patch addresses this by setting "dir" to an empty key.	10 years ago
Vincent Cloutier	fad621140b	Added download size on public sharing	10 years ago
Lukas Reschke	988c85d292	Refactor file sharing public link handling ... fixes download issue introduced by #10755 Conflicts: apps/files_sharing/public.php	10 years ago