146 Commits (1f42657bb9ea76353fbc02ee100cff5755b6384d)

Author	SHA1	Message	Date
Julius Härtl	964fd27666	Handle single action unshare ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Simounet	45c3b2a478	Settings: new user row replaced by a modal ... Signed-off-by: Simounet <contact@simounet.net>	5 years ago
Daniel Calviño Sánchez	14b85f4eec	Replace carriage return with WebDriver "ENTER" constant ... When the value is set in some input fields a carriage return was sent to simulate pressing the enter key and thus confirming the input. However, different browsers use different keys (Firefox uses "\r", but Chrome uses "\n"), so the carriage return was replaced with the WebDriver "ENTER" constant which is common to both browsers. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	38b88422a8	Do not send "enter" key when not needed ... Sending the "enter" key is not needed in those input fields that auto save while the user is typing or when the focus is lost (which since version 1.4.0 the Selenium driver for Mink is automatically done after setting the value). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	7625a87412	Update Selenium driver for Mink from 1.3.1 to 1.4.0 in acceptance tests ... Since version 1.4.0 the Selenium driver for Mink uses again the element on which the value was set (see https://github.com/minkphp/MinkSelenium2Driver/pull/286). When creating a new folder or renaming one sending a new line ("\r") caused the element on which the value was set to be removed, so the element was no longer attached to the DOM when the driver tried to use it again, and thus a "StaleElementReference" exception was thrown. Due to this now it is needed to explicitly click the confirm button when creating a new folder. In the case of the renaming, on the other hand, nothing else besides not sending the new line is needed, as the Selenium driver now unfocuses the element (that is why it uses again the element after setting the value) which triggers the renaming. Besides that, the Selenium driver for Mink uses a library to simulate certain events, bitovi/syn. In version 1.4.0 that library was updated to version 0.0.3, which seems to somehow break pressing the "escape" key. Due to this now the sharing menu has to be closed by pressing "enter" on the share menu button instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	b53f49b940	Update PHPUnit from 4.X to 6.X in acceptance tests ... The PHPUnit update also required an update of "symfony/yaml", so besides the changes needed for PHPUnit the "behat.yml" file also had to be adjusted. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Joas Schilling	cf8f9c16df	Change label also in the acceptance tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 years ago
Daniel Calviño Sánchez	ee1f8104a0	Find directly the label instead of falling back to it ... The input element is always hidden, so the check always ended falling back to the label. Moreover, the label is the element that the user interacts with, so it must be the one used. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	7b6946d2d2	Assert also element visibility instead of just finding it ... Although if the element could not be found an exception would be thrown and the test aborted if an element is in the DOM but hidden it would be found and the test would pass. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	78faf0105d	Add explicit locator for "Enable all" bundle button ... Instead of looking for the bundle button and then checking its value now the expected value is included in the locator and the button is checked similarly to other elements. No "Disable all" locator was added as it was not currently needed anywhere. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	f87473e410	Find elements through the actor rather than the driver ... "Actor::find" is a more robust way to look for elements, as it handles some exceptions that may be thrown. Therefore, even if the elements are not actually used and it is only checked whether they exist or not using the actor is the preferred way when possible (and it also makes it consistent with the rest of the acceptance tests). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	6d145ea54a	Add locator for apps list ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	4c23d24277	Fix identation ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	bc084070c8	Fix delete user acceptance test ... Adding some missing asserts showed that the "delete user" acceptance test was silently failing, as the deletion was not being confirmed in the dialog and thus the user was not being deleted. The dialog button contains a single quote ("user0's"), so the XPath expression had to be adjusted (it seems that it is not possible to escape a single quote in a string enclosed in single quotes in XPath 1.0). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	d5586ec437	Verify WaitFor::element... results with an assertion ... WaitFor::element... calls only perform the waiting and return whether the condition succeeded or not, but that result needs to be explicitly checked to prevent further steps from being executed if the wait failed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	caa2246568	Add missing waits when finding elements in the acceptance tests ... As no timeout was specified the elements were tried to be found just once. This caused the steps to fail if the elements did not appear yet in the page when they were tried to be found. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	b6dec0be99	Add acceptance tests for reshares by link when resharing is disabled ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	22d949d9d9	Add acceptance tests for reshares when resharing is disabled ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	96821945fb	Adjust acceptance tests to changes in @nextcloud/vue 2.6.3 ... The menu button and the menu of a share are no longer direct childs of the actions of the share row. The menu button is now a child of a ".trigger" element, while the menu is a direct child of the body and has an id defined in the "aria-describedby" attribute of the ".trigger" element. In XPath 1.0 it does not seem possible to "backreference" a value or create variables, so when the share menu or one of its item is needed now the ".trigger" element is first found and then its XPath expression is used to compose its "aria-describedby" attribute in the XPath expression for the menu. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	034b7bd4a9	Fix clicks on actions menu of non opaque file rows in acceptance tests ... When a row is added to the file list the opacity of the file row is animated from transparent to fully opaque. As the file actions menu is a descendant of the row but overflows it when the row is not fully opaque clicks on the menu entries "fall-through" and are received instead by the rows behind. The opacity animation is a CSS animation, and it is not possible to know if a row is appearing or not except from its opacity (the row will have the "appear" CSS class even after the animation ended). Therefore it should be waited until the row of the file is fully opaque before using the menu. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Morris Jobke	5a06e38564	Dashboard app is disabled and there is no need to redirect to files app ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Julius Härtl	4679926511	Redirect to files app after login in acceptance tests ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	6 years ago
Daniel Calviño Sánchez	9303390b66	Hide share link menu before copying the share link in acceptance tests ... The (old) Firefox version used in the acceptance tests does not properly render the share link menu. As the menu is taller than it should sometimes it covers the copy link button, so it is not possible to click it without hiding the share link menu. Moreover, in those cases the share menu button is also covered by the share menu, so the menu needs to be closed by pressing the "Esc" key. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Georg Ehrke	f217b11443	Fix breaking changes of nc/vue update ... Signed-off-by: Georg Ehrke <developer@georgehrke.com>	6 years ago
Daniel Calviño Sánchez	33222d67ea	Add acceptance test for sharing a folder without create permission ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	573bf4d667	Add acceptance test for sharing a file without edit permission ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	cafa68493a	Generalize functions to get locators for share permission checkboxes ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
John Molakvoæ (skjnldsv)	0f135c7bd6	Bump acceptance tests ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function ... To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	14c996d982	Use elseif instead of else if ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	a8a06a82d2	Remove trailing whitespaces from comments ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	44577e4345	Remove trailing and in between spaces ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	afbd9c4e6e	Unify function spacing to PSR2 recommendation ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2fbad1ed72	Fix (array) indent style to always use one tab ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Azul	62f7e6ba81	tests: fix failing header acceptance test ... The username is listed in a div with class `fullname` now. Signed-off-by: Azul <azul@riseup.net>	6 years ago
Christoph Wurst	b80ebc9674	Use the short array syntax, everywhere ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	74936c49ea	Remove unused imports ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Daniel Calviño Sánchez	4ec370016f	Add acceptance test for restricting user enumeration to groups ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	9386f24ab0	Add acceptance test for accepting an incoming share ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	887e740434	Fix timeout capping ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
GretaD	455013c309	fix the folder share ... Signed-off-by: GretaD <gretadoci@gmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>	6 years ago
Greta Doci	c864bc8321	Move users management to multi line ... Signed-off-by: Greta Doci <gretadoci@gmail.com>	6 years ago
Daniel Calviño Sánchez	f402e23448	Accept incoming shares in acceptance tests ... Incoming shares are no longer automatically added to the file list of the sharee. Instead, the user now needs to explictly accept the share. Currently shares can be accepted only from the Notifications app, so it must be explicitly cloned before installing Nextcloud if it is not found in the "apps" directory. Note that the development branches are already built, so there is no need to explicitly build the app. With the new sharing behaviour the "share a skeleton file with another user before first login" scenario is no longer valid (as the user will need to log in to accept the share, so at that point the skeleton is already created), so it was removed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	0abff19aa9	Rename "Notification" to "Toast" ... Since Nextcloud 17 the proper name for the old built-in notifications is "Toast". Moreover, this will reduce ambiguity when using the "notification" term to refer to elements in the Notifications app. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
John Molakvoæ (skjnldsv)	12eba18bdf	Adjust acceptance tests to new OCA.Sidebar ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
John Molakvoæ (skjnldsv)	4293ede565	Fix tag acceptance tests after #16682 ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
John Molakvoæ (skjnldsv)	f737dc9a86	Remove input id on login form ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>	6 years ago
Greta Doci	1993984769	Adjust acceptance tests to changes in link share menu behaviour ... Now the link share menu is not automatically opened after a link share is created, so waiting until it was opened failed in iShareTheLinkFor. Note that the steps that interact with the link share menu take care themselves of showing the menu if needed, so there is no need to explicitly show it despite the change. Also, the waiting in iShareTheLinkFor was introduced when the link share menu was changed to automatically open after creating a link share, as that caused some issues with the steps that opened the menu by themselves (fec8d12fc5). Due to all this, now that the link share menu is again not automatically opened the wait can be simply removed. Signed-off-by: Greta Doci <gretadoci@gmail.com>	6 years ago
Daniel Calviño Sánchez	e65fd11419	Add messages to assertFalse/True to clarify the failed assertion ... Otherwise the output would just read "Failed asserting that true is false." or "Failed asserting that false is true.", which is not very informative when there are several assertFalse/True in a row. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	df8406dbae	Adjust acceptance tests to notifications based on toastify ... The old notifications were added as ".row" elements to the "#notification-container" element; the new notifications based on toastify are added as ".toastify .on .toast..." elements to the "#content" element. Besides that, they also include a span element with an X to close the notification, so now only the first child text node should be compared to the expected message. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago