9 Commits (1f42657bb9ea76353fbc02ee100cff5755b6384d)

Author	SHA1	Message	Date
Daniel Calviño Sánchez	f216b9307a	Update Mink from 1.7.1 to 1.8.1 in acceptance tests ... Since version 1.8.0 of Mink "Mink::getSession()" no longer starts the session automatically (see https://github.com/minkphp/Mink/pull/705), so it now needs to be explicitly started. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function ... To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	b80ebc9674	Use the short array syntax, everywhere ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Daniel Calviño Sánchez	f844799d9b	Move the browser window of an actor to the foreground when acting as him ... Each time a new actor appears in a scenario the browser window of the new actor is put in front of the browser windows of the previous actors. Before, when acting again as a previous actor his browser window stayed in the background; in most cases everything worked fine even if the window was in the background, but due to a bug in the Firefox driver of Selenium and/or maybe in Firefox itself when the window was in the background it was not possible to set the value of an input field that had a range selected. Now, when acting again as a previous actor his browser window is brought to the foreground. This prevents the bug from manifesting, but also reflects better how a user would interact with the browser in real life. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	10490f2ac3	Store the name of the actor in the Actor object ... This is needed to be able to easily use the actor as a key in an array. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	b10478ff19	Try again to start browser sessions when they fail ... Starting a session for an Actor can fail, typically, due to a timeout connecting with the web browser. Now if the session fails to start it will be tried again up to "actorTimeoutMultiplier" times in total before giving up. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	e355e953b5	Generalize attribute name ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	13c84f6629	Add system to share data between acceptance test steps ... The data storage (the "notebook") is shared between all the actors, so the data can be stored and retrieved between different steps by any actor in the same scenario. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	2f80025ec2	Move acceptance tests from build/acceptance to tests/acceptance ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	be96be09b5	Add general multiplier for find timeouts ... Although the timeouts specified in the acceptance tests are enough in most cases they may not be when running them in a slow system or environment. For those situations a general multiplier for find timeouts is added. It can be set in the "behat.yml" configuration file to increase the timeout used in every find call (except those that used a timeout of 0, as in those cases the element had to be already present when finding it and whether the system is slow or not does not change that). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	7c07f01d59	Add actors for test scenarios ... An actor plays the role of an end-user in the test scenario. As such, each actor has its own web browser session used to perform the actions specified by the steps of the scenario. Only one actor is active at a time in a test scenario, and the current actor can be set through the "I act as XXX" step; from then on, all the steps are performed by that actor, until a different actor is set by calling "I act as XXX" again. If no actor was explicitly set in a scenario then the default actor, unsurprisingly named "default", is the one used. The ActorContext class is added to provide automatic support for all that. To use the ActorContext, besides adding it to the context list in "behat.yml", a Mink session for each actor used in the features must be specified in "behat.yml". Once done other Contexts just need to implement the ActorAwareInterface (which can be done simply by using the ActorAware trait) to have access to the current Actor object of the test scenario; as the Actor object provides its own session other Contexts do not need to extend from RawMinkContext. The ActorContext is itself a RawMinkContext, so it automatically receives the base URL of the Nextcloud test server run by NextcloudTestServerContext and propagates that base URL to all the actors. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago