253 Commits (21fd2d83171487032a0476e91ee49f2f2f094eaa)

Author	SHA1	Message	Date
Tigran Mkrtchyan	f41209a061	config: add a switch to control truncate before update ... To avoid extra truncate on non WORM file systems, add a new config option `localstorage.unlink_on_truncate`, which defaults to false. The OC\Files\Storage\Local is update to respect that option. Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>	4 years ago
Tigran Mkrtchyan	8fc4cf67f1	files: remove destination file before copying new content (WORM) ... Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>	4 years ago
Git'Fellow	5300f0d693	Switch logical operators (and|or) ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	4 years ago
Robin Appelman	bd91c56539	get quota for user only when needed ... always apply the wrapper but have the wrapper get the quota lazily only when an operation where quota is applied is performed Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Tigran Mkrtchyan	b6065a236f	files: make OC\Files\Storage\Local WORM friendly ... Some filesystems run as a Write-Once-Read-Many storages. This makes them impossible to use with NexeCloud, as the file system layers uses `truncate` syscall (through file_put_contents function). As Nextcloud is never updates existing files, removing the old entry and creatint a new one on update will allow NextCoud to update on such file systems. Update Local#fopen and Local#file_put_contents to remote existing file before truncating. Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>	4 years ago
Robin Appelman	1374cbee3e	store unencrypted size in the unencrypted_size column ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	5e375d9092	Revert "store unencrypted size in the unencrypted_size column" ... This reverts commit 8238582e59. Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Carl Schwan	d5c23dbb9f	Move CappedMemoryCache to OCP ... This is an helpful helper that should be used in more place than just server and this is already the case with groupfodlers, deck, user_oidc and more using it, so let's make it public Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Martin Brugnara	7409569994	Expose umask override value as config parameter: localstorage.umask ... Commit 451c06d introduced override for umask value. This is needed to avoid broken env configuration or dirty workers to mess with the permissions when creating new files. Most Nextcloud, that does not integrate with external software would work fine with an hard-coded value (451c06d set it at 022). Advanced install may require more flexibility, as such this commit exposes the "umask override value" as configuration parameter: `localstorage.umask` It defaults to 0022 both in code and in config/config.sample.php . Signed-off-by: Martin Brugnara <martin@0x6d62.eu>	4 years ago
Robin Appelman	8238582e59	store unencrypted size in the unencrypted_size column ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Côme Chilliet	2b07031d3e	composer run cs:fix ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Côme Chilliet	23f7a37c03	Remove ILogger usages in lib/private/Files/Storage ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Robin Appelman	468d6a9cf1	ignore forbidden files while scanning local storage ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Robin Appelman	f9a5fb99fd	use the same cached propfind for free space for dav storage ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Max Kunzelmann	2952c7d01f	Use the null coalescing operator to set the value of `size`. ... Signed-off-by: Max Kunzelmann <maxdev@posteo.de>	4 years ago
Côme Chilliet	e8c1f75064	Fixing psalm errors ... Encryption constructor is problematic and should still be fixed later. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Côme Chilliet	6be7aa112f	Migrate from ILogger to LoggerInterface in lib/private ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Max Kunzelmann	3a135f0c5f	Set `mtime` to null instead of false if `getlastmodified` does not exist. ... Signed-off-by: Max Kunzelmann <maxdev@posteo.de>	4 years ago
Max Kunzelmann	e0a5fe649a	Fix typo. ... Signed-off-by: Max Kunzelmann <maxdev@posteo.de>	4 years ago
Max Kunzelmann	ee888875bb	Fixes the undefined index error with the DAV property getlastmodified ... Signed-off-by: Max Kunzelmann <maxdev@posteo.de>	4 years ago
Robin Appelman	84f464550a	some file scanner performance improvements ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Tiramisu Mokka	8190441335	files: close open directory file descriptor on error path	4 years ago
Côme Chilliet	5cca86ce19	Remove redundant if clause ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Côme Chilliet	35dcda36a3	Fix OC\Files\Storage\DAV::hasUpdated when cache is not set ... Fixes the test OCA\Files_External\Tests\Storage\WebdavTest::testStat on PHP>=7.4 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Carl Schwan	cbf9064b8e	Fix psalm issues ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	695165260f	Add helper method in Wrapper ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Jonas Meurer	a2f4c62c19	updateEncryptedVersion: cleanup on target if cache already got renamed ... When moving a file to trash with encryption enabled, the cache gets moved before the actual file. According to @icewind1991 this is in order to not break object storage. When moving a file from an unencrypted storage (e.g. a collectives storage) to the encrypted trashbin storage, this causes errors, see This commit fixes it by doing `updateEncryptedVersion()` on the target cache entry *if* the source cache entry doesn't exist anymore, but the corresponding target cache entry does exist already. Fixes: #26544 Signed-off-by: Jonas Meurer <jonas@freesources.org>	4 years ago
Vincent Petry	be590df588	Fix fail when keys/files folder already exists ... Fixes an issue with transfer ownership in move mode where the folder "files_encryption/keys/files" already exists. Instead of failing, its existence is checked before calling mkdir. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	6f81e60bce	Check resource before closing in encryption wrapper ... In case of error there is no guarantee that $source or $target is set or is a resource when handling an error. Without this fix, there's a risk that fclose will fail and the actual exception will not be thrown, making it impossible to find out about the root cause. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Joas Schilling	65d79bb592	Check for invalid characters before trimming ... Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago
acsfer	152e2bfdaa	Check for `disk_free_space` ... Check for `disk_free_space` before calling it. Fix https://github.com/nextcloud/server/issues/29748	4 years ago
Vincent Petry	c92a0e4152	Normalize directory entries in Encoding wrapper ... Directory entry file names are now normalized in getMetaData(), getDirectoryContents() and opendir(). This makes the scanner work properly as it assumes pre-normalized names. In case the names were not normalized, the scanner will now skip the entries and display a warning when applicable. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	4 years ago
Vincent Petry	93fb33d863	Update lib/private/Files/Storage/Wrapper/Availability.php add void ... Signed-off-by: Vincent Petry <vincent@nextcloud.com> Co-authored-by: Carl Schwan <carl@carlschwan.eu>	5 years ago
Vincent Petry	db29fd29ee	Return false in hasUpdated when storage is not available ... Technically, saying that a storage has no updates when it's not available is correct. This makes it possible to retrieve the cache entry for the mount point and also to list and remove unavailable federated shares. Signed-off-by: Vincent Petry <vincent@nextcloud.com>	5 years ago
alanmeeson	16f70e8647	Add type hint to fread_block $blockSize param & apply cs:fix. ... Signed-off-by: alanmeeson <alan@carefullycalculated.co.uk>	5 years ago
Alan Meeson	44c332a46e	Fix truncation of files upon read when using object store and encryption. ... When using and object store as primary storage and using the default encryption module at the same time, any encrypted file would be truncated when read, and a text error message added to the end. This was caused by a combination of the reliance of the read functions on on knowing the unencrypted file size, and a bug in the function which calculated the unencrypted file size for a given file. In order to calculate the unencrypted file size, the function would first skip the header block, then use fseek to skip to the last encrypted block in the file. Because there was a corresponence between the encrypted and unencrypted blocks, this would also be the last encrypted block. It would then read the final block and decrypt it to get the unencrypted length of the last block. With that, the number of blocks, and the unencrypted block size, it could calculate the unencrypted file size. The trouble was that when using an object store, an fread call doesn't always get you the number of bytes you asked for, even if they are available. To resolve this I adapted the stream_read_block function from lib/private/Files/Streams/Encryption.php to work here. This function wraps the fread call in a loop and repeats until it has the entire set of bytes that were requested, or there are no more to get. This fixes the imediate bug, and should (with luck) allow people to get their encrypted files out of Nextcloud now. (The problem was purely on the decryption side). In the future it would be nice to do some refactoring here. I have tested this with image files ranging from 1kb to 10mb using Nextcloud version 22.1.0 (the nextcloud:22.1-apache docker image), with sqlite and a Linode object store as the primary storage. Signed-off-by: Alan Meeson <alan@carefullycalculated.co.uk>	5 years ago
Carl Schwan	9408f8ae69	Fix security issues when copying groupfolder with advanced ACL ... Using advanced ACL, it is possible that an user has access to a directory but not to a subdirectory, so the copying use Common::copyFromStorage instead of Local::copyFromStorage. Fix https://github.com/nextcloud/groupfolders/issues/1692 Signed-off-by: Carl Schwan <carl@carlschwan.eu>	5 years ago
Robin Appelman	b3766fc99b	make param names consistent with interface for copy directory polyfill ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
acsfer	98eac0fc05	Simplify :)	5 years ago
acsfer	8a8df49bc0	Replace `file_exists()` method by `is_file()`	5 years ago
acsfer	3a25183b66	Get `filesize()` if `file_exists()` ... Should make sense.	5 years ago
Daniel Kesselberg	be3f4edf1f	explicitly close source stream on encryption storage ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	5 years ago
Daniel Kesselberg	e60a829b42	explicitly close source stream on local storage ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	5 years ago
acsfer	9324a74bba	Handle files with is_file instead of file_exists ... Should fix things like `fread(): read of 8192 bytes failed with errno=21 Is a directory`	5 years ago
Julius Härtl	bc3c46362a	Make sure that a empty directory can still be deleted when copied from another storage ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Carl Schwan	28970563a2	Remove some mentions of ownCloud from our api documentation ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	5 years ago
Lukas Reschke	28359571de	Remove Flysystem storage class ... This seems unused as per https://github.com/nextcloud/server/issues/27768 and may allow us to get rid of one more dependency. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	5 years ago
Rid	0469acfb20	Fix scanner mistaking socket files for directories ... Signed-off-by: Rid <rid@cylo.io>	5 years ago
John Molakvoæ (skjnldsv)	215aef3cbd	Update php licenses ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	5 years ago
Robin Appelman	ed2d02d5f1	better cleanup of user files on user deletion ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago