327 Commits (231ec6717cf77ebce4e55a2abd12e40ab9995430)

Author	SHA1	Message	Date
Git'Fellow	54bbb32f4a	fix(preview): qualify the ambiguous columns in PreviewMapper queries ... joinLocation() joins previews (p) with preview_locations (l) and preview_versions (v). Both previews and preview_versions have a file_id column, so any unqualified file_id condition is ambiguous and MySQL or MariaDB reject the query with error 1052. getPreviewForSpecification() built its conditions straight from the caller's array keys, so this broke every preview save: savePreview() uses that lookup to recover the existing row after a unique constraint violation. getByFileId() had the same unqualified condition, while getAvailablePreviewsForFile() next to it already used p.file_id. Columns that come from the joined tables keep resolving to their own alias, and keys that already carry one are passed through untouched. The values are bound with an explicit type as well. An untyped false binds as an empty string, which PostgreSQL rejects for a boolean column, so qualifying the columns on their own only moved the error on that backend. Fixes: https://github.com/nextcloud/server/issues/63229 Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	5 days ago
Josh	70938c2eba	fix(preview): declare Preview version ID getter ... Signed-off-by: Josh <josh.t.richards@gmail.com>	6 days ago
Josh	75fd7f27ef	fix(preview): delete version metadata by preview ID ... Signed-off-by: Josh <josh.t.richards@gmail.com>	6 days ago
Josh	ece7bf5660	fix(preview): order previews by ID during pagination ... Signed-off-by: Josh <josh.t.richards@gmail.com>	7 days ago
Git'Fellow	4920bd1725	refactor: add PHP 8.3 types to BC-safe class constants ... PHP 8.3 allows class constants to declare a type. Adopt it where doing so cannot break third-party apps. Typing an inheritable constant is a hard BC break: a subclass that redeclares it untyped fails to load with "Type of C::FOO must be compatible with P::FOO of type string". Changes are therefore limited to constants that cannot be redeclared by a subclass: - private const (not inherited) - final public/protected const - constants declared in a final class or an enum Interface constants, trait constants, and public/protected constants in non-final (including abstract) classes are left untyped, as is all of lib/public (OCP) and lib/unstable (NCU). One review-requested exception: the public OBJECT_PREFIX/OBJECT_SUFFIX constants of the app-internal CalDAV import helpers (TextImporter, XmlImporter) are typed as well; these classes are not public API and have no subclasses. Only string, int and array are used. float is avoided because it would silently coerce an int literal and change === comparisons. No constant name or value is modified: every changed line adds only the type token, so runtime behaviour is unchanged. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	1 week ago
Carl Schwan	64cdaba77c	fix(Preview): Fix sharding of the PreviewMigrationService ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 weeks ago
Carl Schwan	831d4a6f60	perf: Don't list items twice in the preview folder ... Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 weeks ago
Carl Schwan	0525899e35	perf: Batch deletion of old file entries ... Faster than doing a commit after each file Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 weeks ago
Benjamin Gaussorgues	26f69a8857	Revert "fix: Disable imagick preview providers" ... This reverts commit 706fe8f817. Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	3 weeks ago
Benjamin Gaussorgues	e8d545e04c	feat(previews): add file signature check before opening files ... Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	3 weeks ago
nextcloud-command	cbbbe5ac14	refactor: Apply rector changes ... Signed-off-by: GitHub <noreply@github.com>	1 month ago
Git'Fellow	fcc63b9603	refactor(dbal): move to modern calls ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Signed-off-by: Carl Schwan <carlschwan@kde.org>	1 month ago
Ferdinand Thiessen	815298d038	fix(preview): properly handle encoded content ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 month ago
Joas Schilling	706fe8f817	fix: Disable imagick preview providers ... Signed-off-by: Joas Schilling <coding@schilljs.com>	1 month ago
Carl Schwan	7629df9c6b	fix(preview): Handle unique constraints violation exception ... Delete the preview from storage and fetch the actual one from the DB. This should not happen often. Signed-off-by: Carl Schwan <carlschwan@kde.org>	1 month ago
Carl Schwan	0b9e592796	refactor: Soft remove Emitter from IRootFolder interface ... Move this to the private implementation in OC, so that using IRootFolder in apps doesn't require dummy stubs. This will create a new psalm warnings for users of this method but considering that this is deprecated for a long time and that it still works at runtime, this shouldn't cause any issue. Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
cn-shell	cb8c152ed3	fix(previews): movie preview bug fix, in some case stream reading functions may block indefinitly ... Signed-off-by: cn-shell <jpsn@foxmail.com> Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 months ago
Carl Schwan	fc4938c3ed	fix(preview): Better handle errors while migrating previews ... Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Carl Schwan	c00f82aa82	fix(preview): Don't reuse same query builder for delete query ... Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Andrey Dyakov	136b88180b	fix(previews): ffprobe hangs ... Signed-off-by: Andrey Dyakov <adduxa@gmail.com>	3 months ago
Carl Schwan	994565fec7	refactor: Use new IQueryBuilder::MAX_IN_PARAMETERS ... Signed-off-by: Carl Schwan <carlschwan@kde.org>	3 months ago
Côme Chilliet	2357612b11	fix: Make sure getNumConcurrentPreviews never returns 0 ... Tests were stuck forever waiting for a semaphore because concurrency was returning 0. It was previously working by chance because cache of the value in a static var was leaking through tests. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Côme Chilliet	b1f07e887e	fix: Remove static vars in preview Generator ... There is only one instance so caching in a property is enough. There were two levels of caching, removed one. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Côme Chilliet	1ab09ec753	chore: Apply new coding standard to all files ... The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines To see only the changes not related to blank lines. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Anna Larch	0681ced203	fix(previews): use createParameter/setParameter to reuse query in chunk loop ... AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>	4 months ago
Anna Larch	59144ace90	fix(previews): fix chunking for querybuilder ... Signed-off-by: Anna Larch <anna@nextcloud.com>	4 months ago
David Dreschner	fce8b710df	fix(LocalPreviewStorage): Use correct regex to detect files in nested directory format ... Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>	4 months ago
Ferdinand Thiessen	e0ba4d71b6	chore: add missing `Override` attribute to `OC` ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 months ago
Joas Schilling	5f80f26799	chore: Fix SPDX header ... Signed-off-by: Joas Schilling <coding@schilljs.com>	5 months ago
Git'Fellow	304c9fbc3b	fix(preview): Validate preview MIME type ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	6 months ago
Anna Larch	e3c6702cd8	perf(preview): bulk process preview regeneration ... Signed-off-by: Anna Larch <anna@nextcloud.com>	6 months ago
Benjamin Gaussorgues	6727f83a3b	chore(previews): delete empty previews directory during migration ... Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	6 months ago
Benjamin Gaussorgues	30e35a8411	fix(perf): use index when deleting old previews ... Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	6 months ago
Carl Schwan	3d18cd7cc5	fix(preview): Fix files:app-data-scan for previews ... And add unit tests for both migrated files and non-migrated files Signed-off-by: Carl Schwan <carlschwan@kde.org>	6 months ago
Carl Schwan	4722f56778	fix(preview): Handle unique constraints ... Signed-off-by: Carl Schwan <carlschwan@kde.org>	6 months ago
provokateurin	fe9e43c165	feat(preview): Expire previews ... Signed-off-by: provokateurin <kate@provokateurin.de>	6 months ago
Carl Schwan	543b46f3aa	fix(preview): Fix scanning preview ... Make sure we set the mimetype string representation and not int representation. Signed-off-by: Carl Schwan <carlschwan@kde.org>	6 months ago
Anna Larch	99a1150ec2	fix(snowflake): cast lastId to int ... Signed-off-by: Anna Larch <anna@nextcloud.com>	6 months ago
provokateurin	f12cecb684	feat(rector): Enable SafeDeclareStrictTypesRector ... Signed-off-by: provokateurin <kate@provokateurin.de>	6 months ago
Carl Schwan	c96ece0bcb	refactor: Add more typing ... - repairs job - database - redis And remove Helpertest which was unused outside of some tests. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	7 months ago
Carl Schwan	7b6078875b	refactor: Run rector on lib/private ... Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	7 months ago
Robin Appelman	2e9f6c37d5	fix: don't try to create preview folder if it already exists ... Signed-off-by: Robin Appelman <robin@icewind.nl>	7 months ago
Ferdinand Thiessen	4b015568fc	test(preview): properly test postscript preview provider ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	7 months ago
Carl Schwan	7a025ffb0b	feat(preview): Make it possible to disable on preview migration ... Signed-off-by: Carl Schwan <carlschwan@kde.org>	7 months ago
Carl Schwan	6149168129	feat(preview): On demand preview migration ... When requesting previews, which we don't find in oc_previews, search in IAppData first before creating them. Move the logic from MovepreviewJob to PreviewMigrationService and reuse that in the Preview Generator. At the same time rename MovePreviewJob to PreviewMigrationJob as it is a better name. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	7 months ago
Carl Schwan	7c1a8a4060	feat: Adapt a bit the snowflake ids API ... - Rename setId() -> generateId() in SnowflakeAwareEntity Signed-off-by: Carl Schwan <carlschwan@kde.org>	8 months ago
Anna Larch	5f797ebc32	refactor: move existing usages of snoflake IDs SnowflakeAwareEntity ... Signed-off-by: Anna Larch <anna@nextcloud.com>	8 months ago
Anna Larch	f546daada7	refactor: Rename Snowflake Generator and Decoder ... And introduce the Snowflake DTO Signed-off-by: Anna Larch <anna@nextcloud.com>	8 months ago
Carl Schwan	2ea1bd4cdc	feat(movie-preview): Use getDirectDownloadById for generating preview ... Allow to speed-up considerably the creation of previews for movies stored on S3. Signed-off-by: Carl Schwan <carlschwan@kde.org>	8 months ago
invario	ffe91b48dc	feat(previews): allow ffmpeg to connect direct for AWS S3 buckets ... Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: invario <67800603+invario@users.noreply.github.com>	8 months ago