nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Git'Fellow	54bbb32f4a	fix(preview): qualify the ambiguous columns in PreviewMapper queries joinLocation() joins previews (p) with preview_locations (l) and preview_versions (v). Both previews and preview_versions have a file_id column, so any unqualified file_id condition is ambiguous and MySQL or MariaDB reject the query with error 1052. getPreviewForSpecification() built its conditions straight from the caller's array keys, so this broke every preview save: savePreview() uses that lookup to recover the existing row after a unique constraint violation. getByFileId() had the same unqualified condition, while getAvailablePreviewsForFile() next to it already used p.file_id. Columns that come from the joined tables keep resolving to their own alias, and keys that already carry one are passed through untouched. The values are bound with an explicit type as well. An untyped false binds as an empty string, which PostgreSQL rejects for a boolean column, so qualifying the columns on their own only moved the error on that backend. Fixes: https://github.com/nextcloud/server/issues/63229 Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	5 days ago
Josh	75fd7f27ef	fix(preview): delete version metadata by preview ID Signed-off-by: Josh <josh.t.richards@gmail.com>	6 days ago
Josh	ece7bf5660	fix(preview): order previews by ID during pagination Signed-off-by: Josh <josh.t.richards@gmail.com>	6 days ago
Git'Fellow	4920bd1725	refactor: add PHP 8.3 types to BC-safe class constants PHP 8.3 allows class constants to declare a type. Adopt it where doing so cannot break third-party apps. Typing an inheritable constant is a hard BC break: a subclass that redeclares it untyped fails to load with "Type of C::FOO must be compatible with P::FOO of type string". Changes are therefore limited to constants that cannot be redeclared by a subclass: - private const (not inherited) - final public/protected const - constants declared in a final class or an enum Interface constants, trait constants, and public/protected constants in non-final (including abstract) classes are left untyped, as is all of lib/public (OCP) and lib/unstable (NCU). One review-requested exception: the public OBJECT_PREFIX/OBJECT_SUFFIX constants of the app-internal CalDAV import helpers (TextImporter, XmlImporter) are typed as well; these classes are not public API and have no subclasses. Only string, int and array are used. float is avoided because it would silently coerce an int literal and change === comparisons. No constant name or value is modified: every changed line adds only the type token, so runtime behaviour is unchanged. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	1 week ago
Carl Schwan	7629df9c6b	fix(preview): Handle unique constraints violation exception Delete the preview from storage and fetch the actual one from the DB. This should not happen often. Signed-off-by: Carl Schwan <carlschwan@kde.org>	1 month ago
Côme Chilliet	1ab09ec753	chore: Apply new coding standard to all files The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines To see only the changes not related to blank lines. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Ferdinand Thiessen	e0ba4d71b6	chore: add missing `Override` attribute to `OC` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 months ago
provokateurin	fe9e43c165	feat(preview): Expire previews Signed-off-by: provokateurin <kate@provokateurin.de>	6 months ago
Anna Larch	99a1150ec2	fix(snowflake): cast lastId to int Signed-off-by: Anna Larch <anna@nextcloud.com>	6 months ago
Anna Larch	5f797ebc32	refactor: move existing usages of snoflake IDs SnowflakeAwareEntity Signed-off-by: Anna Larch <anna@nextcloud.com>	8 months ago
Anna Larch	f546daada7	refactor: Rename Snowflake Generator and Decoder And introduce the Snowflake DTO Signed-off-by: Anna Larch <anna@nextcloud.com>	8 months ago
Carl Schwan	06b6a5bc05	fix(preview): Correctly insert preview version Use createNamedParameter otherwise values are not correctly escapted. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	8 months ago
Carl Schwan	336cc3fa35	feat(Db): Use SnowflakeId for previews Allow to get an id for the storing the preview on disk before inserting the preview on the DB. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	10 months ago
Carl Schwan	bef3996c3e	fix(preview): Make version column a string And move it to a different table so that we don't have to pay the storage cost when not using it (most of the times). Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	66f50bd585	refactor(preview): Use same mimetype ids as filecache Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	58023782b6	feat(preview): Store original file mimetype in preview table Allow to quickly query all the files from a specific mimetype like in the ResetRenderedTexts command. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	324b54b863	refactor(preview): Cleanup the implementation of the new preview backend Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	6f56dcf73e	fix(preview): Fix some tests Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	b0357663b9	perf(preview): Optimize migration and simplify DB layout * Simplify migration by not moving the actual files and just updating the DB * Don't store the storageid in the preview table as it is not needed * Start adding tests Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	bba9667882	perf(preview): Adapt BackgroundCleanupJob to new previews table Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	18fbacdd8d	perf(preview): Split preview data to new table The new oc_previews table is optimized for storing previews and should decrease significantly the space taken by previews in the filecache table. This attend to reuse the IObjectStore abstraction over S3/Swift/Azure but currently only support one single bucket configuration. Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>	11 months ago

23 Commits (231ec6717cf77ebce4e55a2abd12e40ab9995430)