nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Git'Fellow	54bbb32f4a	fix(preview): qualify the ambiguous columns in PreviewMapper queries joinLocation() joins previews (p) with preview_locations (l) and preview_versions (v). Both previews and preview_versions have a file_id column, so any unqualified file_id condition is ambiguous and MySQL or MariaDB reject the query with error 1052. getPreviewForSpecification() built its conditions straight from the caller's array keys, so this broke every preview save: savePreview() uses that lookup to recover the existing row after a unique constraint violation. getByFileId() had the same unqualified condition, while getAvailablePreviewsForFile() next to it already used p.file_id. Columns that come from the joined tables keep resolving to their own alias, and keys that already carry one are passed through untouched. The values are bound with an explicit type as well. An untyped false binds as an empty string, which PostgreSQL rejects for a boolean column, so qualifying the columns on their own only moved the error on that backend. Fixes: https://github.com/nextcloud/server/issues/63229 Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	6 days ago
Ferdinand Thiessen	e5b1799079	chore: add missing `Override` attribute to test files Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 months ago
Benjamin Gaussorgues	71aa36860f	chore(tests): check Snowflake ID preserved in 32 bits Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	5 months ago
Joas Schilling	5f80f26799	chore: Fix SPDX header Signed-off-by: Joas Schilling <coding@schilljs.com>	5 months ago
Carl Schwan	7c1a8a4060	feat: Adapt a bit the snowflake ids API - Rename setId() -> generateId() in SnowflakeAwareEntity Signed-off-by: Carl Schwan <carlschwan@kde.org>	8 months ago
Anna Larch	5f797ebc32	refactor: move existing usages of snoflake IDs SnowflakeAwareEntity Signed-off-by: Anna Larch <anna@nextcloud.com>	8 months ago
Anna Larch	f546daada7	refactor: Rename Snowflake Generator and Decoder And introduce the Snowflake DTO Signed-off-by: Anna Larch <anna@nextcloud.com>	8 months ago
Ferdinand Thiessen	b2ffff385a	chore(tests): cleanup previews in teardown Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	10 months ago
Carl Schwan	336cc3fa35	feat(Db): Use SnowflakeId for previews Allow to get an id for the storing the preview on disk before inserting the preview on the DB. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	10 months ago
Ferdinand Thiessen	d6d6747a73	refactor: apply rector rules for PHPUnit 10 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	10 months ago
Carl Schwan	bef3996c3e	fix(preview): Make version column a string And move it to a different table so that we don't have to pay the storage cost when not using it (most of the times). Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	66f50bd585	refactor(preview): Use same mimetype ids as filecache Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	58023782b6	feat(preview): Store original file mimetype in preview table Allow to quickly query all the files from a specific mimetype like in the ResetRenderedTexts command. Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	324b54b863	refactor(preview): Cleanup the implementation of the new preview backend Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	6f56dcf73e	fix(preview): Fix some tests Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Carl Schwan	b0357663b9	perf(preview): Optimize migration and simplify DB layout * Simplify migration by not moving the actual files and just updating the DB * Don't store the storageid in the preview table as it is not needed * Start adding tests Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago

16 Commits (231ec6717cf77ebce4e55a2abd12e40ab9995430)