nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Joas Schilling	87836472d3	Remove duplicate tests Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Joas Schilling	85a80b05ac	Unify the permission checking in one place only Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Roeland Jago Douma	f9f3e00d06	Fix sharing tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Daniel Calviño Sánchez	b2cc2d6023	Add "password" parameter to the response data of link shares Due to legacy reasons the password of link shares was returned in the "share_with" and "share_with_displayname" parameters of the response data. Now a proper "password" parameter is returned too; the old "share_with" and "share_with_displayname" parameters are kept, although deprecated, and they will be removed in a future version of Nextcloud. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	adf80aa8b3	Add sending the password by Talk for a link share to ShareAPIController Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	52cada951b	Check "note", "label" and "hide download" too in update share tests Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Bjoern Schiessle	feb9f72e8b	adjust unit tests Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	7 years ago
Roeland Jago Douma	abbb946bbb	Propegate hide download state in share provider Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Daniel Calviño Sánchez	4ed7131e26	Add support for room shares to ShareAPIController In some cases, the ShareAPIController requires explicit handling of each type of share (for example, to format a share for a DataResponse). Room shares are implemented in an external app (Nextcloud Talk), so in order to keep the controller as isolated as possible from room share specifics all that explicit handling is done in a helper class provided by the Talk app. In other cases it is just enough to call the share manager specifying a room share type; note that the share manager is guarded against share types for which there is no provider, so it is not necessary to explicitly check that before passing room shares to the share manager. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	7849630cef	Add support for sending the password by Talk to ShareAPIController Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Bjoern Schiessle	e951ad5034	fix unit tests Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	8 years ago
Bjoern Schiessle	fa44300016	unit tests updated Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	8 years ago
Daniel Calviño Sánchez	243df99fcf	Fix formatting of email and circle shares Due to a misplaced "\|\|" instead of "===" the condition was always met, so every share type in the conditional chain after the remote and remote group shares was formatted as a remote/remote group share. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	6cb2cb33ac	Fix getting the information of group share as a sharee When the receiver of a group share modifies it (for example, by moving it to a different folder) the original share is not modified, but a "ghost" share that keeps track of the changes made by that specific user is used instead. By default, the method "getShareById" in the share provider returns the share from the point of view of the sharer, but it can be used too to get the share from the point of view of a sharee by providing the "recipient" parameter (and if the sharee is not found then the share is returned from the point of view of the sharer). The "ShareAPIController" always formats the share from the point of view of the current user, but when getting the information of a specific share the "recipient" parameter was not given, so it was always returned from the point of view of the sharer, even if the current user was a sharee. Now the "recipient" parameter is set to the current user, and thus the information of the share is returned from the point of view of the current user, be it the sharer or a sharee. Note that this special behaviour of "getShareById" happens only with group shares; with other types of shares the share is the same for the sharer and the sharee, and thus the parameter is ignored; it was added for them too just for consistency. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Maxence Lange	0009adae80	SharedWithDisplayName + SharedWithAvatar Signed-off-by: Maxence Lange <maxence@nextcloud.com> Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Roeland Jago Douma	4d5a2cce8d	Fix tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Roeland Jago Douma	b93d26a209	Replace ContactsManager Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Bjoern Schiessle	3285becdc1	fix unit tests Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	8 years ago
Morris Jobke	0eebff152a	Update license headers Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	c733cdaa65	Use ::class in test mocks of encryption app Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	ab36980d20	Use ::class in test mocks of dav app Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	43e498844e	Use ::class in test mocks Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	7eba0a2720	Fix comment Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Roeland Jago Douma	6e7865d05b	Update to new test case Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Joas Schilling	a0ada9aab4	Don't use deprecated getMock() anymore Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Thomas Müller	5bfce597a9	[CI] Can we get some faster phpunit execution? (#27113 ) * Don't backup globals and static attributes * Unset global variable to remove impact on followup tests Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Vincent Petry	377fdf3860	Skip null groups in group manager (#26871 ) (#26956 ) * Skip null groups in group manager (#26871) * Skip null groups in group manager * Also skip null groups in group manager's search function * Add more group null checks in sharing code * Add unit tests for null group safety in group manager * Add unit tests for sharing code null group checks * Added tests for null groups handling in sharing code * Ignore moveShare optional repair in mount provider In some cases, data is inconsistent in the oc_share table due to legacy data. The mount provider might attempt to make it consistent but if the target group does not exist any more it cannot work. In such case we simply ignore the exception as it is not critical. Keeping the exception would break user accounts as they would be unable to use their filesystem. * Adjust null group handing + tests * Fix new group manager tests Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Arthur Schiwon	b4d779977a	fix tests Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	9 years ago
Vincent Petry	14256d631c	Use group display name in sharing API + UI	9 years ago
Roeland Jago Douma	965981486f	Fixes not allowed increasing of link share permissions Fixes the following: 1. user0 shares folder with user1 (RO but with sharing permissions) 2. user1 shares by link 3. user1 send 'publicUpload=true' OCS request to the link share before this increased the permissions of the link share. Which should not happen. now: API reponds with an error that the permissions can't be increased. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Bjoern Schiessle	392c8a115f	unified way to display remote shares and mail shares Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	9 years ago
Roeland Jago Douma	ea07bbc562	Move Share20OCS to ShareAPIController It was already a controller just still residing in its old location. * Moved ShareAPIController to user plain userID instead of user object * Moved Share20OCS to ShareAPIController * Removed initisation of class from Application.php and leave it to the AppFramework * Fixed tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Roeland Jago Douma	56d37e27bc	Fix tests	9 years ago
Vincent Petry	fb52b1af67	Allow increasing permissions for share owner In some cases, the owner of the share is also recipient through a group share. The owner must still be able to increase permissions in that situation.	9 years ago
Roeland Jago Douma	fda4241dfb	Cleanup Tests	10 years ago
Roeland Jago Douma	af074eb2b7	Move updateShare and getShares over to use proper parameters * Update tests	10 years ago
Roeland Jago Douma	22e23f3045	Use parameters in createShare * Fix tests	10 years ago
Roeland Jago Douma	4006763f5b	Move the Share20OCS code over to use the proper DataResponse	10 years ago
Roeland Jago Douma	0556e40d3e	Fix tests	10 years ago
Joas Schilling	813f0a0f40	Fix apps/	10 years ago
Roeland Jago Douma	db559e33be	Fix PHPUnit 5.4 warnings in files_sharing tests	10 years ago
Vincent Petry	955635c7aa	Add explicit delete permission to link shares Link shares always allowed deletion, however internally the permissions were stored as 7 which lacked delete permissions. This created an inconsistency in the Webdav permissions. This fix makes sure we include delete permissions in the share permissions, which now become 15. In case a client is still passing 7 for legacy reasons, it gets converted automatically to 15.	10 years ago
Roeland Jago Douma	2e2ece753f	Fix unit tests	10 years ago
Lukas Reschke	aba539703c	Update license headers	10 years ago
Joas Schilling	3f0b2d148d	Move tests to PSR-4	10 years ago
Björn Schießle	7b25839bd5	use share initiator as fall back to access the file in case of federated re-shares the owner can be a remote user. Therefore we can't always use to owner to access the local file	10 years ago
Roeland Jago Douma	62bc53143e	Add locking to modifying operation of the OCS Share API Fixes #17243 This is done in the OCS Share API instead of the share manager since we want lazy shares in general. However when doing modifying calls via the OCS Share API it is fine to force real nodes. * Updated unit tests to work with logging	10 years ago
Roeland Jago Douma	5e9b618604	Translate OCS Share API error messages For https://github.com/owncloud/core/issues/22209	10 years ago
Roeland Jago Douma	db0c3bd535	Fix Share20OCSTest	10 years ago
Roeland Jago Douma	00f48ec37b	When the Share API is disabled do not return shares Fixes #22668 Block everything in the OCS Share API	10 years ago

34 Commits (2364fc84d78df931c5fc020f7fd052d980f8a7bb)