241 Commits (2bc77a3c5aff352cdc19aa683bbb36da2ff20b01)

Author	SHA1	Message	Date
invario	ba51caf5f4	Fix(previews): prevent infinite loop in case of bad video file ... Signed-off-by: invario <67800603+invario@users.noreply.github.com>	4 months ago
invario	97a0dde160	feat(previews): previews and tests for large remote videos w/o full download ... Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: invario <67800603+invario@users.noreply.github.com>	4 months ago
provokateurin	4b2a93cf0a	chore(Preview): Remove avconv support ... Signed-off-by: provokateurin <kate@provokateurin.de>	5 months ago
Ferdinand Thiessen	5981b7eb51	chore: apply new CSFixer rules ... Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php	6 months ago
Arthur Schiwon	bdc68989d5	fix: unbloc ffmpeg on some broken videos ... Co-authored-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	8 months ago
AndyXheli	ecd1d5dde2	fix(previews): lower log level when cached preview isn't found ... Since this PR #52221 was implemented, the log file has been flooded with warnings stating, "Cached preview not found for file; generating a new preview." This appears to be more of an informational message rather than a warning. This PR will change it from warning to debug Original PR #52221 Signed-off-by: AndyXheli <andyxheli@gmail.com>	8 months ago
Louis Chemineau	867be352f3	fix(blurhash): Use preview API to generate the previews ... This allows to benefit from all the checks done by the preview API. This also use the newly introduced `cacheResult` argument to limit disk usage. Signed-off-by: Louis Chemineau <louis@chmn.me>	8 months ago
Louis Chemineau	2238548278	feat(previews): Support in memory preview request ... This allows callers to use the API without increasing the disk usage. Example: blurhash generation, where we request a preview for all uploaded pictures, but don't want to necessarily store that preview. Signed-off-by: Louis Chemineau <louis@chmn.me>	8 months ago
ailkiv	616716cd6a	refactor: cleanup rollback hook usage ... Signed-off-by: ailkiv <a.ilkiv.ye@gmail.com>	9 months ago
nfebe	d980e69f74	refactor: Thumbnail Generator logging and tests ... Signed-off-by: nfebe <fenn25.fn@gmail.com>	9 months ago
Misha M.-Kupriyanov	4a924bf400	fix(previews): avoid large file downloads for remote movie storage ... Prevent downloading entire movie files from remote storage (e.g., S3) when the 'moov atom' is located at the end of the file. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>	9 months ago
nfebe	6b89838cc2	feat: add logging to preview generation ... Signed-off-by: nfebe <fenn25.fn@gmail.com>	9 months ago
Côme Chilliet	3ca690a9f3	fix(previews): Cleanup Movie provider code and remove deprecated static vars ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	9 months ago
Côme Chilliet	85934d4d79	fix(preview): Fix constructor parameter name and default value ... This should fix tests for movie preview provider Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	9 months ago
invario	eb3ca406f8	feat(previews): fix casing and comments ... Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: invario <67800603+invario@users.noreply.github.com>	9 months ago
invario	91e2f05ee6	feat(previews): Clean up code for HDR video previews ... Signed-off-by: invario <67800603+invario@users.noreply.github.com>	9 months ago
invario	e3008d08be	feat(previews): Use proper colorspace and apply tonemap for HDR videos ... Signed-off-by: KT <invario@gmail.com>	9 months ago
Dario Mehlich	8c309130cf	fix(preview): Filter for folders in cleanup old preview job ... Fixes #35936. When running `OC\Preview\BackgroundCleanupJob`, the main iteration loop in `run()` expects a folder, however, `getOldPreviewLocations()` currently does not filter by mimetype and therefore can yield a non-folder entry which causes an Exception when constructing the Folder impl. Filtering for `httpd/unix-directory`, as `getNewPreviewLocations()` already does, fixes this issue. Signed-off-by: Dario Mehlich <d.mehlich@gmail.com>	12 months ago
Josh	37a9460b06	chore(Previews): make thumbnail generation more robust ... Signed-off-by: Josh <josh.t.richards@gmail.com>	1 year ago
Git'Fellow	c254855222	chore(db): Correctly apply query types ... fix: psalm fix: error fix: add batch fix: fatal error fix: add batch chore: add batch chore: add batch fix: psalm fix: typo fix: psalm fix: return bool fix: revert Manager	1 year ago
provokateurin	54ec472d9a	fix(BackgroundJobs): Adjust intervals and time sensitivities ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
provokateurin	9836e9b164	chore(deps): Update nextcloud/coding-standard to v1.3.1 ... Signed-off-by: provokateurin <kate@provokateurin.de>	1 year ago
Thomas Citharel	c2150bd079	feat: Add mimetype into BeforePreviewFetchedEvent event ... Signed-off-by: Thomas Citharel <tcit@tcit.fr>	1 year ago
Richard Steinmetz	bcf9f91893	fix(preview): gracefully handle file not being opened in ProviderV2 ... Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>	1 year ago
Robin Appelman	da59fd4389	fix: misc code fixes around db sharding ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Robin Appelman	b21a399d1a	fix: implement sharding compatible cleanup for various bits ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	1 year ago
ernolf	a8bdd4f99b	feat(preview): move previews for imaginary pdf to own class ImaginaryPDF ... Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com> Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	1 year ago
Robin Appelman	5ea972922b	fix: explicitly filter for storageid in preview cleanup job ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Daniel Kesselberg	37454eb200	feat: log file id and path when extracting the mp3 cover fails ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
Andy Scherzinger	dae7c159f7	chore: Add SPDX header ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
Joas Schilling	4286660983	fix: Extend SVG reference check ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2 years ago
Côme Chilliet	672923f0a6	fix: Fix newly spotted psalm issues, add exhaustive typed magic properties for LDAP classes ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Varun Patil	4ab40e355f	fix(preview): check mime type before processing with Imagick ... Signed-off-by: Varun Patil <varunpatil@ucla.edu>	2 years ago
Côme Chilliet	ec5133b739	fix: Apply new coding standard to all files ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Git'Fellow	6f4d0fe79c	Lower failed movie preview to info ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	2 years ago
Joas Schilling	aa5f037af7	chore: apply changes from Nextcloud coding standards 1.1.1 ... Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Git'Fellow	ef5f7d0a90	Us strpos() only ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	2 years ago
Git'Fellow	53b84732a3	Check for open_basedir before reading /proc ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	2 years ago
Daniel Kesselberg	475dd60354	fix: use png as preview right away ... The initial office preview implementation converted an office document with LibreOffice to PDF, used ImageMagick to extract the first page as JPEG, and passed it OC_Image. https://github.com/nextcloud/server/pull/10198 changed the implementation to use PNG rather than PDF. OC_Image can use a PNG as a preview right away, so the ImageMagick step is unnecessary. The registration code was updated to not ask ImageMagick if PDF is supported, as PDFs are no longer used to create office document previews. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
Daniel Kesselberg	b5241d5220	feat: allow multiple libreoffice invocations ... LibreOffice only allows one invocation per user profile.[^1] The office provider set the user profile to /tmp/owncloud-instanceid and therefore only one invocation per instance is allowed. This was introduced a while ago, yet it's unclear if this was intentionally or just a side effect.[^2] The limitation on one invocation leads to the situation that the preview generation only works for a couple of files if you upload a whole folder of emf or word files. This commit removes the limitation by using a new user profile for each preview. That's done by using instance id plus file id as postfix for getTemporaryFolder. This has some drawbacks: - Overload protection: If you upload 100 emf files, you may end up with 100 LibreOffice invocations. Though, you can use preview_concurrency_new to limit the number of previews that can be generated concurrently when php-sysvsem is available. - New profile: I assume it takes a few bits to generate a fresh LibreOffice user profile. It appears that there is no way to ask LibreOffice to not create a profile and just work with the defaults. The profile will be cleaned after use by our temp manager. - Remove the configuration option preview_office_cl_parameters: This is not strictly necessary yet, but if you set the configuration option, the generated path for the user profile is also missing. The configuration option is not well documented (e.g., it's unclear that the last option needs to be --outdir) and actually, there should be no reason to change it after all. [^1]: https://wiki.documentfoundation.org/UserProfile [^2]: https://github.com/owncloud/core/pull/9784 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
Daniel Kesselberg	aa48a5f94f	feat: add preview provider for emf files based on office ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
Simon L	b681cf735a	address review ... Signed-off-by: Simon L <szaimen@e.mail.de>	2 years ago
Simon L	531f5d1e4f	fix semaphore guarding ... Signed-off-by: Simon L <szaimen@e.mail.de>	2 years ago
Git'Fellow	d1169af129	Use \Throwable instead ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	2 years ago
Git'Fellow	624986a6d5	Catch Imaginary processing errors ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	2 years ago
Git'Fellow	974e86e618	Don't pass invalid streams to Imaginary ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Update Imaginary.php Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Update Imaginary.php Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	2 years ago
Akhil	1d767ebff5	Check if the node has a null ID before deleting in preview watcher ... Signed-off-by: Akhil <akhil@e.email>	2 years ago
Daniel Hansson	da2aad598e	also remove function ... Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>	2 years ago
Daniel Hansson	b2d105e7ec	Generate all preview sizes for Imaginary ... A follow up on https://github.com/nextcloud/server/pull/40670 Based on discussions here: https://github.com/nextcloud/server/issues/38911#issuecomment-1741819188 This fixes the case were not all previews are generated, for example in the activity view: https://github.com/nextcloud/server/issues/38911#issuecomment-1738886106 Signed-off-by: Daniel Hansson <mailto@danielhansson.nu>	2 years ago