nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Git'Fellow	07a6fd11d0	fix(files_external): Check key exists before accessing it Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	1 year ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	1 year ago
Robin Appelman	c2b1f079b1	feat: add a specialized writeStream implementation for s3 external storage Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Daniel Calviño Sánchez	733e3f62fd	fix: Do not log an error when connecting to SFTP without a logged in user When connecting to a SFTP server from a SFTP storage the host key is checked against the known host keys stored in a file in the data directory of the logged in Nextcloud user. The path to the file is (indirectly) got using "OC_App::getStorage", which logs an error if called when there is no logged in user; this can happen, for example, if the storage is used from a background job or a command. Not being able to read or write the file just causes the host key check to be skipped, but it has no other consequence. Moreover, even with logged in users it is likely that the file can not be read either and the check is also skipped, as the file needs to have been manually created by an admin. Due to all that now the path to the file is directly created using a View rather than relying on "OC_App::getStorage" to prevent the unneeded error from being logged. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	2 years ago
Andy Scherzinger	c1555fc33e	chore: Add SPDX header Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
Côme Chilliet	4d060818d1	fix(files_external): Be extra safe with null handling to please psalm Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Côme Chilliet	72a0da6d4e	fix: Fix small psalm errors in FTP and LDAP connections Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Côme Chilliet	0f348516d2	fix: Remove obsolete resource typing In PHP>=8.1, LDAP and FTP resources are always typed objects Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Côme Chilliet	ec5133b739	fix: Apply new coding standard to all files Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
John Molakvoæ	524ed97d62	fix: replace `Account name` by `Login` Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>	2 years ago
Vincent Petry	839ddaa354	feat: rename users to account or person Replace translated text in most locations Signed-off-by: Vincent Petry <vincent@nextcloud.com>	2 years ago
Benjamin Gaussorgues	2cb0bf5437	fix(files_external): list root when using SMB case-insensitive option Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Joas Schilling	aa5f037af7	chore: apply changes from Nextcloud coding standards 1.1.1 Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Louis Chemineau	e66e8bad1a	Return correct status if touch failed Signed-off-by: Louis Chemineau <louis@chmn.me>	2 years ago
Benjamin Gaussorgues	a45e12abc8	fix(files_external): on case insensitive system, block case change When a file/directory is renamed to the same name with only case change, the rename fail. We block this kind of rename. The user will have to rename to another name first. Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Robin Appelman	eab8dd3ca0	use multipart copy for s3 Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	b40fa64a8b	use multipart copy for s3 Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	d42d809170	sftp psalm fixes Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	c264903cb9	psalm suppress Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	aa2a3ae6c8	implement fseek for sftp read stream Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	b41c8e0ef5	more optimized getPermissions/getMetaData Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	1dfef9fccf	sftp optimize file_put_contents, writeStream and copy Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	9cf732a90b	fix error during sftp stream close Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	19daa70947	clear sftp stat cache when opening a write stream Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Benjamin Gaussorgues	9b03dc52a4	Migrate files external to PSR LoggerInterface Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Robin Appelman	7c9edbff32	handle more exceptions in AmazonS3::fopen Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Josh Richards	e7cbaf3ee3	Clean-up some remaining readdir calls with undesirable false evaluation potential Signed-off-by: Josh Richards <josh.t.richards@gmail.com>	3 years ago
Christoph Wurst	b8c61b3515	fix(caching): Avoid checking existence before fetching The cache might expire between checking for key existence and fetching the value. In this rare case the code continues with a null value when it doesn't expect one. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	3 years ago
Faraz Samapoor	94f2f57519	Update apps/files_external/lib/Lib/Storage/SMB.php Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>	3 years ago
Faraz Samapoor	cfb921b26c	Refactors "strpos" calls in /apps/files_external to improve code readability. Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>	3 years ago
James Guo	bb173e092b	Update AmazonS3.php Signed-off-by: James Guo <i@ze3kr.com>	3 years ago
Robin Appelman	b1f352c614	improve handling of files we can't access in the scanner instead of erroring, remove the items from the cache. this situation can be triggered if a user has access to a file but looses it afterwards Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Robin Appelman	fd0ef588b4	fix ftp external storage with filezilla server - filezilla doesn't like "" as parameter for `mdtm` (all others seem fine) - filezilla sends fractional modified date Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Côme Chilliet	308fcf4526	Respect OCP interface in private classes Because the parameter type was moved to phpdoc it needs to be removed from implementations Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	ff776a90b1	Strong type filesize related methods to ease 32bits problem findings Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
François Ménabé	710f3fd405	Support of s3 storage class in External Storage application Signed-off-by: François Ménabé <francois.menabe@gmail.com>	3 years ago
Côme Chilliet	9430899f16	Fix psalm issues related to signature changes from PHP 8.0 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Robin Appelman	ed8fedc685	fix s3 directory copy Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Côme Chilliet	9ba9f9a7dc	Make sure to not pass null to DateTime::createFromFormat Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Carl Schwan	a5ea677370	Rename file1 and file2 to source and target in Storage abstraction Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Carl Schwan	732badf552	Additional type hinting found by psalm Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Carl Schwan	c2c63a551f	Fix usage of streams always return a bool and type the handle as a string Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Carl Schwan	74e6976779	Use argument name from parent class This will be an issue with php 8, so best to fix it now Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Carl Schwan	cf1381a6f9	Port away from deprecated clearBucket call This was removed a long time ago in the library that we use, but never detected since this was inside a try catch block... Remove the call for now and we should investigate newer api in the future. Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Carl Schwan	1d90f84141	Port to LoggerInterface Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Carl Schwan	ff4c8e9bee	Force cast getCode to int Otherwise psalm complains that the type can also be a non-falsy-string Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Matthieu Gallien	54c05bcdb9	handle AccessDenied error when checking if external s3 support versions Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>	4 years ago
Carl Schwan	d5c23dbb9f	Move CappedMemoryCache to OCP This is an helpful helper that should be used in more place than just server and this is already the case with groupfodlers, deck, user_oidc and more using it, so let's make it public Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	ec6b83cc18	Add stricter psalm type for CappedMemoryCache Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Carl Schwan	f945c0cbc6	Add a public replacement for OC::$server->get Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago

1 2 3 4 5 ...

252 Commits (2bdc97741cd42843f85750421cba032942d860ed)