56 Commits (2bdc97741cd42843f85750421cba032942d860ed)

Author	SHA1	Message	Date
Christoph Wurst	49dd79eabb	refactor: Add void return type to PHPUnit test methods ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	1 year ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	1 year ago
Louis Chemineau	dff8815449	feat(users): Add support for admin delegation for users and groups management ... Signed-off-by: Louis Chemineau <louis@chmn.me>	1 year ago
Joas Schilling	047479ccf9	feat(security): Add public API to allow validating IP Ranges and checking for "in range" ... Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	1 year ago
Benjamin Gaussorgues	202e5b1e95	feat(security): restrict admin actions to IP ranges ... Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	1 year ago
Andy Scherzinger	1f7e2ba599	chore: Add SPDX header ... Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
Benjamin Gaussorgues	7a6b1f8ae8	fix(groups): allows to save group names with more than 64 characters ... Mimic behaviour from LDAP users and add a hard limit to 255 characters Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Joas Schilling	aa5f037af7	chore: apply changes from Nextcloud coding standards 1.1.1 ... Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Carl Schwan	3270b7f12e	Add batch methods in user backends ... This allows for faster group search with significantly less DB traffic Signed-off-by: Carl Schwan <carl@carlschwan.eu>	2 years ago
Joas Schilling	80f79e170d	fix!: Remove symfony EventDispatcherInterface from Group ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2 years ago
Joas Schilling	ad12a740cb	fix!: Remove symfony EventDispatcherInterface from User ... Signed-off-by: Joas Schilling <coding@schilljs.com>	2 years ago
Côme Chilliet	10296ba7e5	Fix tests, and fix Group::searchUsers to avoid duplicates ... Also went back to searchUsers indexing the array by uid as it was the previous behavior and the IGroup phpdoc does not say anything about the keys. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	b6c17c6ce7	Clear up return types ... usersInGroup index by int for BC, searchInGroup index by uid (string). Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Carl Schwan	35dc223500	Optimize retrieving display name when searching for users in a group ... This is recurrent scenario that we are searching for users and then for each users we fetch the displayName. This is inefficient, so instead try to do one query to fetch everything (e.g. Database backend) or use the already existing DisplayNameCache helper. Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 years ago
Côme Chilliet	f5c361cf44	composer run cs:fix ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Anna Larch	7c4ceb444c	Add group display name cache ... Signed-off-by: Anna Larch <anna@nextcloud.com>	3 years ago
Côme Chilliet	61f7f13bd8	Migrate from ILogger to LoggerInterface where needed in the tests ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	4 years ago
Roeland Jago Douma	68ec18323d	Fix types in the Group Manager ... Psalm found an issue. However the issue found was because of lying docblocks. Fixed those and did some typing to make it all better. For #25839 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
dependabot-preview[bot]	eb502c02ff	Bump nextcloud/coding-standard from 0.3.0 to 0.5.0 ... Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	d9015a8c94	Format code to a single space around binary operators ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Morris Jobke	234b510652	Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Robin Appelman	aa83b0b22d	dont get the group details if we only ask for the id ... currenty when getting the groups for a user, the full group object is always created (and cached) even if only the groupid is required Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function ... To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	3a415e4139	Remove space between switch case and colon ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	afbd9c4e6e	Unify function spacing to PSR2 recommendation ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2fbad1ed72	Fix (array) indent style to always use one tab ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	85e369cddb	Fix multiline comments ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	b80ebc9674	Use the short array syntax, everywhere ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2ee65f177e	Use the shorter phpunit syntax for mocked return values ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	74936c49ea	Remove unused imports ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Roeland Jago Douma	3a7cf40aaa	Mode to modern phpunit ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	c007ca624f	Make phpunit8 compatible ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Arthur Schiwon	7b1eedb11e	take group creation result into consideration ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	6 years ago
Roeland Jago Douma	68748d4f85	Some php-cs fixes ... * Order the imports * No leading slash on imports * Empty line before namespace * One line per import * Empty after imports * Emmpty line at bottom of file Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Joas Schilling	01b4db62fb	Add dispatcher events to User and Group objects ... Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
John Molakvoæ (skjnldsv)	0f84351a76	Tests fix ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	720e64ba55	Fixed caldav tests and metadata 2 ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	d80f13ef99	Fix Metadata tests ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Joas Schilling	bf2be08c9f	Fix risky tests without assertions ... Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago
Morris Jobke	43e498844e	Use ::class in test mocks ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Roeland Jago Douma	b930f32e89	Remove legacy OC_User_Backend and OC_User_Interface ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Joas Schilling	80d2717e5c	Fix 5.6 duplicate class import ... Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Joas Schilling	ebabf81473	Clean up the test ... Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Joas Schilling	bd97b7d130	Use DI ... Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Vincent Petry	377fdf3860	Skip null groups in group manager (#26871) (#26956) ... * Skip null groups in group manager (#26871) * Skip null groups in group manager * Also skip null groups in group manager's search function * Add more group null checks in sharing code * Add unit tests for null group safety in group manager * Add unit tests for sharing code null group checks * Added tests for null groups handling in sharing code * Ignore moveShare optional repair in mount provider In some cases, data is inconsistent in the oc_share table due to legacy data. The mount provider might attempt to make it consistent but if the target group does not exist any more it cannot work. In such case we simply ignore the exception as it is not critical. Keeping the exception would break user accounts as they would be unable to use their filesystem. * Adjust null group handing + tests * Fix new group manager tests Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Morris Jobke	a5ba1f7803	Remove legacy class OC_Group and OC_User ... * basically a straight replacement of the wrapped code at the calling code parts Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Arthur Schiwon	91a1e5fd9d	fix more tests ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	9 years ago
Vincent Petry	453f3beffa	Adding group display name support	9 years ago
Roeland Jago Douma	28c801b3d5	Fix getMock MetaDataTest	9 years ago
Roeland Jago Douma	5b6f5f1a07	LegacyGroupTest need DB ... Those old tests make it impossible in the current state to abstract away.	10 years ago