161 Commits (2d9fee1b4c9cc684ccaaace60bb5c91c8a7c2d7e)

Author	SHA1	Message	Date
Carl Schwan	00a9b0c1db	Fix permissions when copying from ObjectStorage ... Make sure that when a user copy a file from a directory they don't have all permissions to a directory where they have more permissions, the permissions are correctly set to the one from the parent taget folder. This was caused by the ObjectStoreStorage::copyFromStorage using the jailed storage and cache entry instead of the unjailed one like other storages (the local one). Steps to reproduce + Use object storage + Create a groupfolder with one group having full permission and another one who can just read files. + With an user who is in the second group, copy a file from the groupfolder to the home folder of this user. + The file in the home folder of the user will be read only and can't be deleted even though it is in their home folder and they are the owner. In oc_filecache, the permissions stored for this file are 1 (READ) Signed-off-by: Carl Schwan <carl@carlschwan.eu>	4 years ago
Robin Appelman	f18a76fec9	s3 external storage listing rework ... Signed-off-by: Robin Appelman <robin@icewind.nl>	4 years ago
Daniel Kesselberg	dd9a08fa82	explicitly close source stream on object store upload even if countwrapper isn't needed ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	5 years ago
Julius Härtl	c16d5b1077	Reset checksum when writing files to object store ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
Florent	ede67149ea	Avoid reading ~/.aws/config when using S3 provider ... When using S3 storage, we sometimes have open_basedir errors due to aws-sdk-php trying to read ~/.aws/config which is out of open_basedir restrictions. Christoph Wurst already added csm=false config in #21406 but it wasn't enough, we also need to set use_arn_region=false, added in this commit. Signed-off-by: Florent <florent@coppint.com>	5 years ago
Robin Appelman	0532f64aa8	remove explicit fclose from S3->writeStream ... streams get closed automatically when dropped, and in some cases the stream seems to be already closed by the S3 library, in which case trying to close it again will raise an error Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	719db4cee9	use returned file id for object store copy ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Robin Appelman	6308267aff	apply object store copy optimization when 'cross storage' copy is within the same object store ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
James Letendre	74d90d0165	Fix failing tests ... Signed-off-by: James Letendre <james.letendre@gmail.com>	5 years ago
James Letendre	b65b2bbf55	Add web identity provider to S3 connection chain ... Signed-off-by: James Letendre <james.letendre@gmail.com>	5 years ago
James Letendre	5750d79181	Replace defaultProvider with explicit calls to exclude user home directory lookup ... Signed-off-by: James Letendre <james.letendre@gmail.com>	5 years ago
James Letendre	c9a724829a	Resolves #24699, Support ES2 and ECS instance providers for S3 buckets ... Signed-off-by: James Letendre <james.letendre@gmail.com>	5 years ago
Christoph Wurst	9ce3ea3368	Update license headers ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	73c7d0dc81	Bump icewind/streams from 0.7.1 to 0.7.2 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Tigran Mkrtchyan	4f2dc18f58	storage: update IStorage#file_put_contents docs to match usage ... The current phpdoc of IStorage#file_put_contents doesnt corresponds to it's actual usage in code, e.g. Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>	5 years ago
Christoph Wurst	d89a75be0b	Update all license headers for Nextcloud 21 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Robin Appelman	9d4848e863	use in objectstore copy ... Signed-off-by: Robin Appelman <robin@icewind.nl>	5 years ago
Roeland Jago Douma	65141d4864	Allow config to specify the bucket exists ... In the 99% case the bucket is just always there. And if it is not the read/write will fail hard anyways. Esp on big instances the Objectstore is not always fast and this can save a few hundered ms of each request that acess the objectstore. In short it is adding 'verify_bucket_exists' => false To the S3 config part Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	5 years ago
Christoph Wurst	d9015a8c94	Format code to a single space around binary operators ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Roeland Jago Douma	bb06b6cce4	Fix reading empty files from objectstorage ... Since we try to do range requests this will fail hard. However since empty files are not that interesting to read anyways we just read from an emptry memory stream. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	9fdeed8cc0	Run stat less often for objectstorages ... When we want to get the permissions we now do stat at least 5 times for each entry. Which is a bit much. Especially since the permssions are all just in the database already. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	789b33aba4	Only update the filecache entry once the file has been written to S3 ... If we already update before we have no way to revert if the upload fails. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	6ffd7173f9	Don't lose filecache entry on s3 overwrite error ... If the object store errors we should not always delete the filecache entry. As this might lead to people losing access to their files. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Christoph Wurst	2a054e6c04	Update the license headers for Nextcloud 20 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Stephen Cuppett	5ef0f86ce7	Resolves #19790, Provides Support for IAM Credentials ... Includes support for either leveraging environment variables passed to the PHP runtime or IAM instance profile present on the host being used. The default and first choice is still the parameter file as documented. See also: https://docs.aws.amazon.com/sdk-for-php/v3/developer-guide/guide_credentials_provider.html#chaining-providers Signed-off-by: Stephen Cuppett <steve@cuppett.com>	6 years ago
Morris Jobke	fedf9c69d9	Use matching parameter names form interfaces and implementations ... Found by Psalm 3.14.1 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Morris Jobke	438ac23e2a	Distribute preview folders in appdata in multibucket setup to multiple buckets ... * introduces a new IRootMountProvider to register mount points inside the root storage * adds a AppdataPreviewObjectStoreStorage to handle the split between preview folders and bucket number Ref #22033 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Christoph Wurst	d3a4bc91f7	Fix static method call for s3 bucket compat check ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Daniel Kesselberg	8aa99aa8ff	Update presign method to match with interface again. ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	6 years ago
Christoph Wurst	9d392891be	Disable Client-Side Monitoring on AWS storage ... The S3 client enables this by default and then tries to read `.aws/config`. This causes `open_basedir` restriction related error for some setups. So this patch disables the CSM because it's most likely unused anyway. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Florent	3594ba6971	Upload part size as S3 parameter instead of constant value ... Some S3 providers need a custom upload part size (500 MB static value in Nextcloud). Here is a commit to change this value via S3 configuration, instead of using S3_UPLOAD_PART_SIZE constant. A new parameter is added for an S3 connection : uploadPartSize Signed-off-by: Florent <florent@coppint.com>	6 years ago
Daniel Kesselberg	1ef77ef948	composer run cs:fix ... Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	6 years ago
Robin Appelman	4e6d3d1880	Fix getDirectoryContent implementation for Jail wrapper ... Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Roeland Jago Douma	f6b435d0d9	Run the cs fixer for green ci ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Christoph Wurst	cb057829f7	Update license headers for 19 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Adrian Brzezinski	e107519295	Large Object support for OpenStack Swift. ... Until now, you wouldn't be able to create objects larger that 5GB. It's somewhat related with pull #18883 Signed-off-by: Adrian Brzezinski <adrian.brzezinski@eo.pl>	6 years ago
Adrian Brzezinski	354c0996d8	It's a fix for issue #14116, ... Improves efficiency when downloading files from Swift storage. Before, files were downloaded and then pushed back to user. That behaevior causes all kinds of performance problems. Now, files are streamed directly to user. Signed-off-by: Adrian Brzezinski <adrian.brzezinski@eo.pl>	6 years ago
Robin Appelman	9735b5d61f	Add method to storage backends to get directory content with metadata ... Currently you need to use `opendir` and then call `getMetadata` for every file, which adds overhead because most storage backends already get the metadata when doing the `opendir`. While storagebackends can (and do) use caching to relief this problem, this adds cache invalidation dificulties and only a limited number of items are generally cached (to prevent memory usage exploding when scanning large storages) With this new methods storage backends can use the child metadata they got from listing the folder to return metadata without having to keep seperate caches. Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Julien Lutran	3e849daf11	Fix issues with Keystone auth v3 in files_external app ... Signed-off-by: Julien Lutran <julien.lutran@corp.ovh.com>	6 years ago
Christoph Wurst	734c62bee0	Format code according to PSR2 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	28f8eb5dba	Add visibility to all constants ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	1584c9ae9c	Add visibility to all methods and position of static keyword ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function ... To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	14c996d982	Use elseif instead of else if ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	44577e4345	Remove trailing and in between spaces ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	afbd9c4e6e	Unify function spacing to PSR2 recommendation ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	41b5e5923a	Use exactly one empty line after the namespace declaration ... For PSR2 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Robin Appelman	7b07e7251c	make seekable s3 stream generic ... Signed-off-by: Robin Appelman <robin@icewind.nl>	6 years ago
Lukas Stabe	14401efb0f	Enable fseek for files in S3 storage ... Signed-off-by: Lukas Stabe <lukas@stabe.de>	6 years ago
Christoph Wurst	1a9330cd69	Update the license headers for Nextcloud 19 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago