89 Commits (2e3517eb00a7eb40bc9202fa4548fc97a39ec52f)

Author	SHA1	Message	Date
Daniel Calviño Sánchez	cb20503341	Add Firefox profile with support for CSS grid to acceptance tests ... The acceptance tests are currently run on Firefox 47; in that version the CSS grid support was not enabled by default, but it could be enabled through a setting in the Firefox profile. By default Selenium uses a clean Firefox profile when a new session is started, but it also allows the customization of the profile through a zipped "user.js" file. The contents of that file have to be provided in the "firefox_profile" capability when the Firefox session is created. In the Mink extension for Behat several Mink sessions can be defined in the "behat.yml" file. Each Mink session uses a different browser session in Selenium, and each of those browser sessions is initialized with the capabilities provided in the "behat.yml" file. From the point of view of the acceptance tests each Mink session is an actor, so different actors can use different browsers with different capabilities. Due to all this a new actor was introduced, "Rubeus", who uses a Firefox browser that has CSS grid support; this actor is meant to be used only in those acceptance tests that require proper support for CSS grids. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	4341d8731e	Rename helper for PHP built-in web server ... For consistency with the helper for the Apache web server the helper for the PHP built-in web server was renamed too. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	aa96dfd173	Add helper to run acceptance tests on an Apache server ... The default and only helper to run acceptance tests run them on the PHP built-in web server. This commit introduces a new helper that can be used to run them on an Apache web server instead. This helper is meant to be used by the acceptance tests of apps that require a multi-threaded web server to run (like Talk, due to its use of long polling). To use the helper it is only needed to set it in the Behat configuration for the acceptance tests of the app, as explained in the "NextcloudTestServerContext" documentation. It is assumed that the acceptance tests are run using the default setup, and therefore inside a Docker container based on the image for acceptance tests from Nextcloud. Due to that the helper is expected to have root permissions, and thus it starts and stops the Apache web server directly using "service start/stop apache2". In the same way it also restores the owner and group for "apps", "config" and "data" to "www-data", as it is the user that Apache sub-processes are run as. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	ea21fe2dbc	Add support for setting the domain also when a specific helper is used ... Before, the domain was automatically added assuming that the NextcloudTestServerContext had no parameters defined in the Behat configuration. However, in order to use a helper for Apache it would need to be specified in the configuration with something like: - NextcloudTestServerContext: nextcloudTestServerHelper: NextcloudTestServerLocalApacheHelper The substitution now works both when a helper is specified and when it is not; note, however, that providing custom parameters to the helper is not supported, although they are not needed anyway so it is not really a problem. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	a09b787a01	Install and configure Nextcloud server as www-data ... Apache sub-processes are run as the www-data user, and they need to be able to write to the "apps", "config" and "data" directories, so they have to belong to that user, and therefore the Nextcloud server has to be installed and configured too as the www-data user. The PHP built-in web server will still be run as the root user, but in that case the owner of those directories makes no difference, so this is compatible with both cases. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	f6d34587a2	Use Docker image for acceptance tests ... The Docker image for acceptance tests provides support for both the PHP built-in web server and the Apache web server; the acceptance tests for the server are run on the PHP built-in web server, but the acceptance tests for some apps will have to be run on the Apache web server (for example, Talk, as it uses long polling), so a Docker image to support both cases has to be used in "run.sh". ".drone.yml" was just updated for consistency, although it was not really needed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	c8df4f5df4	Make possible to set the acceptance tests directory to use ... When the acceptance tests were run they were always loaded from the "tests/acceptance" directory of the Nextcloud server. Now it is possible to set the directory used to look for the Behat configuration and the Nextcloud installation script, which makes possible to run acceptance tests for the apps too instead of only for the server (although if no directory is explicitly given the tests for the server are the ones run). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	50d35bee9f	Add context classes to Composer autoload ... In order to autoload the server context classes the "bootstrap" directory was explicitly listed in Behat autoload configuration. This is fine in the configuration of acceptance tests for the server, but it would force the configuration of acceptance tests for the apps to explicitly include the path for the server context classes to be able to use them (for example, for the login step). Besides with its own configuration Behat also supports autoloading classes using Composer, so now context classes are autoloaded using Composer instead; thanks to this the server context classes are autoloaded also in the acceptance tests for apps without any explicit configuration in them. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Julius Härtl	5598d30ef1	Fix files acceptance test ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	8 years ago
Julius Härtl	bbeb3402b6	Move styling and menu handling to publicpage.js ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	8 years ago
Daniel Calviño Sánchez	c5cc1d80e6	Fix typo ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
John Molakvoæ (skjnldsv)	3d99a9d24e	Header acceptance features ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Daniel Calviño Sánchez	15c12eb027	Add acceptance tests for creation of subfolders in public shared folders ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	1a2d9a2fdd	Extract common "wait for" functions to a helper class ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	fcd6cf08e0	Generalize file list steps so a specific ancestor can be used ... The "FileListContext" provides steps to interact with and check the behaviour of a file list. However, the "FileListContext" does not know the right file list ancestor that has to be used by the file list steps, so until now the file list steps were explicitly wired to the Files app and they could be used only in that case. Instead of duplicating the steps with a slightly different name (for example, "I create a new folder named :folderName in the public shared folder" instead of "I create a new folder named :folderName") the steps were generalized; now contexts that "know" that certain file list ancestor has to be used by the FileListContext steps performed by certain actor from that point on (until changed again) set it explicitly. For example, when the current page is the Files app then the ancestor of the file list is the main view of the current section of the Files app, but when the current page is a shared link then the ancestor is set to null (because there will be just one file list, and thus its ancestor is not relevant to differentiate between instances) A helper trait, "FileListAncestorSetter", was introduced to reduce the boilerplate needed to set the file list ancestor from other contexts. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	766135cb64	Generalize file list locators so a specific ancestor can be used ... The file list is used in other places besides the Files app (for example, the File sharing app); in those cases the locators for the file list elements are the same, but not for the ancestor of the file list. To make possible to reuse the file list locators in those cases too now they receive the ancestor to use. Note that the locators for the file actions menu were not using an ancestor locator because it is expected that there is only one file actions menu at a time in the whole page; that may change in the future, but for the time being it is a valid assumption and thus the ancestor was not added to those locators in this commit. Although the locators were generalized the steps themselves still use the "FilesAppContext::currentSectionMainView" locator as ancestor; the steps will be generalized in a following commit. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	10490f2ac3	Store the name of the actor in the Actor object ... This is needed to be able to easily use the actor as a key in an array. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	49f2ba16f0	Extract file list locators and steps to its own class ... Besides the extraction some minor adjustments (sorting locators for file action menu entries to reflect the order of the menu entries in the UI, moving parametrized locators like "createMenuItemFor" above the locators that use them and placing "descendantOf" calls always in a new line) were made too. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	c1fa0f8b86	Add automatic handling of NoSuchElement exceptions ... NoSuchElement exceptions are sometimes thrown instead of StaleElementReference exceptions. This can happen when the Selenium2 driver for Mink performs an action on an element through the WebDriver session instead of directly through the WebDriver element. In that case, if the element with the given ID does not exist, a NoSuchElement exception would be thrown instead of a StaleElementReference exception, so those cases are handled like StaleElementReference exceptions. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	deb2495f89	Add automatic handling of MoveTargetOutOfBounds exceptions ... MoveTargetOutOfBounds exceptions are sometimes thrown instead of ElementNotVisible exceptions. This can happen when the Selenium2 driver for Mink moves the cursor on an element using the "moveto" method of the Webdriver session, for example, before clicking on an element. In that case, if the element is not visible, "moveto" would throw a MoveTargetOutOfBounds exception instead of an ElementNotVisible exception, so those cases are handled like ElementNotVisible exceptions. Note that MoveTargetOutOfBounds exceptions could be thrown too if the element was visible but "out of reach"; there is no problem in handling those cases as if the element was not visible, as the exception will be thrown again anyway once it is verified that the element is indeed visible. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
John Molakvoæ (skjnldsv)	2d4896e2a7	fixup! Acceptance fix ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	484568e995	Acceptance fix ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	907234fde2	Fix acceptance tests ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Julius Härtl	fd830b90eb	Fix acceptance test for new menu structure ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	8 years ago
Daniel Calviño Sánchez	81fdbc6554	Take into account the comment message when looking for it ... Instead of checking that the list contains one comment it is now checked that a comment with certain message is visible. This makes the step (and the locator) more reusable in future tests and also simplifies the code. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	0a2c98ac89	Adjust timeouts in the step to create a new comment ... Depending on the previous steps the new comment field may be already shown or not when the step to create a new comment is executed. Therefore, the timeout was increased from 2 to the "standard" 10 seconds used in other tests. If the new comment field was found there is no need to use a timeout when looking for the new comment button; it is either there or not, it will not appear after some time. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	28d5862643	Move locators above step definitions ... The locators are moved above the step definitions for consistency with other context files; besides that I made some minor adjustments for consistency too in the locator descriptions and identation, and moved the locators for ".newCommentRow" descendants together. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Robert Pirritano	a82c8f58cc	made small changes to login screen ... added height back 70px back to footer and removed .htaccess file Signed-off-by: Robert R Pirritano <rpirritano@gmail.com>	8 years ago
Daniel Calviño Sánchez	dab4a70bcf	Add acceptance test for renaming a file with the details view open ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	e24a1c51e8	Wait for the shared link to be set in the acceptance tests ... When clicking on "Share link" in the "Sharing" tab of the Files app an input field with the link appears. That input field already exists in the DOM, although empty, before clicking on "Share link", and when that is done the proper value is set and then the input field is shown. In the acceptance tests "getValue()" can return the value of hidden elements too, so as long as an element exists its value is returned without waiting for the field to be visible. Due to this if the test code runs too fast the "I write down the shared link" step could be executed before the proper value was set, so the shared link got in that case would be an empty value, and this would lead to failures when the following steps were executed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	8916735dd3	Add missing timeout multiplier ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	37238725d6	Fix typo in callback name ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	2ec181e084	Add acceptance test for opening the menu in a public shared link ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Abijeet	81f34e224c	Allows adding of hex color to the theme-color ... Fixes #7158. Adds a # on the color if missing. Increased maxlength, added hash:true for jscolor, and adding a # if not present on the change event. Since the input element now allows a hex code, changed values to hexcode. In addition, added a function to get RGB array from hex or rgb values. Calling it in both methods and using it to perform comparison. Also changed the way we were determining whether the jscolor component had loaded. Changed the control to use data-jscolor rather than defining opts in the class. Signed-off-by: Abijeet <abijeetpatro@gmail.com>	8 years ago
John Molakvoæ (skjnldsv)	15762c103b	Fix acceptance test ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Arthur Schiwon	5b4df0f320	bump acceptance test suite to use php 7.1 image ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	8 years ago
Arthur Schiwon	76c803f0af	add acceptance tests ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	8 years ago
Daniel Calviño Sánchez	065ab6bfff	Solve acceptance test failure due to clicks on covered elements ... Firefox and Chrome drivers for Selenium refuse to click on an element if the point to be clicked is covered by a different element, throwing an UnknownError exception with message "Element is not clickable at point ({x}, {y}). Other element would receive the click: {element}". Although in general that would be a legit error (as the user would not be able to click on the element) due to a bad layout, sometimes this can be just a temporal issue caused by an animation, in which case there would be no problem once the animation finished and the elements are all in their final location. Unfortunately, automatically handling those situations in which the problem is caused by an animation by just retrying a few times if the element to be clicked is covered before giving up would probably cause confusion instead of easing test writing. The reason is that if the center of the element is covered by another one the Firefox driver for Selenium tries to click on the corners of the element instead. The problem is that the coordinates used for the click are integer values, but Firefox has sub-pixel accuracy, so sometimes (depending on which corner is not covered and whether the left, top, width or height properties of the element to be clicked have a decimal component or not) the clicks silently land on a different HTML element (and that is with squared borders; with round borders they always land on a different HTML element. That was partially addressed for Selenium 3.0 by clicking first on the edges, but it would still fail if the middle point of the edges is covered but not the corners). It is not possible to fix or even detect all that from the tests (except maybe with some extreme hacks involving accessing private PHP members from Mink and bypassing or replacing the standard JavaScript executed by the Firefox driver with a custom implementation...), so it is not possible to ensure that clicks during an animation will land on the right element (in fact it is not possible even on static elements, although except when the layout is wrong there should be no problem); sometimes retrying a click when the element is covered would solve the problem, sometimes it would cause a different element to be clicked (and sometimes there would be even no retry, as the first click would have silently landed on a different element than the expected one). Therefore, a different approach must be used. Instead of trying to automatically handle clicks during animations the tests must be written being aware of the problem and thus waiting somehow for the animations that can cause a problem to end before performing the clicks. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	9ff0941c07	Replace inline favorite action with just a favorite icon ... This is a preparatory step for a following commit in which the position of the favorite icon and the checkbox will be swapped; in that new design the favorite icon is no longer expected to be an action but just a simple mark on whether the file is favorited or not (the action is expected to be triggered then only from the file actions menu). The favorite icon is now fully shown or completely hidden depending on whether the file is favorited or not. As the icon is just informative but no longer an action now it does not change when hovered or focus. In the same way, the alternative text when the file is not favorited now it is not "Favorite" (an action) but "Not favorited" instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	0e933ee6b9	Update acceptance tests to favorite files through the file actions menu ... Currently a file can be favorited either through the inline action or through the file actions menu. However, the inline action will be removed in a following commit and then it will be possible to do it only through the file actions menu. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	0c8627a7ee	Add acceptance tests for setting the color in the Theming app ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	63004c8ce5	Add getter for the timeout multiplier ... In some cases the acceptance tests have to explicitly wait for something to happen without using the "find" method from the actor; in those cases the timeout multiplier needs to be taken into account too, so the test cases must be able to retrieve it from the actor. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	c37329005e	Add option to acceptance test runner to set the Selenium server ... By default "127.0.0.1:4444" is used, so nothing needs to be set when the acceptance tests and the Selenium server share the same network (like when called by "run.sh"). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	2fe8cad710	Add option to acceptance test runner to set the Nextcloud server domain ... By default "127.0.0.1" is used, so nothing needs to be set when the Selenium server and the Nextcloud test server share the same network (like when called by "run.sh"). Besides passing the domain to the acceptance tests the Nextcloud test server configuration must be modified to see the given domain as a trusted domain; otherwise the access would be forbidden. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	8e9c12eed9	Make possible to configure the domain for the Nextcloud test server ... The NextcloudTestServerLocalHelper started the PHP built-in web server for the Nextcloud test server at 127.0.0.1; as the Selenium server has to access the Nextcloud test server they were forced to share the same network. Now, the domain at which the PHP built-in web server is started can be specified when the NextcloudTestServerLocalHelper is created, which removes the need of sharing the same network, as the Selenium server now can access the Nextcloud test server at an arbitrary domain. However, by default "127.0.0.1" is still used if no domain is given. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	b43a74bdcd	Add acceptance tests for unselecting items in dropdown for tags ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	71b90cdeff	Extract app navigation elements to its own context ... The app navigation is not exclusive to the Files app but a generic component used by other apps too, so its locators and steps should be in its own context. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	8deab238cc	Fix typo ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	6fa5c33af4	Add acceptance tests for sorting of favorite files ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Arthur Schiwon	6b5bbe1880	try to lower the timeout in an acceptance test ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	9 years ago