nextcloud-server

Commit Graph

Author	SHA1	Message	Date
John Molakvoæ (skjnldsv)	0f135c7bd6	Bump acceptance tests Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	14c996d982	Use elseif instead of else if Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	a8a06a82d2	Remove trailing whitespaces from comments Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	44577e4345	Remove trailing and in between spaces Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	afbd9c4e6e	Unify function spacing to PSR2 recommendation Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2fbad1ed72	Fix (array) indent style to always use one tab Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Azul	62f7e6ba81	tests: fix failing header acceptance test The username is listed in a div with class `fullname` now. Signed-off-by: Azul <azul@riseup.net>	6 years ago
Christoph Wurst	b80ebc9674	Use the short array syntax, everywhere Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	74936c49ea	Remove unused imports Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Daniel Calviño Sánchez	4ec370016f	Add acceptance test for restricting user enumeration to groups Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	9386f24ab0	Add acceptance test for accepting an incoming share Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	887e740434	Fix timeout capping Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	43e18e96e2	Revert (partially) "Accept incoming shares in acceptance tests" This reverts commit `f402e23448`. Since `eb4c42d3d1` now shares are accepted by default, so no notification is shown to accept them. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
GretaD	455013c309	fix the folder share Signed-off-by: GretaD <gretadoci@gmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>	6 years ago
Greta Doci	c864bc8321	Move users management to multi line Signed-off-by: Greta Doci <gretadoci@gmail.com>	6 years ago
Julius Härtl	0c6c12deae	Adjust tags acceptance tests to moved admin section Signed-off-by: Julius Härtl <jus@bitgrid.net>	6 years ago
Roeland Jago Douma	c007ca624f	Make phpunit8 compatible Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Daniel Calviño Sánchez	f402e23448	Accept incoming shares in acceptance tests Incoming shares are no longer automatically added to the file list of the sharee. Instead, the user now needs to explictly accept the share. Currently shares can be accepted only from the Notifications app, so it must be explicitly cloned before installing Nextcloud if it is not found in the "apps" directory. Note that the development branches are already built, so there is no need to explicitly build the app. With the new sharing behaviour the "share a skeleton file with another user before first login" scenario is no longer valid (as the user will need to log in to accept the share, so at that point the skeleton is already created), so it was removed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	0abff19aa9	Rename "Notification" to "Toast" Since Nextcloud 17 the proper name for the old built-in notifications is "Toast". Moreover, this will reduce ambiguity when using the "notification" term to refer to elements in the Notifications app. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
John Molakvoæ (skjnldsv)	12eba18bdf	Adjust acceptance tests to new OCA.Sidebar Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
John Molakvoæ (skjnldsv)	4293ede565	Fix tag acceptance tests after #16682 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
John Molakvoæ (skjnldsv)	f737dc9a86	Remove input id on login form Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>	6 years ago
Greta Doci	1993984769	Adjust acceptance tests to changes in link share menu behaviour Now the link share menu is not automatically opened after a link share is created, so waiting until it was opened failed in iShareTheLinkFor. Note that the steps that interact with the link share menu take care themselves of showing the menu if needed, so there is no need to explicitly show it despite the change. Also, the waiting in iShareTheLinkFor was introduced when the link share menu was changed to automatically open after creating a link share, as that caused some issues with the steps that opened the menu by themselves (`fec8d12fc5`). Due to all this, now that the link share menu is again not automatically opened the wait can be simply removed. Signed-off-by: Greta Doci <gretadoci@gmail.com>	6 years ago
Daniel Calviño Sánchez	e5a305b9d8	Allow Context subclasses in acceptance tests to access parent actor Although uncommon, in some cases a Context may need to be extended (for example, to override a step defined in the server with a specific behaviour in the acceptance tests of an app); in those cases the subclass should be able to access the actor attribute defined in the Context it is extending. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	e65fd11419	Add messages to assertFalse/True to clarify the failed assertion Otherwise the output would just read "Failed asserting that true is false." or "Failed asserting that false is true.", which is not very informative when there are several assertFalse/True in a row. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	df8406dbae	Adjust acceptance tests to notifications based on toastify The old notifications were added as ".row" elements to the "#notification-container" element; the new notifications based on toastify are added as ".toastify .on .toast..." elements to the "#content" element. Besides that, they also include a span element with an X to close the notification, so now only the first child text node should be compared to the expected message. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Joas Schilling	8852b85d13	Disable acceptance test which should fail anyway Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Julius Härtl	0968343061	Add acceptance test for public folder navigation Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Daniel Calviño Sánchez	ace4449924	Adjust acceptance tests to changes of file names in file picker File names are no longer shown directly in the ".filename" element, but split in two "span" elements inside a ".filename-parts" element, so now the texts in those span elements need to be concatenated to get the file name. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Roeland Jago Douma	49acc28d90	Revert "Temp disable bundle tests"	7 years ago
Roeland Jago Douma	093c75802c	Temp disable bundle tests The bundle acceptance tests fails after #14578 sometimes. This is because of a race condition. not all apps have compatible 16 versions yet. So trying to enable them results in those apps doing 💥. Because of #14578 we do show them now. So we try to enable them. However depending on which requests finishes first the disable button for the audit app either shows up or now. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Morris Jobke	970d52fc29	Adjust acceptance tests Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	1d938947e1	Disable failing files app test - act 4 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	951dcc110d	Disable failing files app test - act 3 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	70f90b8c6b	Disable failing app management test Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	caea04d28e	Disable failing comments app test - act 2 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	43e9006481	Disable failing files app test - act 2 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	38dd3da92b	Disable fragile user acceptance tests Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	a5e42f95c6	Disable failing login test * tests/acceptance/features/login.feature:15 <details><summary>Show full log</summary> ``` Scenario: log in with valid user and invalid password once fixed by admin # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:15 Given I act as John # ActorContext::iActAs() And I can not log in with user user0 and password 654231 # LoginPageContext::iCanNotLogInWithUserAndPassword() When I act as Jane # ActorContext::iActAs() And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin() And I open the User settings # SettingsMenuContext::iOpenTheUserSettings() And I set the password for user0 to 654321 # UsersSettingsContext::iSetTheFieldForUserTo() And I act as John # ActorContext::iActAs() And I log in with user user0 and password 654321 # LoginPageContext::iLogInWithUserAndPassword() Then I see that the current page is the Files app # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp() Failed asserting that 'http://acceptance-login/index.php/login?user=user0' starts with "http://acceptance-login/index.php/apps/files/". ``` </details> Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	18009c82e4	Disable failing comments test Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	247ade00e7	Disable failing files app test Fails with: * tests/acceptance/features/app-files.feature:90 <details><summary>Show full log</summary> ``` Scenario: show favorites # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:90 Given I am logged in # LoginPageContext::iAmLoggedIn() And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite() When I open the "Favorites" section # AppNavigationContext::iOpenTheSection() Then I see that the current section is "Favorites" # AppNavigationContext::iSeeThatTheCurrentSectionIs() Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed() Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException) ``` </details> Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	d98463f1b2	Disable failing apps management test Fails with: * tests/acceptance/features/apps.feature:66 <details><summary>Show full log</summary> ``` Scenario: Show section from app store # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:66 Given I act as Jane # ActorContext::iActAs() And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin() And I open the Apps management # SettingsMenuContext::iOpenTheAppsManagement() And I see that the current section is "Your apps" # AppNavigationContext::iSeeThatTheCurrentSectionIs() When I open the "Files" section # AppNavigationContext::iOpenTheSection() Files section item in App Navigation could not be found after 100 seconds (NoSuchElementException) Then I see that there some apps listed from the app store # AppsManagementContext::iSeeThatThereSomeAppsListedFromTheAppStore() And I see that the current section is "Files" # AppNavigationContext::iSeeThatTheCurrentSectionIs() ``` </details> Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	982081f1ab	Disable failing files tag test Fails with: * tests/acceptance/features/app-files-tags.feature:42 <details><summary>Show full log</summary> ``` Scenario: add tags using the dropdown in the details view # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-tags.feature:42 Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin() And I visit the settings page # SettingsMenuContext::iVisitTheSettingsPage() And I open the "Tag management" section # AppNavigationContext::iOpenTheSection() And I see that the button to select tags is shown # SettingsContext::iSeeThatTheButtonToSelectTagsIsShown() And I create the tag "tag1" in the settings # SettingsContext::iCreateTheTagInTheSettings() And I create the tag "tag2" in the settings # SettingsContext::iCreateTheTagInTheSettings() And I create the tag "tag3" in the settings # SettingsContext::iCreateTheTagInTheSettings() And I create the tag "tag4" in the settings # SettingsContext::iCreateTheTagInTheSettings() And I see that the dropdown for tags in the settings eventually contains the tag "tag1" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag() And I see that the dropdown for tags in the settings eventually contains the tag "tag2" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag() And I see that the dropdown for tags in the settings eventually contains the tag "tag3" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag() And I see that the dropdown for tags in the settings eventually contains the tag "tag4" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag() And I log out # SettingsMenuContext::iLogOut() And I am logged in # LoginPageContext::iAmLoggedIn() And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor() And I open the input field for tags in the details view # FilesAppContext::iOpenTheInputFieldForTagsInTheDetailsView() When I check the tag "tag2" in the dropdown for tags in the details view # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView() And I check the tag "tag4" in the dropdown for tags in the details view # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView() Then I see that the tag "tag2" in the dropdown for tags in the details view is checked # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsChecked() And I see that the tag "tag4" in the dropdown for tags in the details view is checked # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsChecked() And I see that the input field for tags in the details view contains the tag "tag2" # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewContainsTheTag() Failed asserting that false is true. And I see that the input field for tags in the details view contains the tag "tag4" # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewContainsTheTag() ``` </details> Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	77cf702220	Fix acceptance tests for wrong password message due to changed message Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	40e04c8391	Disable fragile tests for now Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	4b2efd94f9	Make header.feature more robust by running it on apache Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	3f2bb3ca05	Run tests that fail with "no such process" over to apache server Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	36bf1ffb25	Fix acceptance tests for tag management Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Daniel Calviño Sánchez	374b02c7bc	Add acceptance tests for copying files to the same folder Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago

1 2 3 4

178 Commits (2e36ea010a445295a451a00aaece42b081eb82ee)