68 Commits (2e4cc6da17028e777dc223689f1b9964ff2a4d8f)

Author	SHA1	Message	Date
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function ... To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	44577e4345	Remove trailing and in between spaces ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Arthur Schiwon	d06ef07a97	disable timeout on app install via cli ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	6 years ago
Joas Schilling	c7e81c2c52	Increase the timeout for app downloads ... Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
Joas Schilling	3eee359d7f	Allow to force enable apps via CLI ... Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at> Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	5bf3d1bb38	Update license headers ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Julius Härtl	8f2e8fa324	Run repair steps when enabling an app that has already been installed ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Roeland Jago Douma	f021db956c	Check if elements are set in installer ... Since we now have all the apps from the appstore we need to do a bit more checking. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Roeland Jago Douma	769cb629ae	allow enforcing apps to ignore the max version ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Joas Schilling	483ad01a09	There is no update available if the app didnt have a version (aka was not installed) ... Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago
Arthur Schiwon	38a90130ce	move log constants to ILogger ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	8 years ago
Morris Jobke	4fd697e733	Remove a check for an unused variable ... Left over from a refactoring https://github.com/nextcloud/server/pull/1940 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	514de5dfa1	Use isInstalled of AppManger instead of reimplement it ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Joas Schilling	1aa846107d	Dont use $info as array when its not an array ... Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago
Morris Jobke	9dc3b04802	Fix app version to be always string and neither array nor null ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	d3d045dd5c	Remove unused import statements ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Julius Härtl	efbdad2d0c	Remove OC_App::removeApp ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	8 years ago
Joas Schilling	d971b104ed	Do not cache the settings/sections in the database anymore ... This caused more troubles then it had benefits, especially when an app got disabled or was removed without being disabled. Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago
Morris Jobke	a661f043e1	Remove unneeded semicolon and parentheses ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	9ff51aafc5	Use index based string access for substr with length of 1 ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	2a38605545	Properly log the full exception instead of only the message ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Roeland Jago Douma	09f8a755ec	Remove IAppConfig::getValue ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
John Molakvoæ (skjnldsv)	2dbd5052ff	Up check ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Morris Jobke	54c227b6c4	Use cached app list ... Followup to #7264 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
John Molakvoæ (skjnldsv)	cca8744350	Do not update apps if it comes from git ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Morris Jobke	df61d43529	Make isUpdateAvailable non-static ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	a97a290fd5	Cache fetched apps in update check ... The code tried to find the apps with updates and thus was called for every available app. This caused to get the full appstore content as often as apps are available. The appstore request itself was cached nevertheless in an appdata dir, but with an object storage this is still a lot of round trips to read this cached result. Thus the instantiated list is now cached in a static variable (because it's a static method call). Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	05abb9ea66	Remove unused checkCode method ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	4866314ce0	Run updated license header updater ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	31c5c2a592	Change @georgehrke's email ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	0eebff152a	Update license headers ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Julius Härtl	b3c025fd08	Revert copyright changes ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	9 years ago
Julius Härtl	4cfa1c66b8	Doc: Fix phpDoc issues ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	9 years ago
Markus Staab	db34b59238	Prevent XSS in links which open a new browser window	9 years ago
Christoph Wurst	2e19c42bc5	Check whether an app archive can be extracted ... If extraction fails we should not continue the installation/update process as the info.xml cannot be loaded and an unrelated error occurs. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	9 years ago
Joas Schilling	79d7c26b8a	Register autoloading before running migrations ... Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Joas Schilling	7a3d83d630	Register autoloading before running migrations ... Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Joas Schilling	183b1dbde3	Use migrations when there is no database.xml ... Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Morris Jobke	be33234266	Remove OC_App:installApp ... * uses Installer->installApp now * removes unused code * fixes #4453 * added some additional checks Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Lukas Reschke	47cd976035	Add app bundles ... Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	9 years ago
Morris Jobke	c54a59d51e	Remove unused use statements ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Lukas Reschke	32bf8ec826	Don't use cached informations for app version ... When installing an app from the appstore the `\OC_App::getAppVersion` code is triggered twice: - First when the downloader tries to compare the current version to the new version on the appstore to check if there is a newer version. This protects against downgrade attacks and is implemented in `\OC\Installer::downloadApp`. - Second, when the app is actually installed the current version is written to the database. (`\OC\Installer::installApp`) This fails however when the version is actually cached. Because in step 1 the cached version will be set to "0" and then be reused in the second step. While this is probably not the cleanest version I assume this is an approach that is least invasive. Feedback and suggestions welcome :) Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	9 years ago
Lukas Reschke	7cb0df28e2	Prevent downgrade attacks for apps ... We should verify the app versions when installing a new update, otherwise this could result in downgrade attacks when an attacker just copies the old signature. Plus it prevents the case that in case of a bug in the appstore actually an older version gets installed. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	9 years ago
Joas Schilling	2f7e291101	Correctly catch the "soft errors" now ... Signed-off-by: Joas Schilling <coding@schilljs.com>	10 years ago
Joas Schilling	224dfaf1e6	Use a better error message and point the users to the support channels ... Signed-off-by: Joas Schilling <coding@schilljs.com>	10 years ago
Lukas Reschke	0eeef26a8e	Add tests for installer method ... Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	10 years ago
Lukas Reschke	086d43f26d	Move to non-static version ... The static version is used nowhere in the code and just decreases coverage Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	10 years ago
Lukas Reschke	d805df7bb3	Use findAppInDirectories ... The other function doesn't work if the appstore is disabled Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	10 years ago
Lukas Reschke	8acb54aa0b	Add update support ... Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	10 years ago
Lukas Reschke	3e6dd86ee4	Add support for CRL ... Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	10 years ago