nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Roeland Jago Douma	43efac345e	Use the correct mountpoint to calculate If we use the owners mount point this results in null. And then the rest of the checks get called with null. Which doesn't work. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Joas Schilling	89ed2c37bf	Update share type constant usage Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
Joas Schilling	95652d4469	Fix language in share notes email for users Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
Joas Schilling	69eda9c0f6	Prevent harder to share your root Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
Daniel Calviño Sánchez	45de42a6b8	Fix disabling send password by Talk without new password in mail shares When "send password by Talk" was disabled in a mail share it was possible to keep the same password as before, as it does not pose any security issue (unlike keeping it when "send password by Talk" is enabled, as in that case the password was already disclosed by mail). However, if a mail share is updated but the password is not set again only the hashed password will be available. In that case it would not make sense to send the password by mail, so now the password must be changed when disabling "send password by Talk". Note that, even if explicitly setting the same password again along with the "send password by Talk" property would work, this was also prevented for simplicity. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	a426f84dbe	Fix enabling send password by Talk with same password in mail shares When "send password by Talk" is enabled in a mail share a new password must be also set. However, when the passwords of the original and the new share were compared it was not taken into account that the original password is now hashed, while the new one is not (unless no new password was sent, in which case the password of the original share was set in the new share by the controller, but that was already prevented due to both passwords being literally the same), so it was possible to set the same password again. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	7569590514	Fix enabling send password by Talk with empty password in link shares When "send password by Talk" is enabled in a link share now a non empty password is enforced. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Morris Jobke	16f4b43d94	Adjust tests to only return group IDs Signed-off-by: Morris Jobke <hey@morrisjobke.de>	6 years ago
Roeland Jago Douma	f4b8623d33	Allow specifying a default expiration date This overrides the max expiration date. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Julius Härtl	397ab1c3c5	Remove unneeded test since links have resharing permissions by default Signed-off-by: Julius Härtl <jus@bitgrid.net>	6 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	afbd9c4e6e	Unify function spacing to PSR2 recommendation Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2fbad1ed72	Fix (array) indent style to always use one tab Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Christoph Wurst	2ee65f177e	Use the shorter phpunit syntax for mocked return values Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Joas Schilling	e97d643969	Strip of users home path from share api message Signed-off-by: Joas Schilling <coding@schilljs.com>	6 years ago
Roeland Jago Douma	bb4264c565	config.php setting to always accept internal shares Part of #18255 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	3a7cf40aaa	Mode to modern phpunit Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	078f4efb20	Fix tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	8d4346d656	Fix more tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	c007ca624f	Make phpunit8 compatible Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Christoph Wurst	1a886b1472	Add typed events for password_policy Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	6 years ago
Roeland Jago Douma	68748d4f85	Some php-cs fixes * Order the imports * No leading slash on imports * Empty line before namespace * One line per import * Empty after imports * Emmpty line at bottom of file Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Daniel Calviño Sánchez	2f49806c20	Add unit tests for "getAllShares()" Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Julius Härtl	22b81ac1e4	Fix permission check on incoming federated shares Since federated shares have their permissions set on the node, we do not need to check for parent share permissions. Otherwise reshares of incoming federated have no permission variable defined and creating them will fail Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Julius Härtl	857fae288c	Always set the display name for user shares Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Joas Schilling	85a80b05ac	Unify the permission checking in one place only Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Joas Schilling	e4addbae3e	Better check reshare permissions when creating a share Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Christoph Wurst	3174012adf	Add event dispatcher to OCP Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	7 years ago
Joas Schilling	f66c37bdb8	Correctly determinate the owner in case of shared external storages Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Roeland Jago Douma	372f3d2a60	Remove deprecated functions from SecureRandom Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Joas Schilling	ee545d6840	Fix typo in "incoming" Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Daniel Calviño Sánchez	fe8a67f517	Store "sendPasswordByTalk" property of link shares in the database Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	00e4c8aee4	Fix update share tests The update share tests only checked that the share returned by "update()" had the expected values. However, as "update()" returns the same share that was given as a parameter the tests were not really verifying that the values were updated in the database. In a similar way, the test that checked that a password was removed did not set a password first, so even if the database returned null it could be simply returning the default value for the share; a password must be set first to ensure that it is removed. Besides that, a typo was fixed too that made the checks on the original share instead of on the one returned by "update()"; right now it is the same share, so the change makes no difference, but it is how the check should be done anyway. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	4b7fa4ac2e	Add support for tokens in room shares Tokens will be used to give access to a share to guests in public rooms. Although the token itself is created in the provider of room shares and no changes are needed for that, due to the code structure it is necessary to explicitly call the provider from the manager when getting a room share by token. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	d582a66bea	Honour "sendPasswordByTalk" property in mail shares When a password was set for a mail share an e-mail was sent to the recipient with the password. Now the e-mail is no longer sent if the password is meant to be sent by Talk. However, before the e-mail was not sent when the share was updated but the password was not changed. Now an e-mail is sent in that case too if switching from a password sent by Talk to a password sent by mail. On the other hand, when switching from a password sent by mail to a password sent by Talk it is mandatory to change the password; otherwise the recipient would already have access to the share without having to call the sharer to verify her identity. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Bjoern Schiessle	b81962e3e8	fix unit tests Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	8 years ago
Maxence Lange	4f5814c27b	tests Signed-off-by: Maxence Lange <maxence@nextcloud.com>	8 years ago
Joas Schilling	bf2be08c9f	Fix risky tests without assertions Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago
Joas Schilling	2a01c0f3f6	Fix current access list test and add one for $currentAccess === false Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago
Joas Schilling	7e625a8d22	Use the language of the recipient for the share notification Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago
Roeland Jago Douma	4633717f04	Move pre_shared and post_shared events to EventDispatcher * Now listeners for those events get proper share objects. * Legacy hooks still fired * Updated tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Morris Jobke	c43abe43b0	Send an email once a file/folder is shared with a user * only if user has set an email address * only for user shares (no group shares for now) Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Pauli Järvinen	7c4a15f215	Emit hook postUnshareFromSelf when the recipient of a share unshares it - This kind of hook signal used to be emitted in the old Share library but it was missing from Share 2.0 Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>	9 years ago
Pauli Järvinen	8dce97a3e1	Fix emitting of legacy hook post_unshare - When a file was unshared, the legacy hook pre_unshare fired twice and the hook post_unshare did not fire at all. This was obviously a copy-paste error. Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>	9 years ago
Jan-Christoph Borchardt	fd63577089	Improve wording of various error messages Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>	9 years ago
Joas Schilling	0f8c1b13a3	Fix unknown share token Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Daniel Calviño Sánchez	a56fb75e69	Add missing unit test for updateShare with email share Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	de6b05a911	Add missing hook check Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Daniel Calviño Sánchez	dcc8cce28b	Fix double hashing of shared link passwords The plain text password for a shared links was hashed and, then, the hashed password was hashed again and set as the final password. Due to this the password introduced in the "Authenticate" page for the shared link was always a wrong password, and thus the file could not be accessed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Roeland Jago Douma	ae2db5e60d	Get proper accesslist for userFolder If the accesslist is requested for a users root folder we should properly construct the path Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago

1 2

90 Commits (2e4cc6da17028e777dc223689f1b9964ff2a4d8f)