4 Commits (311531ecce497663960877fc536ba94deff27bc0)

Author	SHA1	Message	Date
Roeland Jago Douma	f589f1a1d6	Move files_sharing Controllers => Controller ... lib/Controller is the default location for controllers. So lets put them all in there. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Joas Schilling	813f0a0f40	Fix apps/	10 years ago
Lukas Reschke	aba539703c	Update license headers	10 years ago
Joas Schilling	3a716ae91c	Move lib/ to PSR-4	10 years ago
Thomas Müller	682821c71e	Happy new year!	10 years ago
Scrutinizer Auto-Fixer	97f9213da9	Scrutinizer Auto-Fixes ... This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com	10 years ago
Lukas Reschke	8f09d5b67c	Update license headers	10 years ago
Morris Jobke	b945d71384	update licence headers via script	10 years ago
Roeland Jago Douma	3d2acb5003	sharingcheckmiddleware now handles externalshares as well ... Added new annotations for the externalsharescontroller class * @NoOutgoingFederatedSharingRequired * @NoIncomingFederatedSharingRequired By default both are required for all functions in the externalSharesController. A proper exception is thrown and then a 405 is returned instead of the default error page. Since it is only an API endpoint this makes more sense. Unit tests added and updated	10 years ago
Roeland Jago Douma	dc38e674a5	Split files_sharing middelware ... Since for external shares there is no need for link shares to be enabled we should check which controller is actually being called. This makes sure that in all cases we verify that the files_sharing app is enabled. But only for the share controller (public shares) we check if the API is enabled and if links are enabled. TODO: add checks for federated sharing as well	10 years ago
Lukas Reschke	22e724e829	Only intercept exceptions of type "NotFoundException" instead of any Exception ... The sharing backend may throw another exception for example when the activity app encounters a problem. Previously this just triggered a 404 error page and the exception got not logged at all. With this change such exceptions get not intercepted and regularly handled as exceptions so that we have meaningful log data. Also the user will be shown a window informing him that an error happened. Helps to debug cases such as https://github.com/owncloud/core/issues/19465	10 years ago
Roeland Jago Douma	4dba046712	Respect disabled sharing API settings ... If the sharing API setting is disabled that sharing check middle ware should block the request. Thus making link shares unavailable. Fixes #18970 * Unit test added * Unit tests updated	10 years ago
Jenkins for ownCloud	b585d87d9d	Update license headers	11 years ago
Lukas Reschke	e2453d78c0	Properly catch whether a share is `null` ... Despite it's PHPDoc the function might return `null` which was not properly catched and thus in some situations the share was resolved to the sharing users root directory. To test this perform the following steps: * Share file in owncloud 7 (7.0.4.2) * Delete the parent folder of the shared file * The share stays is in the DB and the share via the sharelink is inaccessible. (which is good) * Upgrade to owncloud 8 (8.0.2) (This step is crucial. The bug is not reproduceable without upgrading from 7 to 8. It seems like the old tokens are handled different than the newer ones) * Optional Step: Logout, Reset Browser Session, etc. * Access the share via the old share url: almost empty page, but there is a dowload button which adds a "/download" to the URL. * Upon clicking, a download.zip is downloaded which contains EVERYTHING from the owncloud directory (of the user who shared the file) * No exception is thrown and no error is logged. This will add a check whether the share is a valid one and also adds unit tests to prevent further regressions in the future. Needs to be backported to ownCloud 8. Adding a proper clean-up of the orphaned shares is out-of-scope and would probably require some kind of FK or so. Fixes https://github.com/owncloud/core/issues/15097	11 years ago
Morris Jobke	06aef4e8b1	Revert "Updating license headers" ... This reverts commit 6a1a4880f0.	11 years ago
Jenkins for ownCloud	6a1a4880f0	Updating license headers	11 years ago
Thomas Müller	25806346c2	remove deprecated code - fixes #13119	11 years ago
Lukas Reschke	988c85d292	Refactor file sharing public link handling ... fixes download issue introduced by #10755 Conflicts: apps/files_sharing/public.php	11 years ago