78 Commits (311531ecce497663960877fc536ba94deff27bc0)

Author	SHA1	Message	Date
Joas Schilling	8725302307	Fix InfoParser empty tests ... Signed-off-by: Joas Schilling <coding@schilljs.com>	9 years ago
Lukas Reschke	7cb0df28e2	Prevent downgrade attacks for apps ... We should verify the app versions when installing a new update, otherwise this could result in downgrade attacks when an attacker just copies the old signature. Plus it prevents the case that in case of a bug in the appstore actually an older version gets installed. Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	9 years ago
Lukas Reschke	0eeef26a8e	Add tests for installer method ... Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	9 years ago
Morris Jobke	972e560e72	Adding tests for 4 byte unicode characters ... * success on SQLite and Postgres * failure on MySQL due to the limited charset that only supports up to 3 bytes	9 years ago
Thomas Müller	c5ca71ee82	[9.2] Register commands in info.xml (#26248) ... * Use DI to load console commands from the apps - class name to be defined in the info.xml * Load commands from info.xml * Fix unit test * Allow Di magic for IMountManager Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	9 years ago
Thomas Müller	67d3574bdf	Don't parse info.xml but reuse already cached app infos - fixes #25603 (#25968) ... * Don't parse info.xml but reuse already cached app infos - fixes #25603 * Use === in InfoParser. Fixes test * InfoParser should not depend on UrlGenerator - fixes issue with session being closed too early	9 years ago
skjnldsv	71830b285c	Svgo optimization ... Signed-off-by: John Molakvoæ <fremulon@protonmail.com>	9 years ago
Christoph Wurst	dfb4d426c2	Add two factor auth to core	10 years ago
Thomas Müller	71fa0a75bf	Allow declaration of background jobs in info.xml	10 years ago
Thomas Müller	54f45f95f5	Adding repair steps for install and uninstall - fixes #24306	10 years ago
Thomas Müller	2ee7d2485c	Introduce background repair steps	10 years ago
Thomas Müller	d0030aad6c	Remove deprecated HTTPHelper from InfoParser	10 years ago
Stefan Weil	02e226a6b3	tests: Fix typos (found by codespell) ... Fix also a small grammar issue. Signed-off-by: Stefan Weil <sw@weilnetz.de>	10 years ago
Morris Jobke	23c0f4ff5f	Read available l10n files also from theme folder ... The old behaviour was that only languages could be used for an app that are already present in the apps/$app/l10n folder. If there is a themed l10n that is not present in the apps default l10n folder the language could not be used and the texts are not translated. With this change this is possible and also the l10n files are loaded even if the default l10n doesn't contain the l10n file.	10 years ago
Lukas Reschke	5278bfe0e4	Add support for custom values in integrity checker	10 years ago
Thomas Müller	8b165c5ed5	No longer evaluate appinfo/version	10 years ago
Lukas Reschke	bc62aa1ef5	Exclude .htaccess modifications from code checker ... After the initial installation ownCloud will write some content into the .htaccess file such as the 404 or 403 directives. This adds a magic marker into the .htaccess file and only the content above this marker will be compared in the integrity checker.	10 years ago
Lukas Reschke	4971015544	Add code integrity check ... This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository. Furthermore, there is a basic implementation to display problems with the code integrity on the update screen. Code signing basically happens the following way: - There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release 😉). This certificate is not intended to be used for signing directly and only is used to sign new certificates. - Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID. - The command generates a signature.json file of the following format: ```json { "hashes": { "/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d", "/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9" }, "certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----", "signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl" } ``` `hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`. Steps to do in other PRs, this is already a quite huge one: - Add nag screen in case the code check fails to ensure that administrators are aware of this. - Add code verification also to OCC upgrade and unify display code more. - Add enforced code verification to apps shipped from the appstore with a level of "official" - Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release - Add some developer documentation on how devs can request their own certificate - Check when installing ownCloud - Add support for CRLs to allow revoking certificates **Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature: ``` ➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt Successfully signed "core" ``` Then increase the version and you should see something like the following:  As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen. For packaging stable releases this requires the following additional steps as a last action before zipping: 1. Run `./occ integrity:sign-core` once 2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.	10 years ago
Joas Schilling	d904a09a04	The constant is now deprecated	10 years ago
Lukas Reschke	ab87274930	Use certificates that expire in 10 years ... 🙊 🙊 🙊	10 years ago
Robin McCorkell	aac84f732d	Unit test OC_Files::setUploadLimit() ... There was also a bug with checking the upper limit on the passed upload size. PHP does funny things with integer vs float comparisons, so our check didn't work. Now the check is much simpler, and ensures the value is sane.	11 years ago
Joas Schilling	eb1c437941	Check for methods as good as possible	11 years ago
Joas Schilling	2783a78070	Allow checking for functions	11 years ago
Joas Schilling	f228a3dc28	Add support for deprecated constants	11 years ago
Joas Schilling	d2fc1b2302	Correctly handle use statements	11 years ago
Olivier Paroz	71d65cb713	Fix max preview, some resizing and caching issues and force preview providers to resize their previews properly ... * introduces a method in OC_Image which doesn't stretch images when trying to make them fit in a box * adds the method to all key providers so that they can do their job, as expected by the Preview class * improves the caching mechanism of Preview in order to reduce I/O and to avoid filling the available disk space * fixes some long standing issues * **contains mostly tests**	11 years ago
Jan-Christoph Borchardt	4e93d9e3a2	remove logo-wide from tests	11 years ago
Morris Jobke	493844eda4	add positive tests for operator in code checker	11 years ago
Thomas Müller	aae098c24a	Check usage of != and == - refs #16054	11 years ago
Vincent Petry	76dad297ff	Fix encryption feof to not return too early ... This is because stream_read will pre-cache the next block which causes feof($this->source) to return true prematurely. So we cannot rely on it. Fixed encryption stream wrapper unit tests to actually simulate 6k/8k blocks to make sure we cover the matching logic. Added two data files with 8192 and 8193 bytes.	11 years ago
Thomas Müller	b966a4eb17	Adding unit test which shows insertIfNotExists to fall apart in certain situations	11 years ago
Joas Schilling	ae60108692	Revert "Correctly fallback to english, if the plural case is not translated" ... This reverts commit cbad5c998b.	11 years ago
Thomas Müller	d74662df7d	implement php code checker to detect usage of not allowed private APIs - including console command to check local code to be used by developers	11 years ago
Thomas Müller	f1d1714113	fix unit tests	11 years ago
Joas Schilling	cbad5c998b	Correctly fallback to english, if the plural case is not translated	11 years ago
Thomas Müller	5a03e0a5cf	adding dependency to owncloud version - with fallback to requiremin and requiremax	11 years ago
Thomas Müller	ee46548f57	adding dependencies for supported platforms	11 years ago
Thomas Müller	770f987659	adding supported libraries - including min and max version	11 years ago
Thomas Müller	b55ac514ac	no nested xml tags on dependencies	11 years ago
Thomas Müller	086ec3de15	adding command dependency	11 years ago
Thomas Müller	c80ec91f28	switch to different parsing implementation to get xml attributes properly handled	11 years ago
Thomas Müller	ba52c996cf	adding supported databases	11 years ago
Thomas Müller	b469e9f6fb	introduce dependency analyzer to take care of app dependencies ... some more unit tests on xml info parser	11 years ago
Thomas Müller	f74d568bda	adding new dependency for php version in apps info.xml	11 years ago
Thomas Müller	5ce34fbaf6	handle invalid xml file	11 years ago
Thomas Müller	d4f107d4dd	simplify xml parser code	11 years ago
Thomas Müller	c503ecd544	Introduce app info xml parser including basic unit test - necessary for #10777	11 years ago
Thomas Müller	2f19de11e4	adding console command to generate javascript translation files based on existing php translation files ... read server side translations from json files	11 years ago
Lukas Reschke	1b3feb710d	Use `rawurlencode` since this seems to be expected by cURL ... Fixes https://github.com/owncloud/core/pull/11501#issuecomment-58794405	11 years ago
Lukas Reschke	cede9fd7ef	Remove unneeded unit tests	11 years ago