nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Daniel Calviño Sánchez	203bf51543	Keep showing the working icon while there are pending operations Before, whenever a pending operation (getting the suggestions, confirming a share or selecting a recipient) finished the working icon was hidden and the confirm button was shown again, even if there were other pending operations (the most common case is typing slowly on the input field, as several operations to get the suggestions could pile if the server response is not received fast enough). Now, the working icon is not hidden until the last pending operation finishes. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	a2c52cd6a5	Extract code to restore the UI after confirming a share Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	9a0fbe307d	Discard cached suggestions when adding a share The suggestions depend on the results returned by the server, but also on the sharees already shared with. Due to that adding a share changes the suggestions, so now the cached suggestions are discarded when a share is added. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	6eb5cc5412	Reuse last suggestions if the same parameters are used When a share is confirmed the suggestions are got to check if there is an exact match. Usually the suggestions were already got with the same parameters in order to fill the autocomplete dropdown, so to avoid a superfluous request now the last suggestions are reused when got again, although only if the same parameters as the last time are used. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	10a4f8e45e	Confirm a share also by pressing enter on the input field Besides confirming a share by clicking on the confirm button now it is possible to do it by pressing enter on the input field. Clicking on the confirm button implicitly hides the autocomplete dropdown. On the other hand, pressing enter on the input field does not, so the autocompletion must be disabled and closed when the confirmation begins and then enabled again once it finishes. Otherwise the autocomplete dropdown would be visible and it would be possible to interact with it while the share is being confirmed. The order in which the input field and the autompletion are disabled is important. Internally, the autocompletion sets a timeout when the input field is modified that requests the suggestions to the server and then shows them in the dropdown. That timeout is not cancelled when the autocompletion is disabled, but when the input field loses its focus and the autocompletion is not disabled. Therefore, the input field has to be disabled (which causes it to lose the focus) before the autocompletion is disabled. Otherwise it could happen that while a share is being confirmed the timeout ends, so an autocompletion request is sent and then, once the share is successfully confirmed and thus the autocompletion is enabled again, the request is received and the autocomplete dropdown is shown with the old suggestions. Strange, but possible nevertheless ;-) Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	9371b61c4d	Add a share when clicking on the confirm button Clicking on the confirm button now adds a share, but only if there is just a single exact match. If there are no exact matches or there is more than one exact match no share is added, and the autocomplete dropdown is shown again with all the suggestions. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	5e2a8cca1b	Return also exact matches besides all suggestions "_getSuggestions" returned all the suggestions from the server, which are composed by exact matches and partial matches. Now the exact matches are also returned on their own parameter. This will be used by the button to confirm a share. Note that until now the order of the suggestions was "exact users, partial users, exact groups, partial groups, exact..."; this commit also changes that order to become "exact users, exact groups, exact..., partial users, partial groups, partial...". This is not a problem, as the suggestions were used in the autocomplete dropdown, and this new order is arguably better than the old one, as all exact matches appear now at the beginning. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	89b0e34d9b	Extract code to filter suggestions to its own function Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	1c440519c2	Show an error when getting the suggestions succeeds with failure content Instead of silently failing now an error is shown to the user when the ajax call to get the suggestions succeeds yet it returns failure content (for example, if an "OCSBadRequestException" was thrown in the server). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	ed1452d7a0	Use "showTemporary" instead of explicitly hiding the notification "OC.Notification.hide" expects the notification to be hidden to be passed as an argument. As it was being used to show a temporary notification the combination of "OC.Notification.show" and "OC.Notification.hide" was replaced by a single call to "OC.Notification.showTemporary". The timeout could have been specified in the options of the call, but it was left to the default value (7 seconds) for consistency with other notifications. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	fcef15af80	Move stub setup outside the test method Stubs should be restored outside the test method in which they are used to ensure that they are properly restored no matter the result of the test (for example, if an exception is thrown). Besides that, this will make possible to reuse the stub in other sibling tests without having to explicitly setup it in them. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	d606219576	Extract code to get suggestions to its own method Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	3980364b6d	Add autocompletion tests for each type of share Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	8af9c553e6	Add tests for exact search results already shared with Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	375eab9df3	Add tests for emails and circles already shared with Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	6fef01c481	Adjust search term to test As the server response is faked the search term is ignored in the tests. However, it is clearer to use a search term that would make the server return what the faked response contains. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Jan-Christoph Borchardt	ce7775acd0	Replace information icon with confirmation button in share input The confirmation button right now is just an icon; its behaviour will be added in the following commits. Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>	8 years ago
Daniel Calviño Sánchez	ed4b4458eb	Use the display name in the avatar for a circle share Before, the avatar for a circle share was generated using the "share_with" field as the seed for "imageplaceholder". Due to this, when the "share_with" field is set to the circle ID the character shown in the avatar was just a random character instead of the first character of the display name. Now the "share_with" is still used as the seed for the colour, but the display name is used as the text of the avatar. This adds support for "share_with" fields set to the circle ID while being backwards compatible with "share_with" fields set to the circle name. Note that when "share_with" fields is set to the circle name the colour of the avatar is different in the list of suggested sharees and in the list of current sharees, but that also happened before these changes (due to a different seed being used in each place). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Christoph Wurst	b9720703e8	Add CSRF token controller to retrieve the current CSRF token Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	8 years ago
John Molakvoæ (skjnldsv)	72861f2dfb	Use correct variables Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	15a3caedc0	Create special option to toggle header menu container Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	67699f9506	Clean scss, use proper loading icon and menu position on narrow screens Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Roeland Jago Douma	ad7ddbc068	Set autocomplete=new-password for mail share password This avoids the browser to do autocompletion on the mail share password field. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Morris Jobke	20ec0344a2	Fix JSDoc Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Vincent Petry	7466468af1	Fix share capabilities JS tests Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	8 years ago
Bjoern Schiessle	1615312bf1	add share permissions to settings page Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	8 years ago
Bjoern Schiessle	7d0102bf73	expose capabilities in js Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	8 years ago
Julius Härtl	d07d66e24b	Add public template Signed-off-by: Julius Härtl <jus@bitgrid.net>	8 years ago
Christoph Wurst	3992484323	Remove unused var in OC.Notification.showTemporary Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	8 years ago
Maximilian Wende	7c453b2425	Update tests for indeterminate state, fix slashes not being escaped Signed-off-by: Maximilian Wende <dasisdormax@mailbox.org>	8 years ago
Maximilian Wende	602f50b2d4	Fix indeterminate checkbox state not showing correctly Also, the checkbox is updated to the correct state while a permission change is in progress. should fix issue #8371 Signed-off-by: Maximilian Wende <dasisdormax@secure.mailbox.org>	8 years ago
Maximilian Wende	d4238a52b2	Add indeterminate state to 'can edit' share permission checkbox, see #8371 Signed-off-by: Maximilian Wende <dasisdormax@secure.mailbox.org>	8 years ago
Luca Adrian Lindhorst	269ca40784	Removed additional and uneccessary request on password reset, to fix redirection afterwards. Signed-off-by: Luca Adrian Lindhorst <info@lucalindhorst.de>	8 years ago
Allan Nordhøy	7fb1e458fa	There was an error loading → Could not load	8 years ago
Allan Nordhøy	29d68d7a35	There was an error loading → could not load	8 years ago
Allan Nordhøy	e81f30b124	Spelling: FreeType	8 years ago
Allan Nordhøy	13d8b7f190	Spelling: FreeType	8 years ago
Robert Pirritano	a82c8f58cc	made small changes to login screen added height back 70px back to footer and removed .htaccess file Signed-off-by: Robert R Pirritano <rpirritano@gmail.com>	8 years ago
Thomas Citharel	feb4dc383e	Adds rel="noopener noreferrer" to _blank links inside comments For more details, check out https://mathiasbynens.github.io/rel-noopener/ for instance Signed-off-by: Thomas Citharel <tcit@tcit.fr>	8 years ago
Daniel Calviño Sánchez	9c22e99331	Add extra test cases for password confirmation Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Abijeet	b246ca96ff	Added test cases for the fix for the password confirmation box appearing repeatedly. Signed-off-by: Abijeet <abijeetpatro@gmail.com>	8 years ago
Abijeet	de5467811a	Fixes password input being prompted every time. Fixes #7106 - Echoing the current server time via a JS variable and storing the current time on page load in JS. - Calculating the diff and taking it into account when deciding whether to show the password confirmation. Signed-off-by: Abijeet <abijeetpatro@gmail.com>	8 years ago
Arthur Schiwon	770c744e45	opens comments links in _blank 🙊 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	8 years ago
Julius Härtl	fd8f0788b1	Fix tests The avatar plugin should not change the display element, since the avatar is always shown by default and the display value is up to the developers Signed-off-by: Julius Härtl <jus@bitgrid.net>	8 years ago
Julius Härtl	04a18098e4	Remove show() function since we always show the avatar container Signed-off-by: Julius Härtl <jus@bitgrid.net>	8 years ago
John Molakvoæ (skjnldsv)	6127d19f54	Fixed default expire date and placeholder Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Daniel Calviño Sánchez	58d00bf6fb	Fix password displayed as username in Firefox password manager dialog When finishing the setup of Nextcloud through the WebUI (setting admin user and database) Firefox offers to save the username and password. However, the password was shown in both the username and password fields of the Firefox password manager dialog. The problem was that the password input element (in the HTML form) is cloned in a text input element, which is used to show the password in plain text when clicking on the "Show password" button. As it was a text input immediately followed by a password input Firefox seemed to assume that it had to be the username and ignored the real username field, no matter the value set for the "autocomplete" attribute. Now the cloned text input is added after the password input, so Firefox no longer thinks that the cloned text input is the username field and the password manager dialog shows the proper username instead. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
splitt3r	6ca7a3e650	Fixed js typehint for showHtml method	8 years ago
John Molakvoæ (skjnldsv)	bcad10075e	Share datepicker fix Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Arthur Schiwon	282567fced	format links in comments Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	8 years ago

1 2 3 4 5 ...

2184 Commits (4a6e31c91dcbdc2cfd2cae44bf64243c5005fa13)