1782 Commits (4ddc2444bdd3d0cee997232ae86a6f080f0efe2f)

Author	SHA1	Message	Date
Joas Schilling	b55ef51a27	Add tests for the correct share id on the call aswell	11 years ago
Roeland Jago Douma	02269b6464	Added unit test	11 years ago
Joas Schilling	02c60949dd	make scrutinizer happy	11 years ago
Joas Schilling	d146c13abd	Add tests for the remote sharing url	11 years ago
Thomas Müller	936d564058	fixes #15848	11 years ago
Robin Appelman	6bf0579622	fix test	11 years ago
Robin Appelman	be55a90323	dont use our now non existing hook	11 years ago
Bjoern Schiessle	27683f9442	fall back to the ownCloud default encryption module and aes128 if we read a encrypted file without a header	11 years ago
Joas Schilling	8f61fbb81f	Fix new tests	11 years ago
Joas Schilling	d600955a51	Make getDefaultModuleId public and get module protected	11 years ago
Joas Schilling	4e97228cde	Deduplicate module mock	11 years ago
Joas Schilling	4b7ae395f2	Add test for setDefaultEncryptionModule	11 years ago
Joas Schilling	b35379515c	Add a test that the default module is returned before we fall back	11 years ago
Bjoern Schiessle	9a5783b284	fix unit tests	11 years ago
jknockaert	4554df2512	enable testWriteWriteRead	11 years ago
jknockaert	18a1225b0c	enable testRewind	11 years ago
jknockaert	27ea23ea6b	Update encryption.php	11 years ago
jknockaert	d6841aa706	disable r+ test	11 years ago
jknockaert	7a34f75da6	add two tests ... testRewind tests reading and writing after rewind on an encrypted stream; testWriteWriteRead tests r+ mode	11 years ago
Joas Schilling	411f7893bf	Add test "operation on keys failed"	11 years ago
Joas Schilling	781cfff221	Deduplicate data provider and fix method visibility	11 years ago
Bjoern Schiessle	24128d1384	only update share keys if the file was encrypted	11 years ago
Bjoern Schiessle	2646bccb83	update share keys if file gets copied	11 years ago
Bjoern Schiessle	2990b0e07e	update share keys if a file is moved to a shared folder	11 years ago
Lukas Reschke	ab9ea97d3a	Catch not existing User-Agent header ... In case of an not sent UA header consider the client as valid	11 years ago
Lukas Reschke	155ae44bc6	Fix collision on temporary files + adjust permissions ... This changeset hardens the temporary file and directory creation to address multiple problems that may lead to exposure of files to other users, data loss or other unexpected behaviour that is impossible to debug. **[CWE-668: Exposure of Resource to Wrong Sphere](https://cwe.mitre.org/data/definitions/668.html)** The temporary file and folder handling as implemented in ownCloud is performed using a MD5 hash over `time()` concatenated with `rand()`. This is insufficiently and leads to the following security problems: The generated filename could already be used by another user. It is not verified whether the file is already used and thus temporary files might be used for another user as well resulting in all possible stuff such as "user has file of other user". Effectively this leaves us with: 1. A timestamp based on seconds (no entropy at all) 2. `rand()` which returns usually a number between 0 and 2,147,483,647 Considering the birthday paradox and that we use this method quite often (especially when handling external storage) this is quite error prone and needs to get addressed. This behaviour has been fixed by using `tempnam` instead for single temporary files. For creating temporary directories an additional postfix will be appended, the solution is for directories still not absolutely bulletproof but the best I can think about at the moment. Improvement suggestions are welcome. **[CWE-378: Creation of Temporary File With Insecure Permissions](https://cwe.mitre.org/data/definitions/378.html)** Files were created using `touch()` which defaults to a permission of 0644. Thus other users on the machine may read potentially sensitive information as `/tmp/` is world-readable. However, ownCloud always encourages users to use a dedicated machine to run the ownCloud instance and thus this is no a high severe issue. Permissions have been adjusted to 0600. **[CWE-379: Creation of Temporary File in Directory with Incorrect Permissions](https://cwe.mitre.org/data/definitions/379.html)** Files were created using `mkdir()` which defaults to a permission of 0777. Thus other users on the machine may read potentially sensitive information as `/tmp/` is world-readable. However, ownCloud always encourages users to use a dedicated machine to run the ownCloud instance and thus this is no a high severe issue. Permissions have been adjusted to 0700.Please enter the commit message for your changes.	11 years ago
Vincent Petry	b88d0ba0ac	Delete temp files after testing encryption stream wrapper	11 years ago
Thomas Müller	225cde2183	pass KeyStorage via ctor	11 years ago
Thomas Müller	987bc138df	calling renameKeys() on directory level as well - fixes #15778	11 years ago
Thomas Müller	fc4127dd62	add $encryptionModuleId to methods of Keys/IStorage	11 years ago
Bjoern Schiessle	19e8c4fcb1	get dirname from sharePath	11 years ago
Vincent Petry	76dad297ff	Fix encryption feof to not return too early ... This is because stream_read will pre-cache the next block which causes feof($this->source) to return true prematurely. So we cannot rely on it. Fixed encryption stream wrapper unit tests to actually simulate 6k/8k blocks to make sure we cover the matching logic. Added two data files with 8192 and 8193 bytes.	11 years ago
Lukas Reschke	9bc48451b9	Adjust tests and statuscode	11 years ago
Lukas Reschke	21f0476d31	Fix files	11 years ago
Lukas Reschke	9f61cf60d4	Verify if returned object is an array ... The error has to be thrown at this point as otherwise errors and notices are thrown since the time cannot be parsed in L60 and L61	11 years ago
Lukas Reschke	ed0b465cf9	Use 403 instead a 50x response	11 years ago
Joas Schilling	ddcd79132d	Add tests for correct path	11 years ago
Joas Schilling	0cf13e9b78	Fix phpStorm complains and namespace	11 years ago
Lukas Reschke	4ea205e262	Block old legacy clients ... This Pull Request introduces a SabreDAV plugin that will block all older clients than 1.6.1 to connect and sync with the ownCloud instance. This has multiple reasons: 1. Old ownCloud client versions before 1.6.0 are not properly working with sticky cookies for load balancers and thus generating sessions en masse 2. Old ownCloud client versions tend to be horrible buggy In some cases we had in 80minutes about 10'000 sessions created by a single user. While this change set does not really "fix" the problem as 3rdparty legacy clients are affected as well, it is a good work-around and hopefully should force users to update their client	11 years ago
Georg Ehrke	8f51efc49e	get rid of OC_Geo	11 years ago
Morris Jobke	758b2332f0	Use data provider instead of hand-crafted for loops ... * reduces scrutinizer complains * uses PHPUnit functionality	11 years ago
Bjoern Schiessle	7d4b1b52d0	always create a new instance of the encryption module	11 years ago
Bjoern Schiessle	b25c06f576	detect system wide mount points correctly	11 years ago
Bjoern Schiessle	e3d77c4b01	add migration script from old encryption to new one	11 years ago
Robin Appelman	e302213248	add unit tests for null handling in view	11 years ago
Morris Jobke	717723b83e	Remove unneeded comments	11 years ago
Robin Appelman	308af8b909	pass a stream to the tests	11 years ago
Thomas Müller	cbe30f740e	remove calculateUnencryptedSize() - not needed	11 years ago
Thomas Müller	88cc52c408	Avoid php message "Invalid argument supplied for foreach()" - refs #15590	11 years ago
Robin Appelman	01da6be4d6	upda tests	11 years ago