84 Commits (4f31b7b9cc2dac060194de2c769b149a2ac861ba)

Author	SHA1	Message	Date
Morris Jobke	93e4244886	Remove trailing spaces from localized strings ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	65d4ebe8cc	Show the repair steps and repair info output in the web for better feedback ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	f5a1f4bc1b	Revert "Wait for cron to finish before running upgrade command" ... This reverts commit 18e9631810. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Joas Schilling	ea21aa3f7a	Use numeric placeholders if there are multiple, so that RTL languages can operate better ... Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Joas Schilling	6eb2653897	Use ellipsis instead of triple dot ... Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago
Morris Jobke	18e9631810	Wait for cron to finish before running upgrade command ... * fixes #9562 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Arthur Schiwon	38a90130ce	move log constants to ILogger ... Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	8 years ago
Morris Jobke	2a38605545	Properly log the full exception instead of only the message ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	c70927eaa0	Remove not needed 3rdparty app disabling during upgrade for PHP 5.x ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	f22e02cd79	Refactor method to check if update is needed ... There was only one call, that actually needed the parameter to be set to true. So this change moved the print of the page to that location and replaces all other occurences with a direct call to the underlying OCP API. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	0e2f00ec59	Get the Installer via DI ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	0eebff152a	Update license headers ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Lukas Reschke	e1f52fc901	Stricter phan config fixes ... Signed-off-by: Lukas Reschke <lukas@statuscode.ch>	9 years ago
Morris Jobke	caa0ae94e8	Proper logging for appstore updates ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	9 years ago
Ko-	0024b67aaf	Check that set_time_limit is not disabled before calling it ... Signed-off-by: Ko- <k.stoffelen@cs.ru.nl>	9 years ago
Joas Schilling	0215b004da	Update with robin	10 years ago
Joas Schilling	ba87db3fcc	Fix others	10 years ago
Lukas Reschke	aba539703c	Update license headers	10 years ago
Thomas Müller	821d8736c8	Adding progress to web upgrade	10 years ago
Thomas Müller	22db0f17a8	Fix web updater - fixes #24115	10 years ago
Thomas Müller	5c3183cedd	Move version check code out of class Updater	10 years ago
Thomas Müller	739dfb5c66	Suggest cli based updater in case the instance is bigger - #23913	10 years ago
Thomas Müller	4b79fb10a2	Fix verbose output of upgrade command - not progressbar in this case and the schema migration test has one progressbar now for all tables - before we had one progressbar for each table	10 years ago
Morris Jobke	1f7e02e4d4	Add detailed logs hidden and show them on request	10 years ago
Thomas Müller	1bf4c75e8b	Show individual sql schema migration steps during upgrade - on web as well as on the command line	10 years ago
Morris Jobke	0a66734416	Revert "setting to skip migration tests by default"	10 years ago
Morris Jobke	2e444e6e37	setting to skip migration tests by default ... * if you install owncloud via package it is not possible to skip migration tests * this also allows to disable migration tests for an instance by default	10 years ago
Thomas Müller	682821c71e	Happy new year!	10 years ago
Björn Schießle	58b1221ad3	don't show previous log level in upgrade message	10 years ago
Lukas Reschke	4971015544	Add code integrity check ... This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository. Furthermore, there is a basic implementation to display problems with the code integrity on the update screen. Code signing basically happens the following way: - There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release 😉). This certificate is not intended to be used for signing directly and only is used to sign new certificates. - Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`, apps need to be signed with a certificate that either has a CN of `core` (shipped apps!) or the AppID. - The command generates a signature.json file of the following format: ```json { "hashes": { "/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d", "/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9" }, "certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----", "signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl" } ``` `hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`. Steps to do in other PRs, this is already a quite huge one: - Add nag screen in case the code check fails to ensure that administrators are aware of this. - Add code verification also to OCC upgrade and unify display code more. - Add enforced code verification to apps shipped from the appstore with a level of "official" - Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release - Add some developer documentation on how devs can request their own certificate - Check when installing ownCloud - Add support for CRLs to allow revoking certificates **Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature: ``` ➜ master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt Successfully signed "core" ``` Then increase the version and you should see something like the following:  As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen. For packaging stable releases this requires the following additional steps as a last action before zipping: 1. Run `./occ integrity:sign-core` once 2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.	10 years ago
Morris Jobke	f46d531a4f	Replace some OC_Config calls with ILogger methods	10 years ago
Morris Jobke	3b249f1967	Revert "setting to skip migration tests by default" ... This reverts commit 7cbdd9b90b.	10 years ago
Lukas Reschke	8f09d5b67c	Update license headers	10 years ago
Joas Schilling	e66e67567f	Update - Only add one section for disabled apps	10 years ago
Joas Schilling	9200bbeaba	Update: state which step we are going to start and warn if it might be slow	10 years ago
Morris Jobke	7cbdd9b90b	setting to skip migration tests by default ... * if you install owncloud via package it is not possible to skip migration tests * this also allows to disable migration tests for an instance by default	10 years ago
Morris Jobke	5acb38b5b3	[upgrade] switch to debug logging on upgrade ... * resets afterwards * adds output about the previous log level	10 years ago
Vincent Petry	ce6045f84b	Properly show update exception	11 years ago
Vincent Petry	90ed32ebc5	Properly show token errors in ajax/update.php event source	11 years ago
Vincent Petry	a64652e12a	Remove 3rd party text for disabled apps on update	11 years ago
Thomas Müller	d3ac73c0c9	Remove OC_Log	11 years ago
Morris Jobke	f63915d0c8	update license headers and authors	11 years ago
Morris Jobke	064f5204cc	Persist the state of the maintenance after an upgrade ... * if maintenance mode was enabled before an upgrade it will be enabled afterwards too * fixes #16429	11 years ago
Jenkins for ownCloud	b585d87d9d	Update license headers	11 years ago
Lukas Reschke	c0a02f1615	Verify CSRF token already in update.php and not the EventSource code ... Issue report: > Hum, well I upgraded the package then visited the web interface to trigger the update and it failed; the UI would say there was a possible CSRF attack and after that it'd be stuck in maintenance mode. Tried a few times (by editing maintenance to false in owncloud.conf) and same result each time. That smells partially like an issue caused by our EventSource implementation, due to legacy concerns the CSRF verification happens within the EventSource handling and not when the actual endpoint is called, what happens here then is: 1. User has somehow an invalid CSRF token in session (or none at all) 2. User clicks the update button 3. Invalid CSRF token is sent to update.php - no CSRF check there => Instance gets set in maintenance mode 4. Invalid CSRF token is processed by the EventSource code => Code Execution is stopped and ownCloud is stuck in maintenance mode I have a work-around for this problem, basically it verifies the CSRF token already in step 3 and cancels execution then. The same error will be shown to the user however he can work around it by refreshing the page – as stated by the error. I think that’s an acceptable behaviour for now: INSERT LINK To verify this test: 1. Delete your ownCloud cookies 2. Increment the version in version.php 3. Try to upgrade => Before the patch: Instance shows an error, is set to upgrade mode and a refresh does not help => After the patch: Instance shows an error, a refresh helps though. This is not really the best fix as a better solution would be to catch such situations when bootstrapping ownCloud, however, I don’t dare to touch base.php for this sake only, you never know what breaks then… That said: There might be other bugs as well, especially the stacktrace is somewhat confusing but then again it installing ownCloud under /usr/share/owncloud/ and I bet that is part of the whole issue ;-)	11 years ago
Vincent Petry	22bc37cb82	Properly forward repair errors and warnings ... This makes repair errors and warnings visible for the user when upgrading on the command line or in the web UI.	11 years ago
Morris Jobke	06aef4e8b1	Revert "Updating license headers" ... This reverts commit 6a1a4880f0.	11 years ago
Thomas Müller	bbf7f56f94	3rd-party apps are disabled on upgrade - refs #14026	11 years ago
Jenkins for ownCloud	6a1a4880f0	Updating license headers	11 years ago
Victor Dubiniuk	c9fd3c9d29	Inject config	11 years ago