152 Commits (4f31b7b9cc2dac060194de2c769b149a2ac861ba)

Author	SHA1	Message	Date
Greta Doci	1993984769	Adjust acceptance tests to changes in link share menu behaviour ... Now the link share menu is not automatically opened after a link share is created, so waiting until it was opened failed in iShareTheLinkFor. Note that the steps that interact with the link share menu take care themselves of showing the menu if needed, so there is no need to explicitly show it despite the change. Also, the waiting in iShareTheLinkFor was introduced when the link share menu was changed to automatically open after creating a link share, as that caused some issues with the steps that opened the menu by themselves (fec8d12fc5). Due to all this, now that the link share menu is again not automatically opened the wait can be simply removed. Signed-off-by: Greta Doci <gretadoci@gmail.com>	6 years ago
Daniel Calviño Sánchez	e5a305b9d8	Allow Context subclasses in acceptance tests to access parent actor ... Although uncommon, in some cases a Context may need to be extended (for example, to override a step defined in the server with a specific behaviour in the acceptance tests of an app); in those cases the subclass should be able to access the actor attribute defined in the Context it is extending. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	e65fd11419	Add messages to assertFalse/True to clarify the failed assertion ... Otherwise the output would just read "Failed asserting that true is false." or "Failed asserting that false is true.", which is not very informative when there are several assertFalse/True in a row. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	df8406dbae	Adjust acceptance tests to notifications based on toastify ... The old notifications were added as ".row" elements to the "#notification-container" element; the new notifications based on toastify are added as ".toastify .on .toast..." elements to the "#content" element. Besides that, they also include a span element with an X to close the notification, so now only the first child text node should be compared to the expected message. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Joas Schilling	8852b85d13	Disable acceptance test which should fail anyway ... Signed-off-by: Joas Schilling <coding@schilljs.com>	7 years ago
Julius Härtl	0968343061	Add acceptance test for public folder navigation ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Daniel Calviño Sánchez	ace4449924	Adjust acceptance tests to changes of file names in file picker ... File names are no longer shown directly in the ".filename" element, but split in two "span" elements inside a ".filename-parts" element, so now the texts in those span elements need to be concatenated to get the file name. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Roeland Jago Douma	49acc28d90	Revert "Temp disable bundle tests"	7 years ago
Roeland Jago Douma	093c75802c	Temp disable bundle tests ... The bundle acceptance tests fails after #14578 sometimes. This is because of a race condition. not all apps have compatible 16 versions yet. So trying to enable them results in those apps doing 💥. Because of #14578 we do show them now. So we try to enable them. However depending on which requests finishes first the disable button for the audit app either shows up or now. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Morris Jobke	970d52fc29	Adjust acceptance tests ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	1d938947e1	Disable failing files app test - act 4 ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	951dcc110d	Disable failing files app test - act 3 ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	70f90b8c6b	Disable failing app management test ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	caea04d28e	Disable failing comments app test - act 2 ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	43e9006481	Disable failing files app test - act 2 ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	38dd3da92b	Disable fragile user acceptance tests ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	a5e42f95c6	Disable failing login test ... * tests/acceptance/features/login.feature:15 <details><summary>Show full log</summary> ``` Scenario: log in with valid user and invalid password once fixed by admin # /drone/src/github.com/nextcloud/server/tests/acceptance/features/login.feature:15 Given I act as John # ActorContext::iActAs() And I can not log in with user user0 and password 654231 # LoginPageContext::iCanNotLogInWithUserAndPassword() When I act as Jane # ActorContext::iActAs() And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin() And I open the User settings # SettingsMenuContext::iOpenTheUserSettings() And I set the password for user0 to 654321 # UsersSettingsContext::iSetTheFieldForUserTo() And I act as John # ActorContext::iActAs() And I log in with user user0 and password 654321 # LoginPageContext::iLogInWithUserAndPassword() Then I see that the current page is the Files app # FilesAppContext::iSeeThatTheCurrentPageIsTheFilesApp() Failed asserting that 'http://acceptance-login/index.php/login?user=user0' starts with "http://acceptance-login/index.php/apps/files/". ``` </details> Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	18009c82e4	Disable failing comments test ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	247ade00e7	Disable failing files app test ... Fails with: * tests/acceptance/features/app-files.feature:90 <details><summary>Show full log</summary> ``` Scenario: show favorites # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:90 Given I am logged in # LoginPageContext::iAmLoggedIn() And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite() When I open the "Favorites" section # AppNavigationContext::iOpenTheSection() Then I see that the current section is "Favorites" # AppNavigationContext::iSeeThatTheCurrentSectionIs() Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed() Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException) ``` </details> Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	d98463f1b2	Disable failing apps management test ... Fails with: * tests/acceptance/features/apps.feature:66 <details><summary>Show full log</summary> ``` Scenario: Show section from app store # /drone/src/github.com/nextcloud/server/tests/acceptance/features/apps.feature:66 Given I act as Jane # ActorContext::iActAs() And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin() And I open the Apps management # SettingsMenuContext::iOpenTheAppsManagement() And I see that the current section is "Your apps" # AppNavigationContext::iSeeThatTheCurrentSectionIs() When I open the "Files" section # AppNavigationContext::iOpenTheSection() Files section item in App Navigation could not be found after 100 seconds (NoSuchElementException) Then I see that there some apps listed from the app store # AppsManagementContext::iSeeThatThereSomeAppsListedFromTheAppStore() And I see that the current section is "Files" # AppNavigationContext::iSeeThatTheCurrentSectionIs() ``` </details> Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	982081f1ab	Disable failing files tag test ... Fails with: * tests/acceptance/features/app-files-tags.feature:42 <details><summary>Show full log</summary> ``` Scenario: add tags using the dropdown in the details view # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files-tags.feature:42 Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin() And I visit the settings page # SettingsMenuContext::iVisitTheSettingsPage() And I open the "Tag management" section # AppNavigationContext::iOpenTheSection() And I see that the button to select tags is shown # SettingsContext::iSeeThatTheButtonToSelectTagsIsShown() And I create the tag "tag1" in the settings # SettingsContext::iCreateTheTagInTheSettings() And I create the tag "tag2" in the settings # SettingsContext::iCreateTheTagInTheSettings() And I create the tag "tag3" in the settings # SettingsContext::iCreateTheTagInTheSettings() And I create the tag "tag4" in the settings # SettingsContext::iCreateTheTagInTheSettings() And I see that the dropdown for tags in the settings eventually contains the tag "tag1" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag() And I see that the dropdown for tags in the settings eventually contains the tag "tag2" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag() And I see that the dropdown for tags in the settings eventually contains the tag "tag3" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag() And I see that the dropdown for tags in the settings eventually contains the tag "tag4" # SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag() And I log out # SettingsMenuContext::iLogOut() And I am logged in # LoginPageContext::iAmLoggedIn() And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor() And I open the input field for tags in the details view # FilesAppContext::iOpenTheInputFieldForTagsInTheDetailsView() When I check the tag "tag2" in the dropdown for tags in the details view # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView() And I check the tag "tag4" in the dropdown for tags in the details view # FilesAppContext::iCheckTheTagInTheDropdownForTagsInTheDetailsView() Then I see that the tag "tag2" in the dropdown for tags in the details view is checked # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsChecked() And I see that the tag "tag4" in the dropdown for tags in the details view is checked # FilesAppContext::iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsChecked() And I see that the input field for tags in the details view contains the tag "tag2" # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewContainsTheTag() Failed asserting that false is true. And I see that the input field for tags in the details view contains the tag "tag4" # FilesAppContext::iSeeThatTheInputFieldForTagsInTheDetailsViewContainsTheTag() ``` </details> Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	77cf702220	Fix acceptance tests for wrong password message due to changed message ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	40e04c8391	Disable fragile tests for now ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	4b2efd94f9	Make header.feature more robust by running it on apache ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	3f2bb3ca05	Run tests that fail with "no such process" over to apache server ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Morris Jobke	36bf1ffb25	Fix acceptance tests for tag management ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Daniel Calviño Sánchez	374b02c7bc	Add acceptance tests for copying files to the same folder ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	42457c8b23	Add acceptance tests for moving and copying selections to another folder ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	4fcabf167e	Add acceptance tests for moving and copying files to another folder ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	4566670fa3	Add acceptance tests for opening search results for comments ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	1a887aaad0	Add acceptance tests for searching comments ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	6cee8ba827	Add acceptance tests for comments on shared files and folders ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	65263817d0	Wait for the comment to be added before changing to another file ... If the server is too slow, changing to a different file immediately after sending a new comment but without waiting for the comment to be shown for the original file could cause the new comment to be shown for the current file instead. This is, indeed, a bug in the comments. However, it is not possible to test it reliably in the acceptance tests, as it depends on how fast the server adds the message and how fast the client changes to a different file; sometimes the test would fail and sometimes it would not. Therefore, now it is waited for the comment to be added before changing to another file, as in this case it can be reliably tested that changing to a different file does not cause the comments from the previous file to be shown in the current file (this was a different bug already fixed and due to which this test was added in the first place). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	d5725cb3d9	Wait for the empty content element to be shown ... When the "Comments" tab is open the empty content element is always in the DOM, although it is only shown once the message collection was fetched and there were no messages. Due to this it is necessary to explicitly wait for it to be shown instead of relying on the implicit wait made to find the element; otherwise it would be found immediately and if the collection was not fetched yet it would not be visible, causing the test to fail. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	4d4032bca3	Rename "FilesSharingAppContext" to "PublicShareContext" ... Having both "FilesAppSharingContext" and "FilesSharingAppContext" was confusing, so "FilesSharingAppContext" was renamed to a more descriptive name. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	87d4fb777a	Extract locators and steps for sharing in Files app to their own context ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	d6c053f6a3	Extract sharing related acceptance tests to their own feature files ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	75b734ec98	Add acceptance tests for folders that can not be reshared ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	d9ad31bd7f	Add acceptance tests for resharing a folder with another user ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	563454b741	Add acceptance test for checking that the owner can see reshares ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	7aaf5e6a4c	Add acceptance test for resharing a file with another user ... To reshare a file there must be at least three enabled users in the system; although it would be possible to run the steps to create a third user in the scenarios that need it for convenience a third enabled user besides "admin" and "user0" was added to the default setup. In a similar way, a new step was added too to login as a given user name, similar to the steps to log in as "user0" and as "admin". Finally, another actor, "Jim", was introduced for those scenarios which should be played by three standard actors (that is, without a special configuration like "Rubeus"). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	f2f073a304	Add acceptance tests for sharing a folder with another user ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	aa695dca0d	Add acceptance tests for sharing a file with another user ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	1d1708688f	Add acceptance tests for showing again the input field for tags ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	57ffa9ea73	Add acceptance tests for opening and closing again the details view ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	94645ed754	Add acceptance tests for marking a file as favorite in the details view ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	139e2218d1	Add acceptance tests for switching to the comments of another file ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
John Molakvoæ (skjnldsv)	2b7832d0c9	Fix breakpoint and shrinking of the content + list ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	7 years ago
Daniel Calviño Sánchez	b5977bef2e	Adjust acceptance tests to changes in public share page menu ... The "Download" item in the menu of public share pages is no longer shown in wide (>768px) windows (although the element is in the DOM and shown if resized to a narrow window). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	fec8d12fc5	Wait for the link share menu to open in acceptance tests ... In the acceptance tests the link share menu is automatically opened if needed before interacting with an item in the menu; if the menu is not open it is opened by clicking on its toggle. However, since a recent change the link share menu is automatically opened by the regular UI after the link share is created. This causes that, sometimes, after the creation of a link share the acceptance tests check whether the menu is shown or not before the menu was automatically opened; as the menu is not open then the acceptance tests proceed to click on the toggle, but in the meantime the link share was created and the menu opened, so clicking on the toggle now closes it. As the menu is closed it is not possible to interact with its items and the test fails. To prevent that now the acceptance tests wait for the link share menu to open after a link share is created before continuing with the other steps. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago