nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Ferdinand Thiessen	890ab98ee5	fix(encryption): handle decryption exception with outdated passwords Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	3 weeks ago
David Dreschner	672542f587	fix(files): Prevent corruption of files when moving from encrypted to unencrypted folders within the same object storage Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>	4 weeks ago
Stephen Cuppett	840edf7701	refactor(tests): Replace helper callback methods with inline closures in encryption tests Addresses reviewer feedback requesting consistent mock callback style in RecoveryTest and UtilTest. Drops the now-unused setValueTester, getValueTester, and removeValueTester helper methods. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <steve@cuppett.com>	2 months ago
Stephen Cuppett	f2d0cb1876	refactor(encryption): Migrate remaining deprecated IConfig calls to typed APIs Replace IConfig::{get,set}UserValue for the per-user 'recoveryEnabled' key with IUserConfig::{getValueBool,setValueBool}, and IConfig::getAppValue for 'useMasterKey' with IAppConfig::getValueBool. IConfig is removed from Util and Recovery constructors entirely. Clears the DeprecatedMethod psalm-baseline entries for apps/encryption/lib/Util.php and the string-typed recoveryAdminEnabled calls that were still in Recovery.php. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <steve@cuppett.com>	2 months ago
Stephen Cuppett	a5a64240e0	fix(tests): Remove dead getAppValue mock for recoveryAdminEnabled in AdminTest The production code already uses getValueBool for this key; the IConfig mock branch was unreachable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <steve@cuppett.com>	2 months ago
Stephen Cuppett	1b2b4cb660	refactor(encryption): Migrate appconfig keys to typed bool IAppConfig with repair step Switch all encryption config reads/writes from deprecated string-typed IConfig to bool-typed IAppConfig (getValueBool/setValueBool). Adds RetypeEncryptionConfigKeys repair step to retype existing string values to bool on upgrade. Includes lazy IAppConfig resolution in Manager and AppConfigTypeConflictException fallbacks throughout for safety during the upgrade window. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <steve@cuppett.com>	2 months ago
Côme Chilliet	16160c9019	fix(encryption): Fix endpoint /ajax/userSetRecovery to support boolean Frontend is sending a boolean but backend was still expecting a string. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Côme Chilliet	1ab09ec753	chore: Apply new coding standard to all files The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines To see only the changes not related to blank lines. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Robin Appelman	1e2f273c09	test: adjust tests to caching of key validation Signed-off-by: Robin Appelman <robin@icewind.nl>	5 months ago
Carl Schwan	edd37d349b	perf(file-cache): Add mimetype filter on getFolderContents Signed-off-by: Carl Schwan <carlschwan@kde.org>	6 months ago
Carl Schwan	ae73f7aaf5	refactor(setup-manager): Use ISetupManager instead of SetupManager Keep using the OC API in the mount manager and OC_Utils, but the rest is now using the public API. Signed-off-by: Carl Schwan <carlschwan@kde.org>	7 months ago
Carl Schwan	11cf69d8ba	fix(psalm): Fix static analysis issues in apps/*/tests There are still 1200 more to fix before we can enable static analysis for the tests. Signed-off-by: Carl Schwan <carlschwan@kde.org>	7 months ago
Ferdinand Thiessen	108858daef	refactor(encryption): migrate to Vue 3 and Typescript and script setup Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	7 months ago
Abhinav Ohri	252956d6b2	test: fix PHPUnit deprecations and mocking issues Signed-off-by: Abhinav Ohri <abhinavohri13@gmail.com>	7 months ago
Côme Chilliet	928a45c677	fix(encryption): Fix user key support with basic auth When using basic authentication the user is not logged in yet when KeyManager constructor gets called, so we need to delay the check for the loggedin user uid. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	9 months ago
Ferdinand Thiessen	d6d6747a73	refactor: apply rector rules for PHPUnit 10 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	10 months ago
Carl Schwan	a3442be054	refactor: fix psalm issues from encryption commands Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	11 months ago
Ferdinand Thiessen	7cc3c1f669	fix(encryption): do not setup filesystem without permissions If the current request does not have permissions for the filesystem we must not try to setup the filesystem. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	11 months ago
Côme Chilliet	8330f149b0	chore(encryption): Remove unused attribute $uid in KeyManager::getFileKey It’s a private API in the application, no need to keep an unused attribute. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	12 months ago
Côme Chilliet	bc5e29f9f2	fix(tests): Fix type issues and other problems with encryption tests Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	12 months ago
Côme Chilliet	7ac0856f9f	chore(tests): Adapt encryption tests to code changes Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	12 months ago
Côme Chilliet	f95fef9938	chore(encryption): Adapt tests to code changes Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
Côme Chilliet	58e8626f5f	chore: Adapt tests to new parameter in EncryptAll constructor Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	1 year ago
Robin Appelman	aa15f9d16d	chore: run rector Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Ferdinand Thiessen	d0758fe6ac	test(encryption): adjust test code for PHPUnit 10 deprecations Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	1 year ago
Côme Chilliet	64863c9d46	chore: Apply new rector configuration to apps folder Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
provokateurin	381077028a	refactor(apps): Use constructor property promotion when possible Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Ferdinand Thiessen	f3aa004b1c	refactor(encryption): Migrate away from Hooks to typed events Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Louis <louis@chmn.me> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 years ago
Côme Chilliet	1580c8612b	chore(apps): Apply new rector configuration to autouse classes Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Joas Schilling	4312473fbc	test: Fix wrongly mocked method Signed-off-by: Joas Schilling <coding@schilljs.com>	2 years ago
Côme Chilliet	1a4978c4ea	chore: Apply rector configuration to apps folder Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
provokateurin	9836e9b164	chore(deps): Update nextcloud/coding-standard to v1.3.1 Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Côme Chilliet	801733e523	fix: Remove OCP\Files\Storage interface deprecated since version 9 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 years ago
Christoph Wurst	49dd79eabb	refactor: Add void return type to PHPUnit test methods Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	2 years ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
Louis Chemineau	f244261e85	test: Fix encryption test Signed-off-by: Louis Chemineau <louis@chmn.me>	2 years ago
Andy Scherzinger	5b7dcc1427	chore: Add SPDX header Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>	2 years ago
Joas Schilling	6dffc9bc17	fix(CS): Fix coding style Signed-off-by: Joas Schilling <coding@schilljs.com>	3 years ago
Ferdinand Thiessen	c3d63c57ce	fix(encryption): Fix deprecated syntax in encryption tests Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	3 years ago
Joas Schilling	aa5f037af7	chore: apply changes from Nextcloud coding standards 1.1.1 Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	3 years ago
Côme Chilliet	1e06b61f59	Migrate away from ILogger in encryption And modernize code a bit Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	99bdb15398	Adapt encryption test to change in generateHeader Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Ferdinand Thiessen	dc9d8c42bb	fix: Adjust console formatter code to match with Symfony type hints Symfony has added type hints on the `OutputFormatterInterface`, so we must adjust our type hints to match with Symfony. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>	3 years ago
Côme Chilliet	4393b96542	Remove unused method getLocalFolder It’s not used and not in any OCP interface/class. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Robin Appelman	808a80eb9c	add test for unmarking encrypted file on cross storage move Signed-off-by: Robin Appelman <robin@icewind.nl>	3 years ago
Côme Chilliet	430009b8e2	Add a test for multiKeyEncrypt/Decrypt methods Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	0750481bb7	Adapt encryption recovery tests to new system Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	26d8fb0b65	Adapt encryption tests to the new system Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Côme Chilliet	8900d030d1	Adapt code to new encryption system fileKey gets deleted upon save as it’s stored in shareKeys instead now. We use presence of a fileKey to detect if a file is using the legacy system or the new one, because we do not always have access to header data. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 years ago
Joas Schilling	f60e1f751d	Fix unit tests Signed-off-by: Joas Schilling <coding@schilljs.com>	4 years ago

1 2 3 4 5

222 Commits (5084b58fd29dfd65372e8efdd22a7df615682d5a)