2193 Commits (55e1270b94aa0f4ea003e2cbc87a8ea56bcae96d)

Author	SHA1	Message	Date
Ching Kuo	db36014654	fix(ObjectStore): reset multipart upload byte counter on retry ... writeMultiPart() initializes $totalWritten once outside the retry loop, so bytes from a failed first attempt accumulate into the second attempt. Since $state is never resumed, each retry rewinds the stream and re-uploads the whole object from scratch, making before_complete compare roughly twice the object size against the expected size. The retry then always fails with "Incomplete multi part upload, expected X bytes, wrote 2X" and the upload is aborted. Reset the counter per attempt so the size check validates only the bytes written by the current attempt. Fixes #59505 Signed-off-by: Ching Kuo <igene@igene.tw> Assisted-by: Claude Code:claude-fable-5	2 weeks ago
Carl Schwan	aeb29f32b7	feat(api): Add getOrCreateFolder also for SimpleFS module ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	2 weeks ago
Côme Chilliet	8c4e2b5a97	chore: Apply rector:strict ruleset ... So that CI is green again. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	2 weeks ago
Robin Appelman	4c9cabf31f	fix: add more logging around failed local renames ... Signed-off-by: Robin Appelman <robin@icewind.nl>	3 weeks ago
Carl Schwan	1f09b911e6	perf: Don't update etag of folder marked as IReliableETagStorage ... Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 weeks ago
Carl Schwan	f65ef83eae	perf: Use hash map to check if path was already checked ... Faster than using in_array Signed-off-by: Carl Schwan <carl@carlschwan.eu>	3 weeks ago
David Dreschner	672542f587	fix(files): Prevent corruption of files when moving from encrypted to unencrypted folders within the same object storage ... Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: David Dreschner <david.dreschner@nextcloud.com>	4 weeks ago
Jonas	cebcc6cc01	fix(AmazonS3): pass S3 error messages through to the frontend ... * S3Exception to NotPermittedException in Storage/AmazonS3::writeStream() * NotPermittedException to Forbidden in Storage/Common::copyFromStorage() Improves error messages on move/copy operations when bucket quota exceeded Fixes: #58801 Signed-off-by: Jonas <jonas@freesources.org>	4 weeks ago
Stephen Cuppett	b6fddabf6c	fix(encryption): Address review feedback and fix zero-byte size consistency ... Apply come-nc's reviewer suggestions on Scanner.php: - Simplify cached unencrypted_size skip condition to explicit == 0 check - Remove redundant !isset guard on new-file path Fix remaining > 0 / !== 0 guards that treated zero as "no unencrypted_size": - FileInfo constructor: use encrypted flag for rawSize (getSize(false) path) - FileInfo::addSubEntry: use encrypted flag for sub-mount accumulation - Cache::calculateFolderSizeInner: use encrypted column instead of > 0 Add tests covering zero-byte encrypted file scenarios: - FileInfoTest: getSize(true/false) for zero-byte encrypted files - CacheTest: getUnencryptedSize and calculateFolderSize with encrypted=1,size=0 - EncryptionTest: verifyUnencryptedSize data provider cases for header-only files Assisted-by: ClaudeCode:claude-opus-4-6 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <scuppett@redhat.com>	1 month ago
Stephen Cuppett	eca95034a3	fix(encryption): Correctly report size for zero-byte encrypted files ... Files with 0 bytes no longer incorrectly report as 8192 bytes. Widens unencryptedSize to ?int, fixes verifyUnencryptedSize to compare against header size instead of 0, and corrects Scanner to populate unencrypted_size on initial upload. Assisted-by: ClaudeCode:claude-opus-4-6 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <steve@cuppett.com>	1 month ago
nextcloud-command	cbbbe5ac14	refactor: Apply rector changes ... Signed-off-by: GitHub <noreply@github.com>	1 month ago
Robin Appelman	8c07ea3225	fix: harden object store against copying a file to itself ... Signed-off-by: Robin Appelman <robin@icewind.nl>	1 month ago
Robin Appelman	bf24f0ffd0	fix: pass correct source cache in ObjectStoreStorage::copyFile ... I don't think this actually matters, but better to be correct Signed-off-by: Robin Appelman <robin@icewind.nl>	1 month ago
Kent Delante	9174cd966f	fix(files): preserve encryptedVersion when copying cache entries ... Cache::copyFromCache() rebuilt the target's cache row via cacheEntryToArray(), which only carried over a boolean `encrypted` flag and dropped the real `encryptedVersion` count. Since View::copy() unconditionally calls copyFromCache() after the storage copy completes, this silently overwrote the correct encryptedVersion that Encryption::updateEncryptedVersion() had just set, collapsing it back to 0/1 on every copy of a file whose encryptedVersion was above 1. cacheEntryToArray() now includes the source entry's encryptedVersion when it is encrypted. The existing encrypted-to-non-encrypted-storage override in copyFromCache() also clears encryptedVersion alongside `encrypted`, since normalizeData() prefers encryptedVersion over `encrypted` when both are present in the update data. Signed-off-by: Kent Delante <kent@delante.me> Assisted-by: ClaudeCode:claude-sonnet-5	1 month ago
Git'Fellow	fcc63b9603	refactor(dbal): move to modern calls ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Signed-off-by: Carl Schwan <carlschwan@kde.org>	1 month ago
Kent Delante	43ed780841	fix(s3): trim multiple spaces to single space in original path header ... Signed-off-by: Kent Delante <kent@delante.me> The spec defines that x-amz-meta-original-path header needs spaces to be trimmed and multiple spaces need to be converted to a single space. This is to comply with the spec and fix it for some storage hosts that return a SignatureDoesNotMatch error when not done.	1 month ago
Maksim Sukharev	715378f38f	fix(View#getCacheEntry): skip propagation when storage metadata is unchanged ... Storage backends like AmazonS3 whose hasUpdated() always returns true (S3 has no cheap global change-detection mechanism) caused propagateChange() to be called on every watcher->update() after a folder was browsed, even when the underlying storage_mtime and etag were identical to the cached values. Before the fix, getCacheEntry() would call watcher->update() and then unconditionally call propagateChange() whenever the watcher reported a change. For S3 directories this meant every read bumped the parent mtime chain. After the fix, getCacheEntry() snapshots the cache entry before watcher->update() and compares it with the entry after. propagateChange() is only invoked when at least one metadata field (mtime, storage_mtime, size, or etag) actually changed. Assisted-by: ClaudeCode:claude-sonnet-4-6 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>	1 month ago
Git'Fellow	586e8a0c41	fix(files): do not let a failing move hook break the move or hide files ... Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	1 month ago
Carl Schwan	da0928827a	refactor: Expose a public exception when no user is found ... And use this new exception everywhere outside of where the old one was throw. Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Carl Schwan	33402a991b	perf: Only sort wrappers when adding them ... Instead of doing that each time a new mount point is created (e.g. for the 7000 shares we have in production). Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Carl Schwan	0b9e592796	refactor: Soft remove Emitter from IRootFolder interface ... Move this to the private implementation in OC, so that using IRootFolder in apps doesn't require dummy stubs. This will create a new psalm warnings for users of this method but considering that this is deprecated for a long time and that it still works at runtime, this shouldn't cause any issue. Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Carl Schwan	b6a23f0268	refactor: Call IStorageFactory::addStorageFactory directly ... Remove call to deprecated Filesystem api and allow to reuse instead of the mounts points between addStorageFactory. Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Carl Schwan	e6b5f763a4	perf: Avoid sorting an already sorted array ... Improve performance a bit as this is in the hotpath and take ~2s in prod. Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Carl Schwan	d6cf5292e2	feat: Make it possible to add a storage wrapper using public APIs ... Before that every app is using an internal call to Filesystem::addStorageWrapper. The new API enforce that this is called at the right moment. Signed-off-by: Carl Schwan <carlschwan@kde.org>	2 months ago
Enrique Pérez Arnaud	3616212ba2	feat(files_sharing): store and refresh OCM access tokens for external shares ... Co-authored-by: Micke Nordin <kano@sunet.se> Signed-off-by: Micke Nordin <kano@sunet.se> Signed-off-by: Enrique Pérez Arnaud <enrique@cazalla.net>	2 months ago
Arthur Schiwon	437952bd70	fix: ensure file names are string-typed ... - `$child` was used as an array key earlier. If they are numeric, they are automatically converted to ints, leading to type issues later. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	2 months ago
Robin Appelman	09d6942c11	chore: fix SearchBinaryOperator constructor type hint ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 months ago
Robin Appelman	bae156db12	fix: pass parent id to correctParentStorageMtime when known ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 months ago
Carl Schwan	d6f7805ae7	refactor: Improve log message ... Co-authored-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Carl Schwan <carl@carlschwan.eu>	2 months ago
Robin Appelman	ccb1d9afa7	fix: improve logging around failed chunked object store uploads ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 months ago
Robin Appelman	76ce9556ce	fix: don't return cache entries with null paths ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 months ago
Robin Appelman	17a7a95553	perf: delay loading storage info in Cache untill needed ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 months ago
Robin Appelman	f69b57cfc2	chore: psalm fix ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 months ago
Robin Appelman	48dfc2be3a	chore: psalm fix ... Signed-off-by: Robin Appelman <robin@icewind.nl>	2 months ago
Carl Schwan	774420a188	fix(filesystem): reset static members during frankenphp invokations ... Signed-off-by: Carl Schwan <carlschwan@kde.org>	3 months ago
Carl Schwan	994565fec7	refactor: Use new IQueryBuilder::MAX_IN_PARAMETERS ... Signed-off-by: Carl Schwan <carlschwan@kde.org>	3 months ago
Côme Chilliet	9c92cc1617	chore: Suppress last known impure static properties ... We will keep these legacy ones for now. We can search for the ImpureStaticProperty suppression and add special treatement for them in the frankenphp PR if needed. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Côme Chilliet	504a02b04e	fix: Remove static property use in SeekableHttpStream ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Côme Chilliet	9d7c277668	fix: Remove static vars in trashbin, versions and storages ... Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Côme Chilliet	1ab09ec753	chore: Apply new coding standard to all files ... The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines To see only the changes not related to blank lines. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
Cristian Scheid	476a6f0774	feat(file-search): add property to SearchQuery and check select fields to decide wheter to join extended cache ... Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>	3 months ago
Josh	a494fcd2c6	chore(DAV): fixup proxyexclude default value check ... Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Josh <josh.t.richards@gmail.com>	3 months ago
Josh	d68a7f0d94	chore(DAV): fixup for lint ... Signed-off-by: Josh <josh.t.richards@gmail.com>	3 months ago
Josh	277154396f	fix(Storage): use proxyexclude parameter in DAV client ... Signed-off-by: Josh <josh.t.richards@gmail.com>	3 months ago
provokateurin	b1724dbad0	chore(Cache): Remove deprecated insert and update events ... Signed-off-by: provokateurin <kate@provokateurin.de>	3 months ago
nextcloud-command	fd14234a6a	refactor: Apply rector changes ... Signed-off-by: GitHub <noreply@github.com>	3 months ago
Josh	fff2a542ba	chore(FileInfo): fixup code typo ... Signed-off-by: Josh <josh.t.richards@gmail.com>	3 months ago
Josh	92a28290a3	fix(FileInfo): harden getChecksum() ... - `checksum` is already optional/derived metadata in practice - callers already treat `null`l / `''` as "no checksum" Signed-off-by: Josh <josh.t.richards@gmail.com>	3 months ago
John Molakvoæ	ee602dcfe4	fix: adjust wording in S3ConnectionTrait comment ... Co-authored-by: Louis <louis@chmn.me> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>	3 months ago
John Molakvoæ (skjnldsv)	c26b1e4b07	fix(s3): add Content-MD5 header for DeleteObjects to fix AWS SDK v3.339.0+ compatibility ... AWS SDK PHP v3.339.0+ introduced a breaking change requiring the Content-MD5 header for DeleteObjects operations. This causes 'MissingContentMD5' errors when using S3-compatible services like MinIO. Add middleware to automatically calculate and inject the Content-MD5 header on all DeleteObjects requests. This is applied universally at the S3ConnectionTrait level, fixing both external storage (AmazonS3) and core ObjectStore (S3) classes. Fixes: https://github.com/aws/aws-sdk-php/issues/3068 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	3 months ago