nextcloud-server

Commit Graph

Author	SHA1	Message	Date
Stephen Cuppett	b6fddabf6c	fix(encryption): Address review feedback and fix zero-byte size consistency Apply come-nc's reviewer suggestions on Scanner.php: - Simplify cached unencrypted_size skip condition to explicit == 0 check - Remove redundant !isset guard on new-file path Fix remaining > 0 / !== 0 guards that treated zero as "no unencrypted_size": - FileInfo constructor: use encrypted flag for rawSize (getSize(false) path) - FileInfo::addSubEntry: use encrypted flag for sub-mount accumulation - Cache::calculateFolderSizeInner: use encrypted column instead of > 0 Add tests covering zero-byte encrypted file scenarios: - FileInfoTest: getSize(true/false) for zero-byte encrypted files - CacheTest: getUnencryptedSize and calculateFolderSize with encrypted=1,size=0 - EncryptionTest: verifyUnencryptedSize data provider cases for header-only files Assisted-by: ClaudeCode:claude-opus-4-6 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Stephen Cuppett <scuppett@redhat.com>	1 month ago
Kent Delante	9174cd966f	fix(files): preserve encryptedVersion when copying cache entries Cache::copyFromCache() rebuilt the target's cache row via cacheEntryToArray(), which only carried over a boolean `encrypted` flag and dropped the real `encryptedVersion` count. Since View::copy() unconditionally calls copyFromCache() after the storage copy completes, this silently overwrote the correct encryptedVersion that Encryption::updateEncryptedVersion() had just set, collapsing it back to 0/1 on every copy of a file whose encryptedVersion was above 1. cacheEntryToArray() now includes the source entry's encryptedVersion when it is encrypted. The existing encrypted-to-non-encrypted-storage override in copyFromCache() also clears encryptedVersion alongside `encrypted`, since normalizeData() prefers encryptedVersion over `encrypted` when both are present in the update data. Signed-off-by: Kent Delante <kent@delante.me> Assisted-by: ClaudeCode:claude-sonnet-5	1 month ago
Git'Fellow	fcc63b9603	refactor(dbal): move to modern calls Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Signed-off-by: Carl Schwan <carlschwan@kde.org>	1 month ago
Robin Appelman	17a7a95553	perf: delay loading storage info in Cache untill needed Signed-off-by: Robin Appelman <robin@icewind.nl>	2 months ago
Carl Schwan	994565fec7	refactor: Use new IQueryBuilder::MAX_IN_PARAMETERS Signed-off-by: Carl Schwan <carlschwan@kde.org>	3 months ago
Côme Chilliet	1ab09ec753	chore: Apply new coding standard to all files The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines To see only the changes not related to blank lines. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	3 months ago
provokateurin	b1724dbad0	chore(Cache): Remove deprecated insert and update events Signed-off-by: provokateurin <kate@provokateurin.de>	3 months ago
nextcloud-command	fd14234a6a	refactor: Apply rector changes Signed-off-by: GitHub <noreply@github.com>	3 months ago
Robin Appelman	06c625f20c	perf: remove unneeded sort in getFolderContentsById Signed-off-by: Robin Appelman <robin@icewind.nl>	4 months ago
Git'Fellow	3bbe0ee570	refactor: use strict operator Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>	4 months ago
Ferdinand Thiessen	e0ba4d71b6	chore: add missing `Override` attribute to `OC` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	4 months ago
Robin Appelman	7dccf5f257	fix: give target file all permissions on copy Signed-off-by: Robin Appelman <robin@icewind.nl>	5 months ago
Cristian Scheid	7f89490cef	feat: set creation_time on file creation and render recently created icon Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>	6 months ago
nextcloud-command	663018455e	refactor: Apply rector changes Signed-off-by: GitHub <noreply@github.com>	6 months ago
Carl Schwan	edd37d349b	perf(file-cache): Add mimetype filter on getFolderContents Signed-off-by: Carl Schwan <carlschwan@kde.org>	6 months ago
Carl Schwan	9741f5f17d	perf: Allow filtering the directory content by mimetype Signed-off-by: Carl Schwan <carlschwan@kde.org>	6 months ago
Carl Schwan	7b6078875b	refactor: Run rector on lib/private Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>	7 months ago
Carl Schwan	7100c71166	perf(metadata): Add optimized sharding for metadata deletion Signed-off-by: Carl Schwan <carlschwan@kde.org>	7 months ago
Carl Schwan	fd3878448b	feat(filecache): Scale DB query created when deleting file from filecache Instead of creating a CacheEntryRemovedEvent for each deleted files, create a single CacheEntriesRemovedEvent which wrap multiple CacheEntryRemovedEvent. This allow listener to optimize the query they do when multiple files are deleted at the same time (e.g. when deleting a folder). Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>	7 months ago
Carl Schwan	dd26a8b7eb	fix(cache): Fix parsing cache entry from groupfolder and collectives Signed-off-by: Carl Schwan <carlschwan@kde.org>	7 months ago
Robin Appelman	a79bf069a3	fix: dont error on missing path_hash/checksum cacheentry fields Signed-off-by: Robin Appelman <robin@icewind.nl>	7 months ago
Carl Schwan	06827970a8	fix(cache): Handle groupfolder specific entries in cacheEntryFromData Signed-off-by: Carl Schwan <carlschwan@kde.org>	7 months ago
Carl Schwan	0b8eae7789	perf(files): Optimize CacheEntry creation Avoid many copy on writes and create array only once. Signed-off-by: Carl Schwan <carlschwan@kde.org>	7 months ago
Benjamin Frueh	989b75ee43	fix: Clear mount cache when file storage changes during move Signed-off-by: Benjamin Frueh <benjamin.frueh@gmail.com>	9 months ago
provokateurin	ef279f6049	fix(files): Stop overwriting scan_permissions Signed-off-by: provokateurin <kate@provokateurin.de>	11 months ago
Côme Chilliet	12532bb535	fix(encryption): Correctly set encrypted to 0 when copying If encryption got disabled, copying should set encrypted to 0 for the new unencrypted copy. For instance when using encryption:decrypt-all Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>	12 months ago
Carl Schwan	c4e6fbdae7	fix(query-builder): Don't catch UniqueConstraintViolationException UniqueConstraintViolationException is no longer throw directly but instead is now wrapped inside a \OCP\DB\Exception. So check the exception reason. Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>	12 months ago
Carl Schwan	c21b8169ff	refactor(querybuilder): Port away from qb::execute() in lib/ Replace by either executeStatement or executeQuery Signed-off-by: Carl Schwan <carl.schwan@nextclound.com>	12 months ago
Robin Appelman	1a716578fd	fix: fix moving cache items from cache jail with sharding Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Ferdinand Thiessen	5981b7eb51	chore: apply new CSFixer rules Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de> # Conflicts: # apps/settings/lib/SetupChecks/PhpOpcacheSetup.php	1 year ago
Robin Appelman	5329c373cc	fix: improve error message when cache rename source can't be found Signed-off-by: Robin Appelman <robin@icewind.nl>	1 year ago
Benjamin Gaussorgues	9bdee76535	perf(files): faster query to fetch incomplete directories Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>	2 years ago
Ferdinand Thiessen	b48ee2e924	fix: Harden files scanner for invalid null access Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 years ago
Robin Appelman	6419de7acc	fix: use scan_permissions when copying cache items Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	88c685f27c	fix: store unmaked source permissions as scan_permissions when loading share cache items Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Louis Chemineau	f9cda54cbf	fix: Wrap partial cache entry in CacheEntry Because it is returned here: `7b7d07c575/lib/private/Files/Cache/Cache.php (L136-L137)` And some implementation got stricter: `df95bf6ba8/lib/Mount/RootEntryCache.php (L23-L28)` Signed-off-by: Louis Chemineau <louis@chmn.me>	2 years ago
dependabot[bot]	bb598c8451	chore(deps): Bump nextcloud/coding-standard in /vendor-bin/cs-fixer Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/nextcloud/coding-standard/releases) - [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md) - [Commits](https://github.com/nextcloud/coding-standard/compare/v1.3.1...v1.3.2) --- updated-dependencies: - dependency-name: nextcloud/coding-standard dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Git'Fellow	a1681b0756	chore(db): Apply query prepared statements Fix: psalm fix: bad file fix: bug chore: add batch chore: add batch chore: add batch fix: psalm	2 years ago
Ferdinand Thiessen	a8f46af20f	chore: Add proper deprecation dates where missing Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>	2 years ago
Robin Appelman	75cf17e4c4	fix: verify that parent exists in cache when inserting Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
provokateurin	714671a8a6	fix(files): Adjust Cache::searchQuery() parameter name to match interface Signed-off-by: provokateurin <kate@provokateurin.de>	2 years ago
Robin Appelman	da59fd4389	fix: misc code fixes around db sharding Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Louis Chemineau	2574cbfa61	chore: Apply php:cs recommendations Signed-off-by: Louis Chemineau <louis@chmn.me>	2 years ago
Robin Appelman	390f6a78b4	fix: hint storage id in more places Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	62f8b6517f	feat: implement distributing partitioned queries over multiple shards Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Daniel Kesselberg	af6de04e9e	style: update codestyle for coding-standard 1.2.3 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>	2 years ago
Robin Appelman	80f8c7949e	fix: always set storage id in Cache::get Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	5ff7bde3fb	fix: add set storage id for more cache queries Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	c82d382a20	feat: add base class for extending the query builder Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago
Robin Appelman	082c6c6e1d	fix: get child ids for folder in a separate query during move Signed-off-by: Robin Appelman <robin@icewind.nl>	2 years ago

1 2 3 4

175 Commits (55e1270b94aa0f4ea003e2cbc87a8ea56bcae96d)