32 Commits (5cd1880daa048a685da689c7f41a2e50486494de)

Author	SHA1	Message	Date
Daniel Calviño Sánchez	e39db808fb	Fix rendering of the sidebar in Files app ... When a view is rendered it should not be concerned with where it is going to be placed in the document; in general this should be a responsibility of the object using the view. Moreover, when the details view is rendered it should simply prepare a skeleton that includes the root elements provided by the plugins; those elements will be updated by the plugins as needed when a file or a tab is selected. Finally, the details view should not be explicitly rendered. The rendering removes the previous elements, but that is needed only when the details view is in a dirty state, that is, when new plugins were added since the last time that it was rendered. However, that dirty state is internally handled, and the view is automatically rendered again if needed when a file info is set. Due to all that the details view is no longer explicitly rendered when updating it with a different file. Also, as each file list has its own details view, and each details view has its own element, but there can be only one details view/sidebar element in the document, when the file list updates the details view it also replaces the current one in the document with its own details view if needed (that is, if it is not the current one already). Besides that, when the element of a details view is replaced with the element of a different details view the old one should be detached from the document, but never removed. Otherwise the event handlers would not work when that element is attached again later (when changing to a different section in the Files app and then going back to the previous one). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Stefan Weil	2ad38200fb	Add missing semicolons ... This fixes some recommendations from LGTM: Avoid automated semicolon insertion (90% of all statements in the enclosing function have an explicit semicolon). Signed-off-by: Stefan Weil <sw@weilnetz.de>	7 years ago
Julius Härtl	45804b5bef	Add icon to file sidebar tabs ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Daniel Calviño Sánchez	53aad9901d	Make possible for tab views to add CSS classes to their container ... In general the style of the tabs container should not change depending on which tab is the currently selected one. However, this could be needed in some very specific cases, so now the tab views can specify the extra CSS classes to be used in their container when they are selected. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Roeland Jago Douma	187953153a	Move detailsview to compiled handlebars ... Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Julius Härtl	16f6c07173	Always call render to replace the app-sidebar if the detail view is updated ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	8 years ago
John Molakvoæ (skjnldsv)	8d3f58c391	Jsunit fixes 1 ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	d6b718584e	Sidebar fix ... Fix sidebar and scrollbar on content Sidebar fixes, and sidebar-width + header-height variables Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Kevin Ndung'u	4e1feb5c7b	Add focus indicator for file details view tabs ... Signed-off-by: Kevin Ndung'u <kevgathuku@gmail.com>	8 years ago
Morris Jobke	5445b1ff17	Remove unused variables ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Jan-Christoph Borchardt	9fb37a2990	Add proper labels to various form elements and buttons ... Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>	8 years ago
Daniel Calviño Sánchez	0a3d9f25c1	Make possible to know the registered detail views in a details view ... In some cases, an app may need to act on a detail view registered by another app or the core, for example, to add extra elements to the element of the detail view. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	9 years ago
Vincent Petry	a8fb0038e9	Hide sidebar tab headers conditionally ... Added canDisplay() in DetailsTabView that should return false if the tab header of this tab must be hidden	10 years ago
Vincent Petry	5e4a52d3c2	Fix tabs order in files sidebar	10 years ago
Vincent Petry	fa725fba73	Properly show sidebar for trash and sharing sections	10 years ago
Vincent Petry	310d797284	Add versions tab to files sidebar ... - move versions to a tab in the files sidebar - added mechanism to auto-update the row in the FileList whenever values are set to the FileInfoModel given to the sidebar - updated tags/favorite action to make use of that new mechanism	11 years ago
Raghu Nayyar	468bde67ff	Removes unecessary divs and adds max width to longer names.	11 years ago
Vincent Petry	e2549fa660	Improve right sidebar tabs behavior ... Tab heads are not rendered if only one tab. The tab contents is updated on-demand. This means that if a tab is not visible it is not rendered at first. If the tab was already rendered through switching, its model will not get updated until the next time it becomes visible. This will prevent needless rerendering of invisible tab contents, especially considering that some tabs might need extra ajax requests.	11 years ago
Vincent Petry	c964eff17b	Make file actions work from sidebar ... The favorite icon in the sidebar now triggers the file action and also updates itself according to the model's state when triggered from the file row. The thumbnail triggers the default action. Currently only one FileInfoModel is used for the selection and state synchronization between views. FileList reload now auto-closes the sidebar.	11 years ago
Vincent Petry	781ba420c9	Use own tabs impl in files sidebar ... Also change style.	11 years ago
Arthur Schiwon	5af59c6871	rename sidebar element and use css and js utility functions to core	11 years ago
Arthur Schiwon	f508cf40da	sidebar shall not overlap but shrink the contnet	11 years ago
Arthur Schiwon	7a982872e7	Main view does not commands detail and tab views to render. Fixes JS tests. ... For a predictive behaviour we need to determine who is allowed to call render methods on the views. Either, the main view is solely allowed to call render and views do not do anything about output until then. Or, the main view relies on the concrete views to be ready when things are about to be shown. The latter approach has the advantage that concrete views know when they have to update themselves (e.g. new data arrives or information change), but the main view has now idea of the inner workings.	11 years ago
Vincent Petry	3e44ca6dc2	Added unit tests for right sidebar	11 years ago
Vincent Petry	f11946c8c0	Improve layout, fix mime icon	11 years ago
Vincent Petry	deb9d4d778	Right sidebar now has its own scrollbar	11 years ago
Vincent Petry	ad90ba27cd	Styling fixes + hightlight in files sidebar ... Sidebar scrolls with contents Highlight currently show file	11 years ago
Vincent Petry	ff614a7dbd	More fixes to the right sidebar ... Sidebar now works in all file list views. Moved owner to share tab.	11 years ago
Vincent Petry	12e5f310dd	Improved right sidebar ... Added owner info. Added animation, but causes scrollbal. Default file action now when clicking on name directly. Fixed icon. Added empty share tab.	11 years ago
Vincent Petry	9854e71d2c	Basic work for right sidebar ... Adds right sidebar with registrable panels (still WIP)	11 years ago