254 Commits (5cd1880daa048a685da689c7f41a2e50486494de)

Author	SHA1	Message	Date
Julius Härtl	f9536b0809	Check for target folder available quota when uploading ... Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Christoph Wurst	ae0a496da8	Bump jquery from 2.2.4 to 3.1.0 ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	5 years ago
Azul	43f0d2a3b5	Allow opening files for editing in new tabs ... In a file list files with a default action have an href that will trigger the action. This way ctrl-click and middle button click open the default action in a new tab. In order to achieve this a new param `openfile` was introduced to the files app. It will make the files app trigger the default action for the file in question. This also allows linking to file content rather than just the details display. Introduce fileList.getDefaultActionUrl() to create a link with that param set. It's overwritten in the trashbin fileList so that anchors continue to have `#` as a href. Fix the link generation for subfolders of public shares: 58a87d0 was the last commit that touched the linkTo function in public.js. It included the params as arguments to the generateUrl function. Turns out this completely ignores the dir parameter now. The inclusion was reverted in other places so revert it here as well. Also change `dir` to `path` in the param as that is respected when following the link. Add Test for the new link url for files with default action. Remove test for multiple selects with ctrl-click as that is not what we are doing anymore. Signed-off-by: Azul <azul@riseup.net>	6 years ago
John Molakvoæ (skjnldsv)	a48359ac02	Adjust unit tests to new OCA.Sidebar ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
Julius Härtl	5e4eda1ae0	Remove deprecated legacy file actions ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	6 years ago
John Molakvoæ (skjnldsv)	ff164db935	Add link icon for public link too ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	7 years ago
Tomasz Grobelny	701f7902d2	Fix unit tests ... Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>	7 years ago
Morris Jobke	a938f0ea9d	Add abort stub in JSUnit ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Tomasz Grobelny	04d326f95f	Fix unit tests ... Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>	7 years ago
Morris Jobke	c09560627f	Enhance jsunit tests ... Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Julius Härtl	c48722c201	Fix file move tests ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Tomasz Grobelny	41687ef00f	Fix move related tests ... Signed-off-by: Tomasz Grobelny <tomasz@grobelny.net>	7 years ago
Jan-Christoph Borchardt	39ff82f707	Use grid view in other file views too ... Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>	7 years ago
Julius Härtl	c316eb6b97	Tests: Properly compare the file action label ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Christoph Wurst	9af69ca2a5	Fix usage of deprecated OC.webroot ... Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	7 years ago
Michael Weimann	2de34d7778	Improves the tests ... Signed-off-by: Michael Weimann <mail@michael-weimann.eu>	7 years ago
Michael Weimann	f18fc851c0	Adds a test to check that the sorting isn't stored without an user ... Signed-off-by: Michael Weimann <mail@michael-weimann.eu>	7 years ago
Jan-Christoph Borchardt	a2ad1b9aa9	Fix ability to open file or folder via keyboard, fix #10008 ... Before, the file or folder was opened when clicking on the name span, but not when clicking on the link that contains the name; clicking on the link highlighted the file and opened the sidebar, just like clicking on the file size or date. Now clicking on the link opens the file or folder, so the unit tests that tested clicks on the link were changed to test clicking on the file size instead. Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>	8 years ago
John Molakvoæ (skjnldsv)	8d3f58c391	Jsunit fixes 1 ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	bd1929a3b1	Fixed tests ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Abijeet	419d72e0ee	Adds a test case for the loading symbol in deleted files. ... Signed-off-by: Abijeet <abijeetpatro@gmail.com>	8 years ago
Abijeet	e89f6590e2	Fixed failing test cases for the new actions menu. ... Signed-off-by: Abijeet <abijeetpatro@gmail.com>	8 years ago
Julius Härtl	951ac518e1	Fix jsunit tests ... Signed-off-by: Julius Härtl <jus@bitgrid.net>	8 years ago
John Molakvoæ (skjnldsv)	cee5be6ff2	Fixed jsunit ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Daniel Calviño Sánchez	ad71abca6f	Update comments in tests ... Menu and home are not always visible; home is always visible, but menu is shown only when needed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	10e9eeec45	Fix menu visibility ... The crumb for the menu was shown like any other crumb when calling "_showCrumb", but it was also shown when other crumbs were hidden without taking into account the available width. This caused several related problems, like the breadcrumbs taking too much space when the menu was sometimes shown after the rest of the crumbs were adjusted to the available width, or the menu being shown instead of the last crumb even if there was room for it when the available width was increased. Now the menu is always hidden before starting the resizing of the crumbs to ensure that whether it was previously shown or not does not affect the result. In a similar way, the menu will no longer be shown by "_showCrumb", as it is not a regular crumb that has to be shown simply if there is enough room. The menu is now shown as soon as any other crumb is hidden; this ensures that the menu width will be taken into account in further width checks. As when _updateMenu" is called it no longer needs to take care of showing the menu this fixes the issue revealed when fixing the test setup in the previous commit. Finally, this implicitly fixes the failure in the breadcrumbs tests when run on Firefox, as it was caused by the menu interfering in the calculations of the other crumbs when increasing the width. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	1bcba56d8f	Fix setup to test the breadcrumbs menu ... The "Shows only items not in the breadcrumb" test was failing when run on Firefox, but not on PhantomJS. This was caused by the differences in the starting width between both browsers and an incorrect setup of the test (the width set for the crumbs was overriden when the breadcrumbs were rendered again, and the breadcrumb was resized to 300 from an indeterminate initial width). Now the crumbs are rendered and then its width, padding and margin are set to a known value. Then it is resized to 1000px, which ensures that there will be enough room for all the crumbs and thus the menu will be hidden, and finally it is resized to 300, which causes the middle crumb to be hidden and the menu to be shown. Note, however, that the test now always fails, no matter if it is run on PhantomJS or on Firefox; if the menu crumb is hidden when "_updateMenu" is called it will show it, but it will also wrongly try to add the menu itself to the menu. As the "crumb-id" of the menu crumb is "-1" this causes the last regular crumb to be added to the menu. This will be fixed with other related issues in the next commit. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	92345f2c38	Take padding and margins of crumbs into account ... When calculating the total width of the crumbs only its padding was taken into account; now the margin is too. In a similar way, before showing a crumb only its width was taken into account; now its padding and margin are taken into account too. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	29c924f74b	Use hard-coded values for paddings and margins ... This ensures that the resize tests do not depend on the values set in the CSS files. Note that this change causes a test to fail with Firefox, but not with PhantomJS. This is due to a difference in the starting width used by Firefox and by PhantomJS, and it will be fixed in a following commit. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	acdf091f84	Compress siblings before calculating the available width for crumbs ... When the parent element of the breadcrumbs was resized to a larger width and the siblings of the breadcrumbs expanded to fill all the available width some crumbs could be hidden even if there was enough room for them. The reason was that the width of the siblings being used to calculate the available width for the breadcrumbs was the expanded width of the siblings. Now as many crumbs as possible (that is, fitting in the parent, no matter the siblings) are first shown so the expanding siblings are compressed before calculating the available width. Due to the lack of support for flexboxes in PhantomJS the related unit test is skipped; it has to be run in other browser, like Firefox. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	a37007f872	Take all visible siblings into account ... Other apps could add elements to the controls outside the creatable actions div (for example, the button to switch to the gallery), so the widths of all the visible siblings of the breadcrumbs have to be taken into account in the size calculations. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	e37c4fd7f3	Take padding and margin of the creatable actions div into account ... There are some differences in width handling between the browsers used to run the tests, most likely due to their support (or lack of) of certain CSS features: PhantomJS requires "width" to be set (probably because it does not handle flex displays and treats it like a block, so "min-width" does not matter in this case), while Firefox requires "min-width" to be set (otherwise the children of "#controls" could be compressed due to its use of flex display and the elements would end with a different width than the one needed for the tests). Due to all that the width of the breadcrumb siblings must be specified in the tests using both "width" and "min-width". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	3850221ae1	Do not render the breadcrumbs again in resize tests ... There is no need to call "setDirectory" again in resize tests; it is enough to simply resize them (and isolates them better to just test the resizing behaviour). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	a9552de089	Set the width of the parent element in breadcrumb tests ... Setting the width of the parent element of the breadcrumbs and then explicitly calling "_resize" is enough to test the resizing behaviour. This makes possible to remove the "setMaxWidth" method and its related code, which was used only for testing purposes. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Roland Tapken	38ba64af77	Split move and copy operations ... The new 'Move and copy' operation from #6040 requires UPDATE permissions on the selected files. However, READ would be sufficient to create a copy of a file (if not viewed as a public share). For this reason this patch: - changes the permission of the 'MoveCopy' action to PERMISSION_READ - changes the label of the action depending on the permissions - changes the available buttons in the Move/Copy dialog depending on the permissions. The same changes are done to the filelist view for bulk actions. Signed-off-by: Roland Tapken <roland@bitarbeiter.net>	8 years ago
Daniel Calviño Sánchez	f29c1cf13a	Fix empty details view after renaming a file ... "FileList._updateDetailsView" expects either a file name (as a string) or a file model (as an "OCA.File.FileInfoModel"), but when called through "updateInList" an "OC.Files.FileInfo" object was given instead. As the given attribute was not a model "_updateDetailsView" treated it as a file name and tried to get the model for that file, which failed and caused the details view to be emptied. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	7a088cfcf5	Move adding test files to "beforeEach()" ... All the tests in the "Renaming files" section added the test files, although those calling "doRename()" added them by setting a path for the file too. However, the path is ignored in the other tests, so adding the files can be unified and moved to "beforeEach()". This would be needed, for example, to show the details view for a file before calling "doRename()". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	3113ee1129	Hide favourite icon in details view if favourite action is not available ... When the favourite icon in the details view is clicked the "Favorite" action is triggered. However, if the action name given to "triggerAction" is not found then the "Download" action is triggered instead. As the "Favorite" action is not available in some file lists (like "Recents") the "Download" action was executed instead in those cases, which was a strange behaviour. Now the favourite icon is hidden if its action is not available. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	ea40ade8ad	Fix "fileActions.currentFile" not set before using it ... When an empty area of a file row was clicked and the "Details" action was executed "fileActions.currentFile" was not guaranteed to be set to the appropriate object (it depended on the previous actions of the user), so when it was used by "getCurrentMimeType()" and other FileActions functions they may not work as expected. Now it is explicitly set to the appropriate value before its use. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
John Molakvoæ (skjnldsv)	8cc90ab4de	Fixed breadcrumbs tests ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Daniel Calviño Sánchez	7760f16521	Trigger events before and after a file action is executed ... In the same way that other elements can know when a FileAction is registered or a default action is set this commit makes possible to be notified before and after a FileAction is executed. This is achieved by wrapping the registered action handler in a custom function that notifies the listeners before and after executing the handler itself. Due to this approach only FileActions registered through "registerAction" trigger the events, although that is not a problem as this is how the actions should be added to the FileActions anyway. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Bjoern Schiessle	7bc28f14de	show e2e folder icon on encrypted folders ... Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	8 years ago
Daniel Calviño Sánchez	37d8d3d858	Add data attribute to file list rows telling if the file is encrypted ... Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
John Molakvoæ (skjnldsv)	8c2dbeb13a	Added more tests and only test jsunit on drone (for testing only) ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	b4f5b38713	Add menu tests ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	85355e98e6	Fixed tests and width calculation ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	b001060556	Fixed remaining tests ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	694a96d938	Fixed some more test and loop fix ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	267b673ccb	Updated tests according to new system ... Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Daniel Calviño Sánchez	e6b74fac40	Add proper handling of files without permissions ... Now a file gets its directory permissions only if it contained no permissions (they were undefined or null), but not if its permissions were set to "NONE". Besides that, now file actions that do not require any permission on the file to be performed can be used on files that have no permissions. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago