nextcloud-server

Commit Graph

Author	SHA1	Message	Date
John Molakvoæ (skjnldsv)	876d6ec8e6	Fixed jsunit Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	7 years ago
Julius Härtl	95e34407bf	Add tests for edit permission state on file shares Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Daniel Calviño Sánchez	a1e3098322	Add "Hide download" to the menu of link shares Hiding the download does not depend on other settings and it does not affect other settings either (for example, it would be possible to hide the downloads yet make the share editable), so a simple checkbox was added to the menu. However, note that this option is only available for files, but not for folders. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Claas Augner	d5e142a336	OC.getCanonicalLocale: fix tests Signed-off-by: Claas Augner <git@caugner.de>	7 years ago
Claas Augner	00b8be60f2	humanFileSize: use toLocaleString humanFileSize: add test with locale humanFileSize: use canonical locale humanFileSize: skip test w/o toLocaleString support humanFileSize: stub getCanonicalLocale OC.getCanonicalLocale: cover undefined case humanFileSize: fix getCanonicalLocale stub Signed-off-by: Claas Augner <git@caugner.de>	7 years ago
Daniel Peukert	7a5d6ac15c	Fix failing tests and add some more Signed-off-by: Daniel Peukert <dan.peukert@gmail.com>	7 years ago
Julius Härtl	0b4ea70995	Tests: Remove spacing from html before comparing the template Signed-off-by: Julius Härtl <jus@bitgrid.net>	7 years ago
Roeland Jago Douma	056a74e323	Fix plural function to be hardcoded No more weird eval to construct a plural function. We just use the plural function from symfony. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	7 years ago
Moritz Beck	b68661ed6e	Allow "same-origin" as "Referrer-Policy" Fixes #11531 Although "same-origin" is more strict than e.g. strict-origin it showed up a warning in setupcheck Based on https://scotthelme.co.uk/a-new-security-header-referrer-policy/ Signed-off-by: Moritz Beck <git@birkenstab.de>	7 years ago
Daniel Calviño Sánchez	d143b43a04	Make possible to set the expected status of the well known URL check The check is based on the HTTP status returned by the URL, and different URLs may return different status (for example, DAV returns 207, while a service like WebFinger would return 200), so the expected status needs to be set depending on the URL. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Morris Jobke	b8d54bd53a	Fix a misleading setup check for .well-known/caldav & carddav The problem is that the version without the slash is the correct one. Signed-off-by: Morris Jobke <hey@morrisjobke.de>	7 years ago
Christoph Wurst	9af69ca2a5	Fix usage of deprecated OC.webroot Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	7 years ago
Arthur Schiwon	b628ec4701	adjust and extend js unit tests Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	7 years ago
Timo Förster	006e150c87	Change check if secure randomness is possible. Signed-off-by: Timo Förster <tfoerster@webfoersterei.de>	7 years ago
John Molakvoæ (skjnldsv)	13230f180a	Fix jsunit Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	7 years ago
Michael Weimann	7aed47f776	Adds tests for the memory checks Signed-off-by: Michael Weimann <mail@michael-weimann.eu>	7 years ago
Michael Weimann	1d2bc9c45e	Adds tests for the setup memory limit checks Signed-off-by: Michael Weimann <mail@michael-weimann.eu>	7 years ago
Arthur Schiwon	be873c234b	adapt jsunit test Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>	8 years ago
John Molakvoæ (skjnldsv)	846b8572ed	Tests fixes Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Michael Weimann	ebcfe33d0d	Extends the setup check js tests Signed-off-by: Michael Weimann <mail@michael-weimann.eu>	8 years ago
Joas Schilling	3f45ab97da	Improve URL detection Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago
John Molakvoæ (skjnldsv)	58debbe42c	Tests fixes and design bump Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
John Molakvoæ (skjnldsv)	8d3f58c391	Jsunit fixes 1 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	8 years ago
Morris Jobke	83b1de4493	Fix unit tests - follow up to #10197 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Joas Schilling	72d17ff02c	Improve url detection in comments Signed-off-by: Joas Schilling <coding@schilljs.com>	8 years ago
Cthulhux	f6f49c77f7	opcache module check Improved the speed of isOpcacheProperlySetup() (instant return instead of continuing when we're already failed), added a check for the opcache extension itself. Potentially fixes #9410 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Bjoern Schiessle	f0aaf62b24	fix js tests Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	8 years ago
Morris Jobke	9c4aecb539	Merge all setup checks into one controller * renamed hasMissingIndexes to missingIndexes Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	4a0b7aaf6c	Merge tips & tricks section into setup checks Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Morris Jobke	624d191ef6	Fix wrong hint about missing indexes Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Roeland Jago Douma	4b70c9f89d	Add referrer policy setup check Fixes #9122 Based on https://www.w3.org/TR/referrer-policy/ and https://scotthelme.co.uk/a-new-security-header-referrer-policy/ Setting a sane Referrer-Policy will tell the browser if/when to send referrer headers when accessing a link from Nextcloud. When configured properly this results in less tracking and less leaking of (possibly) sensitive urls * Fix tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	8 years ago
Maxence Lange	0009adae80	SharedWithDisplayName + SharedWithAvatar Signed-off-by: Maxence Lange <maxence@nextcloud.com> Signed-off-by: Morris Jobke <hey@morrisjobke.de>	8 years ago
Daniel Calviño Sánchez	1466586033	Fix ids of permission checkboxes for shares The ids of permission checkboxes for shares were generated using the "shareWith" field of the share. The "shareWith" field can contain spaces (as spaces are allowed, for example, in user or circle names), so this could cause the id attribute of the HTML element to contain spaces too, which is forbidden by the HTML specification. It is not just a "formal" issue, though; when the list was rendered, if the id contained a space the selector to get the checkbox element was wrong (as it ended being something like "#canEdit-view1-name with spaces") and thus the initial state of the checkbox was not properly set. Besides that, "shareWith" can contain too single quotes, which would even cause the jQuery selector to abort the search and leave the UI in an invalid state. Instead of adding more cases to the regular expression to escape special characters and apply it too when the ids are created now the ids of permission checkboxes for shares are based on the "shareId" field instead of on "shareWith", as "shareId" is expected to always contain compatible characters. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	203bf51543	Keep showing the working icon while there are pending operations Before, whenever a pending operation (getting the suggestions, confirming a share or selecting a recipient) finished the working icon was hidden and the confirm button was shown again, even if there were other pending operations (the most common case is typing slowly on the input field, as several operations to get the suggestions could pile if the server response is not received fast enough). Now, the working icon is not hidden until the last pending operation finishes. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	6eb5cc5412	Reuse last suggestions if the same parameters are used When a share is confirmed the suggestions are got to check if there is an exact match. Usually the suggestions were already got with the same parameters in order to fill the autocomplete dropdown, so to avoid a superfluous request now the last suggestions are reused when got again, although only if the same parameters as the last time are used. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	10a4f8e45e	Confirm a share also by pressing enter on the input field Besides confirming a share by clicking on the confirm button now it is possible to do it by pressing enter on the input field. Clicking on the confirm button implicitly hides the autocomplete dropdown. On the other hand, pressing enter on the input field does not, so the autocompletion must be disabled and closed when the confirmation begins and then enabled again once it finishes. Otherwise the autocomplete dropdown would be visible and it would be possible to interact with it while the share is being confirmed. The order in which the input field and the autompletion are disabled is important. Internally, the autocompletion sets a timeout when the input field is modified that requests the suggestions to the server and then shows them in the dropdown. That timeout is not cancelled when the autocompletion is disabled, but when the input field loses its focus and the autocompletion is not disabled. Therefore, the input field has to be disabled (which causes it to lose the focus) before the autocompletion is disabled. Otherwise it could happen that while a share is being confirmed the timeout ends, so an autocompletion request is sent and then, once the share is successfully confirmed and thus the autocompletion is enabled again, the request is received and the autocomplete dropdown is shown with the old suggestions. Strange, but possible nevertheless ;-) Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	9371b61c4d	Add a share when clicking on the confirm button Clicking on the confirm button now adds a share, but only if there is just a single exact match. If there are no exact matches or there is more than one exact match no share is added, and the autocomplete dropdown is shown again with all the suggestions. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	5e2a8cca1b	Return also exact matches besides all suggestions "_getSuggestions" returned all the suggestions from the server, which are composed by exact matches and partial matches. Now the exact matches are also returned on their own parameter. This will be used by the button to confirm a share. Note that until now the order of the suggestions was "exact users, partial users, exact groups, partial groups, exact..."; this commit also changes that order to become "exact users, exact groups, exact..., partial users, partial groups, partial...". This is not a problem, as the suggestions were used in the autocomplete dropdown, and this new order is arguably better than the old one, as all exact matches appear now at the beginning. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	1c440519c2	Show an error when getting the suggestions succeeds with failure content Instead of silently failing now an error is shown to the user when the ajax call to get the suggestions succeeds yet it returns failure content (for example, if an "OCSBadRequestException" was thrown in the server). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	ed1452d7a0	Use "showTemporary" instead of explicitly hiding the notification "OC.Notification.hide" expects the notification to be hidden to be passed as an argument. As it was being used to show a temporary notification the combination of "OC.Notification.show" and "OC.Notification.hide" was replaced by a single call to "OC.Notification.showTemporary". The timeout could have been specified in the options of the call, but it was left to the default value (7 seconds) for consistency with other notifications. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	fcef15af80	Move stub setup outside the test method Stubs should be restored outside the test method in which they are used to ensure that they are properly restored no matter the result of the test (for example, if an exception is thrown). Besides that, this will make possible to reuse the stub in other sibling tests without having to explicitly setup it in them. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	3980364b6d	Add autocompletion tests for each type of share Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	8af9c553e6	Add tests for exact search results already shared with Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	375eab9df3	Add tests for emails and circles already shared with Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Daniel Calviño Sánchez	6fef01c481	Adjust search term to test As the server response is faked the search term is ignored in the tests. However, it is clearer to use a search term that would make the server return what the faked response contains. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	8 years ago
Jan-Christoph Borchardt	ce7775acd0	Replace information icon with confirmation button in share input The confirmation button right now is just an icon; its behaviour will be added in the following commits. Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>	8 years ago
Christoph Wurst	b9720703e8	Add CSRF token controller to retrieve the current CSRF token Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	8 years ago
Vincent Petry	7466468af1	Fix share capabilities JS tests Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>	8 years ago
Maximilian Wende	7c453b2425	Update tests for indeterminate state, fix slashes not being escaped Signed-off-by: Maximilian Wende <dasisdormax@mailbox.org>	8 years ago
Allan Nordhøy	29d68d7a35	There was an error loading → could not load	8 years ago

1 2 3 4 5 ...

393 Commits (5cd1880daa048a685da689c7f41a2e50486494de)